All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramon Fried <rfried.dev@gmail.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>, git <git@xilinx.com>,
	 Joe Hershberger <joe.hershberger@ni.com>
Subject: Re: [PATCH] Revert "net: gem: Disable broadcast setting"
Date: Sat, 15 Jan 2022 18:14:34 +0200	[thread overview]
Message-ID: <CAGi-RUJRzevdaMvoy7fE5koMS9WE+RS2LDjo0f8Jpc2mStsqug@mail.gmail.com> (raw)
In-Reply-To: <fc5f5e2aeca77847ed4ca6a263890375ab9f5163.1642162545.git.michal.simek@xilinx.com>

On Fri, Jan 14, 2022 at 2:15 PM Michal Simek <michal.simek@xilinx.com> wrote:
>
> This reverts commit eafdcda4a854932c0319656de7bf3f017f17ae67.
>
> The main reason is that QEMU is using BOOTP protocol which is sending DHCP
> Offer to a broadcast address that's why it can't be disabled.
> DHCP protocol has no issue because it returns directly to client MAC
> address.
> Both of these options are described in RFC951
> (https://datatracker.ietf.org/doc/html/rfc951#section-4)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/net/zynq_gem.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index f238811786c6..3118d1472669 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -62,7 +62,6 @@
>  #define ZYNQ_GEM_NWCFG_SPEED100                0x00000001 /* 100 Mbps operation */
>  #define ZYNQ_GEM_NWCFG_SPEED1000       0x00000400 /* 1Gbps operation */
>  #define ZYNQ_GEM_NWCFG_FDEN            0x00000002 /* Full Duplex mode */
> -#define ZYNQ_GEM_NWCFG_NO_BRDC         BIT(5) /* No broadcast */
>  #define ZYNQ_GEM_NWCFG_FSREM           0x00020000 /* FCS removal */
>  #define ZYNQ_GEM_NWCFG_SGMII_ENBL      0x08000000 /* SGMII Enable */
>  #define ZYNQ_GEM_NWCFG_PCS_SEL         0x00000800 /* PCS select */
> @@ -80,7 +79,6 @@
>
>  #define ZYNQ_GEM_NWCFG_INIT            (ZYNQ_GEM_DBUS_WIDTH | \
>                                         ZYNQ_GEM_NWCFG_FDEN | \
> -                                       ZYNQ_GEM_NWCFG_NO_BRDC | \
>                                         ZYNQ_GEM_NWCFG_FSREM | \
>                                         ZYNQ_GEM_NWCFG_MDCCLKDIV)
>
> --
> 2.34.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

  reply	other threads:[~2022-01-15 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 12:15 [PATCH] Revert "net: gem: Disable broadcast setting" Michal Simek
2022-01-15 16:14 ` Ramon Fried [this message]
2022-01-17  9:02 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGi-RUJRzevdaMvoy7fE5koMS9WE+RS2LDjo0f8Jpc2mStsqug@mail.gmail.com \
    --to=rfried.dev@gmail.com \
    --cc=git@xilinx.com \
    --cc=joe.hershberger@ni.com \
    --cc=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.