From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30444C433F5 for ; Tue, 14 Sep 2021 09:24:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 337B960E76 for ; Tue, 14 Sep 2021 09:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 337B960E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D6CED83252; Tue, 14 Sep 2021 11:24:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="p2QNIoKy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B52058322D; Tue, 14 Sep 2021 11:24:01 +0200 (CEST) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ECE3283143 for ; Tue, 14 Sep 2021 11:23:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oi1-x234.google.com with SMTP id w144so18059987oie.13 for ; Tue, 14 Sep 2021 02:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cYXijzNouvtzk0aQz2bsbCUoL82lQn2BSDmqDMSvYYM=; b=p2QNIoKyO3UO9epnE5htwzEjYkh4jGc2S7yDOYh1anKcH7l3iYimRmXtsN03KXwmx9 Hm+zWZz/y8KNqjjHkx/GBxk4rnE/zBqklo4uzWXHkdvVezEju8yUBwT9TCR/zw7bDlF7 a5bUENkMzuKWyZ7rmWdbOR1CvgeclBbAabV5rR32W61h+KsrwgEzbIBDFhA1+x4/tlL+ 1WIDrDPeaV/EnbBDkTarOwtTMff+Etper7SkZgD1Lst7cmGEuz/zqqoOBOWV/ura48Nd uJNV5Due4E+HkjdOFOgsPTWRMz+bpail5//N7rNhV3Qx87bKLRbQe7fpnV50zTeYUUJv txlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cYXijzNouvtzk0aQz2bsbCUoL82lQn2BSDmqDMSvYYM=; b=Dj21X8JR5TjvOgrwIzY1+cufx/OYUMkDQzMk1imhCpv+FRkCvgdR4N4AZHBAECi5n8 bmm1YeLZzs+FNjXTChkFeq38A8pLRgnM1O1ys2nUC/Eb4kL6A6eUlyQeOTRIUgYuGsWt 0C+eE7NcMAF1mZ4hRIOLNzPk17pdKm/ZU/dcXUqw+Fb6d+zyJdq8ezahOGnlWu2CV2cf K274ZquDqMthFUR2E90IFWcFjXc5kInGzh4Kze+kGtHPBxD9eCW/REvcXzLBJmcR8oBb QgNay59MFKax0NeTJUvOq6p5th+ly2uvDJs/fQ5YNFkrJJVy9kPolp6qKEfIcTyThK9V Qmpg== X-Gm-Message-State: AOAM532sk9fmqxna7c4fhI7/059Vrn1RaegM7hjwwTvhyGzn6fRlAl5w rs38zHObxBksiVMOL7ELQ28eGKDRk9mcShv5INI= X-Google-Smtp-Source: ABdhPJzpcnGhxWkQmIK6B9YcVTf1hgxNNftV2mZtvfrGAWTIMScm6cR93/1BsVJEP1vXh0qnVLhNZEEa5D19mI67PXw= X-Received: by 2002:a05:6808:d51:: with SMTP id w17mr590902oik.179.1631611436448; Tue, 14 Sep 2021 02:23:56 -0700 (PDT) MIME-Version: 1.0 References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> <20210824120043.3823931-2-vladimir.oltean@nxp.com> In-Reply-To: <20210824120043.3823931-2-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 14 Sep 2021 12:23:45 +0300 Message-ID: Subject: Re: [PATCH v2 1/6] net: dsa: felix: felix_init() can be static To: Vladimir Oltean Cc: Joe Hershberger , U-Boot Mailing List , Claudiu Manoil , Michael Walle , Priyanka Jain Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > No one is calling this function from outside felix_switch.c. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > Tested-by: Michael Walle > --- > drivers/net/mscc_eswitch/felix_switch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c > index f20e84e0f10c..75073880cf87 100644 > --- a/drivers/net/mscc_eswitch/felix_switch.c > +++ b/drivers/net/mscc_eswitch/felix_switch.c > @@ -233,7 +233,7 @@ static void felix_start_pcs(struct udevice *dev, int port, > } > } > > -void felix_init(struct udevice *dev) > +static void felix_init(struct udevice *dev) > { > struct dsa_pdata *pdata = dev_get_uclass_plat(dev); > struct felix_priv *priv = dev_get_priv(dev); > -- > 2.25.1 > Applied to u-boot-net/network-master Thanks, Ramon.