From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C44C433EF for ; Tue, 9 Nov 2021 08:11:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD1C76112D for ; Tue, 9 Nov 2021 08:11:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AD1C76112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6885C83929; Tue, 9 Nov 2021 09:10:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bAWgfR8+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4C72E83932; Tue, 9 Nov 2021 09:10:53 +0100 (CET) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5623B83915 for ; Tue, 9 Nov 2021 09:10:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x331.google.com with SMTP id p11-20020a9d4e0b000000b0055a5741bff7so29720671otf.2 for ; Tue, 09 Nov 2021 00:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XJhttJHj5epsXOwLz5vhyADrNplJukmvAKGZDHi8h08=; b=bAWgfR8+lZ1q3ts12htJSHLgRh2psfYRDH1xPhul7g9MIeQdfgDsa6a9hTJg3eK+UI UOj5DtRW1cFUtAA74LQ93lVU5yfDcv0zM5Ljg0t4Dxei7kIZFpYe4lxXGZ6t7zstu5zJ vOloVJGIxcc3rtPdJxTmJM7om1+R8O1BlpM7u9JvuUljncuM5Jyy9KhUZum/fMjUd5vP 5EDabGvVIh8lN8KTAgP3/PxbRBdtQLPAh2Lj/z4tWtKqm342BfmriJPGopy3cL92oywo GY5guzu26xM5wZiUMcW7edAHJ71KnDLvgu5MYl0WL8XaHMyyFGZ+aY3vIGWcRnAM0MeC x2qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XJhttJHj5epsXOwLz5vhyADrNplJukmvAKGZDHi8h08=; b=fPMeYomNTUQmRDrL25yeuI0YXYIRjx6Uoc4U3HO9IqO7qxU95sIywk2xEaaE3ppZOe 2/FMyqfaOqmBbjXlicE/RHWKsHlkNH2K3C5PnjTJZoZ4PMLQ584CXqQAD5yggdvrdtjV 0YJlMsazt9s6WcncWA/QaUG63RboR3QosTKfnWkuPqMhV+eM6ilhN3CGkEcaphddgtxS ZglTHFTctDGWOFdzOi73SfsgzPjvAUyAOOVpLFs6kZSS/u8vE+rtTwEwlFnbDme+SjCV yufltWui7vDcP70akaQyP4HEBC1VutSSXNa9hpiCfEHUgebpvHTlCahS7zhszXP+VpL8 aU+g== X-Gm-Message-State: AOAM530FEV9GBlkv7af0kBPhPrDDrFreChDFc2bmVIBbbYuUv0OJxPLd xqR131pH36zB0SJi8f615P+wJeQ25MGKyDsLk08= X-Google-Smtp-Source: ABdhPJzwnb19geyuJ6gw09ZUluLX29lCQHJidWPLR1CpGJIfpx6EZCpaEYYaiVecF1NqLtPn2sfXlEro4PC9u5SUbT0= X-Received: by 2002:a9d:1927:: with SMTP id j39mr4123735ota.317.1636445444047; Tue, 09 Nov 2021 00:10:44 -0800 (PST) MIME-Version: 1.0 References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> In-Reply-To: <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> From: Ramon Fried Date: Tue, 9 Nov 2021 10:10:32 +0200 Message-ID: Subject: Re: [PATCH v3 07/18] pxe: Move pxe_utils files To: Simon Glass Cc: U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Tom Rini , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Oct 14, 2021 at 9:50 PM Simon Glass wrote: > > Move the header file into the main include/ directory so we can use it > from the bootmethod code. Move the C file into boot/ since it relates to > booting. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > boot/Makefile | 3 +++ > {cmd => boot}/pxe_utils.c | 0 > cmd/Makefile | 4 ++-- > cmd/sysboot.c | 2 +- > {cmd => include}/pxe_utils.h | 0 > 5 files changed, 6 insertions(+), 3 deletions(-) > rename {cmd => boot}/pxe_utils.c (100%) > rename {cmd => include}/pxe_utils.h (100%) > > diff --git a/boot/Makefile b/boot/Makefile > index a19e85cf6c8..2938c3f1458 100644 > --- a/boot/Makefile > +++ b/boot/Makefile > @@ -14,6 +14,9 @@ obj-$(CONFIG_CMD_BOOTM) += bootm.o bootm_os.o > obj-$(CONFIG_CMD_BOOTZ) += bootm.o bootm_os.o > obj-$(CONFIG_CMD_BOOTI) += bootm.o bootm_os.o > > +obj-$(CONFIG_CMD_PXE) += pxe_utils.o > +obj-$(CONFIG_CMD_SYSBOOT) += pxe_utils.o > + > endif > > obj-y += image.o image-board.o > diff --git a/cmd/pxe_utils.c b/boot/pxe_utils.c > similarity index 100% > rename from cmd/pxe_utils.c > rename to boot/pxe_utils.c > diff --git a/cmd/Makefile b/cmd/Makefile > index ed3669411e6..891819ae0f6 100644 > --- a/cmd/Makefile > +++ b/cmd/Makefile > @@ -123,7 +123,7 @@ obj-$(CONFIG_CMD_PINMUX) += pinmux.o > obj-$(CONFIG_CMD_PMC) += pmc.o > obj-$(CONFIG_CMD_PSTORE) += pstore.o > obj-$(CONFIG_CMD_PWM) += pwm.o > -obj-$(CONFIG_CMD_PXE) += pxe.o pxe_utils.o > +obj-$(CONFIG_CMD_PXE) += pxe.o > obj-$(CONFIG_CMD_WOL) += wol.o > obj-$(CONFIG_CMD_QFW) += qfw.o > obj-$(CONFIG_CMD_READ) += read.o > @@ -145,7 +145,7 @@ obj-$(CONFIG_CMD_SETEXPR_FMT) += printf.o > obj-$(CONFIG_CMD_SPI) += spi.o > obj-$(CONFIG_CMD_STRINGS) += strings.o > obj-$(CONFIG_CMD_SMC) += smccc.o > -obj-$(CONFIG_CMD_SYSBOOT) += sysboot.o pxe_utils.o > +obj-$(CONFIG_CMD_SYSBOOT) += sysboot.o > obj-$(CONFIG_CMD_STACKPROTECTOR_TEST) += stackprot_test.o > obj-$(CONFIG_CMD_TERMINAL) += terminal.o > obj-$(CONFIG_CMD_TIME) += time.o > diff --git a/cmd/sysboot.c b/cmd/sysboot.c > index 85fa5d8aa01..b81255e155a 100644 > --- a/cmd/sysboot.c > +++ b/cmd/sysboot.c > @@ -4,7 +4,7 @@ > #include > #include > #include > -#include "pxe_utils.h" > +#include > > static char *fs_argv[5]; > > diff --git a/cmd/pxe_utils.h b/include/pxe_utils.h > similarity index 100% > rename from cmd/pxe_utils.h > rename to include/pxe_utils.h > -- > 2.33.0.1079.g6e70778dc9-goog > Reviewed-by: Ramon Fried