From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDB45C433EF for ; Sat, 30 Apr 2022 23:30:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BE92583F26; Sun, 1 May 2022 01:30:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WjAkbjas"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4CC8583F26; Sun, 1 May 2022 01:30:05 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5C19E83F2B for ; Sun, 1 May 2022 01:30:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-qv1-xf31.google.com with SMTP id kd11so8152575qvb.2 for ; Sat, 30 Apr 2022 16:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=u76qsvWo9vnJFZGKYcPSot32+T3yvWV9NWb+t3N6wA0=; b=WjAkbjasUmaXyN81HkFOf9IG4rbFkR1Ob37hQ0pzZTrXq94cVn/w1swZA6mvmHLyxw SnacnBHfEA2YC5joFNkiqgk2+H3715PzZdqq2Hp99JP5IIwCP/dK0wC5at5COooJYp+0 1a03IkQXaCHQbRpAgrXsf6z63535/5G3/YqY7cCyI/onlHtUMBYoaRCcUlJ0+fwcFmbc f9GYvxh8PAGPQlnOJWGMiYjvplpT5EP1lgEzqnTG2fqdg+8E+bzSi/RT14HuVdlxOxJ9 LFWOVVdEP1h+F7OaZ15t7Qh6kesN/rj3ZTDzhWsordG6Kgq8JzXEky0Rit/dnR18EG2v l8cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=u76qsvWo9vnJFZGKYcPSot32+T3yvWV9NWb+t3N6wA0=; b=Gj2B0U40v15KUyT1I6Cynbmjot/BRAG8lCWPewYrGH7by1f4QFNBNIjVqnorppDQN+ 1t2m/oHn5JNg9njxSQ7UmfD6u5ilSiaWvFCvn38vnH1dkiW6i+tKh6ckgl72Y1zGS96z tVrBpKkpRpiXeH+v4cvzt1E4BnKPAR0CPtEuCbu3kFtf3RSb5Z1DrEOPOEe3DJo+cF9S oAIiD4Va9D+C70GUvPLWxAtILsy/jOG/SLCGfPTUrMi7pxc0slyZi1HnPDAD7FFhMcT+ aaGit1TDuNmLcB8REGTflHX5bCrmj2jig9TLHjuFZhLGOdhtpezjJEwLcIMs1ytCNcag G68Q== X-Gm-Message-State: AOAM532rshH8itvbLF9cahwB6EOgp+csduRB8VYXs56B6qaPBMJDe5bm Vjz8McH+8UrJbZaiKk6cNpO7W1iSvRkJfzLuMEyX/jnHHABXXQ== X-Google-Smtp-Source: ABdhPJxbWeNik56ztNvYGh0/N+PuLekd+x4Bt5GLbkAWwIJMl85wJCXYqNYk0H3Ksp6tSuv/P3gxbqbolTI9FUxNKV0= X-Received: by 2002:a05:6214:c65:b0:456:45c2:d1d3 with SMTP id t5-20020a0562140c6500b0045645c2d1d3mr4519536qvj.9.1651361399254; Sat, 30 Apr 2022 16:29:59 -0700 (PDT) MIME-Version: 1.0 References: <20220427104202.1205-1-kabel@kernel.org> <20220427104202.1205-11-kabel@kernel.org> In-Reply-To: <20220427104202.1205-11-kabel@kernel.org> From: Ramon Fried Date: Sun, 1 May 2022 02:29:48 +0300 Message-ID: Subject: Re: [PATCH u-boot-marvell 10/19] net: mvneta: Drop one indentation level in mvneta_adjust_link() To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Stefan Roese , Robert Marko , =?UTF-8?Q?Pali_Roh=C3=A1r?= , U-Boot-Denx , Joe Hershberger , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, Apr 27, 2022 at 1:42 PM Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > Drop one indentation level in the mvneta_adjust_link() function. > > Signed-off-by: Marek Beh=C3=BAn > --- > drivers/net/mvneta.c | 38 ++++++++++++++++++-------------------- > 1 file changed, 18 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c > index 72789fc5c6..66d5e10174 100644 > --- a/drivers/net/mvneta.c > +++ b/drivers/net/mvneta.c > @@ -1161,31 +1161,29 @@ static void mvneta_adjust_link(struct udevice *de= v) > return; > } > > - if (phydev->link) { > - if ((pp->speed !=3D phydev->speed) || > - (pp->duplex !=3D phydev->duplex)) { > - u32 val; > + if (phydev->link && > + (pp->speed !=3D phydev->speed || pp->duplex !=3D phydev->dupl= ex)) { > + u32 val; > > - val =3D mvreg_read(pp, MVNETA_GMAC_AUTONEG_CONFIG= ); > - val &=3D ~(MVNETA_GMAC_CONFIG_MII_SPEED | > - MVNETA_GMAC_CONFIG_GMII_SPEED | > - MVNETA_GMAC_CONFIG_FULL_DUPLEX | > - MVNETA_GMAC_AN_SPEED_EN | > - MVNETA_GMAC_AN_DUPLEX_EN); > + val =3D mvreg_read(pp, MVNETA_GMAC_AUTONEG_CONFIG); > + val &=3D ~(MVNETA_GMAC_CONFIG_MII_SPEED | > + MVNETA_GMAC_CONFIG_GMII_SPEED | > + MVNETA_GMAC_CONFIG_FULL_DUPLEX | > + MVNETA_GMAC_AN_SPEED_EN | > + MVNETA_GMAC_AN_DUPLEX_EN); > > - if (phydev->duplex) > - val |=3D MVNETA_GMAC_CONFIG_FULL_DUPLEX; > + if (phydev->duplex) > + val |=3D MVNETA_GMAC_CONFIG_FULL_DUPLEX; > > - if (phydev->speed =3D=3D SPEED_1000) > - val |=3D MVNETA_GMAC_CONFIG_GMII_SPEED; > - else if (pp->speed =3D=3D SPEED_100) > - val |=3D MVNETA_GMAC_CONFIG_MII_SPEED; > + if (phydev->speed =3D=3D SPEED_1000) > + val |=3D MVNETA_GMAC_CONFIG_GMII_SPEED; > + else if (pp->speed =3D=3D SPEED_100) > + val |=3D MVNETA_GMAC_CONFIG_MII_SPEED; > > - mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val); > + mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val); > > - pp->duplex =3D phydev->duplex; > - pp->speed =3D phydev->speed; > - } > + pp->duplex =3D phydev->duplex; > + pp->speed =3D phydev->speed; > } > > if (phydev->link !=3D pp->link) { > -- > 2.35.1 > Reviewed-by: Ramon Fried