All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramon Fried <rfried.dev@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 4/6] net: dwc_eth_qos: remove the field phyaddr of the struct eqos_priv
Date: Thu, 29 Apr 2021 23:12:50 +0300	[thread overview]
Message-ID: <CAGi-RUKbd8hsCCE1y77VB7OPpxpgCrUvTS3J7wRMj3aRNRz0qw@mail.gmail.com> (raw)
In-Reply-To: <20210426174647.v2.4.I98726d4bbd3145e65b872950a884cd8424b10131@changeid>

On Mon, Apr 26, 2021 at 6:47 PM Patrick Delaunay
<patrick.delaunay@foss.st.com> wrote:
>
> Since the commit commit 6a895d039ba7 ("net: Update eQos driver and FEC
> driver to use eth phy interfaces") the field phyaddr of driver private data
> struct eqos_priv is no more used in eqos_start() for the phy_connect()
> parameter.
>
> Now this variable is only initialized in eqos_probe_resources_stm32()
> it can be removed.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
> Changes in v2:
> - remove unused element in the struct eqos_priv (NEW)
>
>  drivers/net/dwc_eth_qos.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> index e8242ca4e1..e625aea8d1 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -311,7 +311,6 @@ struct eqos_priv {
>         struct clk clk_slave_bus;
>         struct mii_dev *mii;
>         struct phy_device *phy;
> -       int phyaddr;
>         u32 max_speed;
>         void *descs;
>         int tx_desc_idx, rx_desc_idx;
> @@ -1826,7 +1825,6 @@ static int eqos_probe_resources_stm32(struct udevice *dev)
>         if (ret)
>                 pr_warn("No phy clock provided %d", ret);
>
> -       eqos->phyaddr = -1;
>         ret = dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
>                                          &phandle_args);
>         if (!ret) {
> @@ -1839,9 +1837,6 @@ static int eqos_probe_resources_stm32(struct udevice *dev)
>                 if (ret)
>                         pr_warn("gpio_request_by_name(phy reset) not provided %d",
>                                 ret);
> -
> -               eqos->phyaddr = ofnode_read_u32_default(phandle_args.node,
> -                                                       "reg", -1);
>         }
>
>         debug("%s: OK\n", __func__);
> --
> 2.17.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

  reply	other threads:[~2021-04-29 20:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 15:46 [PATCH v2 0/6] net: dwc_eth_qos: add support of device tree configuration for reset delay Patrick Delaunay
2021-04-26 15:46 ` [PATCH v2 1/6] net: eth-phy: add support of device tree configuration for gpio reset Patrick Delaunay
2021-04-29 20:10   ` Ramon Fried
2021-07-20 18:02   ` Patrick DELAUNAY
2021-04-26 15:46 ` [PATCH v2 2/6] net: eth-phy: use dev_dbg and log_notice Patrick Delaunay
2021-04-29 20:10   ` Ramon Fried
2021-04-26 15:46 ` [PATCH v2 3/6] net: eth-phy: manage subnode mdio0 Patrick Delaunay
2021-04-29 20:12   ` Ramon Fried
2021-04-26 15:46 ` [PATCH v2 4/6] net: dwc_eth_qos: remove the field phyaddr of the struct eqos_priv Patrick Delaunay
2021-04-29 20:12   ` Ramon Fried [this message]
2021-04-26 15:46 ` [PATCH v2 5/6] net: dwc_eth_qos: use generic ethernet phy for stm32 variant Patrick Delaunay
2021-04-29 20:13   ` Ramon Fried
2021-04-26 15:46 ` [PATCH v2 6/6] net: dwc: add a common empty ops eqos_null_ops Patrick Delaunay
2021-04-29 20:14   ` Ramon Fried
2021-07-09 10:35 ` [PATCH v2 0/6] net: dwc_eth_qos: add support of device tree configuration for reset delay Patrick DELAUNAY
2021-07-10  5:40   ` Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGi-RUKbd8hsCCE1y77VB7OPpxpgCrUvTS3J7wRMj3aRNRz0qw@mail.gmail.com \
    --to=rfried.dev@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.