Re: [PATCH 09/31] net: mediatek: add support for MediaTek MT7981/MT7986

[Ramon Fried <rfried.dev@gmail.com>]

On Thu, Aug 4, 2022 at 6:35 AM Weijie Gao <weijie.gao@mediatek.com> wrote:
>
> This patch adds support for MediaTek MT7981 and MT7986. Both chips uses
> PDMA v2.
>
> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> ---
>  drivers/net/mtk_eth.c | 27 +++++++++++++++++++++++++++
>  drivers/net/mtk_eth.h |  5 +++++
>  2 files changed, 32 insertions(+)
>
> diff --git a/drivers/net/mtk_eth.c b/drivers/net/mtk_eth.c
> index 47a4e698c0..7bff0b5b04 100644
> --- a/drivers/net/mtk_eth.c
> +++ b/drivers/net/mtk_eth.c
> @@ -106,6 +106,7 @@ struct mtk_eth_priv {
>         int force_mode;
>         int speed;
>         int duplex;
> +       bool pn_swap;
>
>         struct phy_device *phydev;
>         int phy_interface;
> @@ -1048,6 +1049,12 @@ static void mtk_sgmii_init(struct mtk_eth_priv *priv)
>         /* SGMII force mode setting */
>         writel(SGMII_FORCE_MODE, priv->sgmii_base + SGMSYS_SGMII_MODE);
>
> +       /* SGMII PN SWAP setting */
> +       if (priv->pn_swap) {
> +               setbits_le32(priv->sgmii_base + SGMSYS_QPHY_WRAP_CTRL,
> +                            SGMII_PN_SWAP_TX_RX);
> +       }
> +
>         /* Release PHYA power down state */
>         clrsetbits_le32(priv->sgmii_base + SGMSYS_QPHY_PWR_STATE_CTRL,
>                         SGMII_PHYA_PWD, 0);
> @@ -1461,6 +1468,8 @@ static int mtk_eth_of_to_plat(struct udevice *dev)
>                         dev_err(dev, "Unable to find sgmii\n");
>                         return -ENODEV;
>                 }
> +
> +               priv->pn_swap = ofnode_read_bool(args.node, "pn_swap");
>         }
>
>         /* check for switch first, otherwise phy will be used */
> @@ -1511,6 +1520,22 @@ static int mtk_eth_of_to_plat(struct udevice *dev)
>         return 0;
>  }
>
> +static const struct mtk_soc_data mt7986_data = {
> +       .caps = MT7986_CAPS,
> +       .ana_rgc3 = 0x128,
> +       .pdma_base = PDMA_V2_BASE,
> +       .txd_size = sizeof(struct mtk_tx_dma_v2),
> +       .rxd_size = sizeof(struct mtk_rx_dma_v2),
> +};
> +
> +static const struct mtk_soc_data mt7981_data = {
> +       .caps = MT7986_CAPS,
> +       .ana_rgc3 = 0x128,
> +       .pdma_base = PDMA_V2_BASE,
> +       .txd_size = sizeof(struct mtk_tx_dma_v2),
> +       .rxd_size = sizeof(struct mtk_rx_dma_v2),
> +};
> +
>  static const struct mtk_soc_data mt7629_data = {
>         .ana_rgc3 = 0x128,
>         .pdma_base = PDMA_V1_BASE,
> @@ -1540,6 +1565,8 @@ static const struct mtk_soc_data mt7621_data = {
>  };
>
>  static const struct udevice_id mtk_eth_ids[] = {
> +       { .compatible = "mediatek,mt7986-eth", .data = (ulong)&mt7986_data },
> +       { .compatible = "mediatek,mt7981-eth", .data = (ulong)&mt7981_data },
>         { .compatible = "mediatek,mt7629-eth", .data = (ulong)&mt7629_data },
>         { .compatible = "mediatek,mt7623-eth", .data = (ulong)&mt7623_data },
>         { .compatible = "mediatek,mt7622-eth", .data = (ulong)&mt7622_data },
> diff --git a/drivers/net/mtk_eth.h b/drivers/net/mtk_eth.h
> index 236c498a1b..1382ccbeb2 100644
> --- a/drivers/net/mtk_eth.h
> +++ b/drivers/net/mtk_eth.h
> @@ -36,6 +36,8 @@ enum mkt_eth_capabilities {
>
>  #define MT7623_CAPS  (MTK_GMAC1_TRGMII)
>
> +#define MT7986_CAPS  (MTK_NETSYS_V2)
> +
>  /* Frame Engine Register Bases */
>  #define PDMA_V1_BASE                   0x0800
>  #define PDMA_V2_BASE                   0x6000
> @@ -72,6 +74,9 @@ enum mkt_eth_capabilities {
>  #define SGMSYS_QPHY_PWR_STATE_CTRL     0xe8
>  #define SGMII_PHYA_PWD                 BIT(4)
>
> +#define SGMSYS_QPHY_WRAP_CTRL          0xec
> +#define SGMII_PN_SWAP_TX_RX            0x03
> +
>  #define SGMSYS_GEN2_SPEED              0x2028
>  #define SGMSYS_GEN2_SPEED_V2           0x128
>  #define SGMSYS_SPEED_2500              BIT(2)
> --
> 2.17.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>