From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B1EC433EF for ; Mon, 1 Nov 2021 20:26:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FACA60ED5 for ; Mon, 1 Nov 2021 20:26:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4FACA60ED5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D56DA8354D; Mon, 1 Nov 2021 21:26:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Y6aiNm77"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0531E8329E; Mon, 1 Nov 2021 21:26:05 +0100 (CET) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A04228329E for ; Mon, 1 Nov 2021 21:26:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x331.google.com with SMTP id v19-20020a9d69d3000000b00555a7318f31so14852332oto.9 for ; Mon, 01 Nov 2021 13:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W8RzClf3FQaOS5kqlxJzY03/D5kM0xLFN9KC70f+Muw=; b=Y6aiNm77FUlrwXdHm5y6F3LG4XNJtlkgBhGjTeCJ+FArtJZj6E6+jBqwWKaJt/UERr jeYOxcYgQjcjCq5ZBslqasiWxsRRNZqstX7C7Sj1mQhUDfWIwXOt5PuFdPdHyGmSgtWh Ewl/TLfmt1VhEREm3xHq4miSTqloxxd2+xWtMPjPzMLMGNUXEoyeE5emceajJtm84KZb p03AnOn7uxoqzLqZTurKchZIzXn97sZ190twQ8NFHnm501OjAqltKXsDBPdlOgOYZO2d hrQYSBETLQQ2hNxLdTLQ1OaMKtKOKjyHx3J5BSclkOv89LKjpHkfUZoIeZfytqp+2giy Ndjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W8RzClf3FQaOS5kqlxJzY03/D5kM0xLFN9KC70f+Muw=; b=l05cAfwITzDYrxioQPCHHBI/K+zZsVs2ueodoyP2U7aorsrE5iZwe+ydr3TpVn+OQU o11RO3tDrNkCXK7lpMRJ/tBf0L17Ot58YQEIpjTUcNcOEPT54DY6MTnzBsX8qF/jthON utmhFqdUR1h0G2belSwOa2rRc6A5rPnSkP71vXBC8i2hFFyeSjsYF41HJGrMhafgSgWe uT2DsljH7FlFD1xKSa6FW8HovO05psEvYDibF6DZTRVYY2OPoZzbNAWVI+cblvA/x0uA 3QhNmuLiyOYXdQEEuqaTCUodk+UvRakHtc4MG+scggP7wxUCEsiXa3aiI4WqvciN2G4g y6PQ== X-Gm-Message-State: AOAM5313NBmfFancqvXDWd/Ix24dz+d/ygnNB2+85JoXdcrGViHkFbqE chcP6w4n+Pd8qSRhp7HURZdd1gwxJ1qzetpR0rY= X-Google-Smtp-Source: ABdhPJxUOSUpKyR7glaz5/Xy0L0iorgQl+AMFugY2phN1hv8N+jxNAx2ujp8nSZe9+ZNMSm6i+WCXHjU9aeV78Gt4jw= X-Received: by 2002:a9d:6b84:: with SMTP id b4mr20016954otq.327.1635798359264; Mon, 01 Nov 2021 13:25:59 -0700 (PDT) MIME-Version: 1.0 References: <3996ba2ee4e6ac136c0802dc0df4ef9b1750157c.1635506067.git.michal.simek@xilinx.com> In-Reply-To: <3996ba2ee4e6ac136c0802dc0df4ef9b1750157c.1635506067.git.michal.simek@xilinx.com> From: Ramon Fried Date: Mon, 1 Nov 2021 22:25:48 +0200 Message-ID: Subject: Re: [PATCH] net: uclass: Save ethernet MAC address when generated To: Michal Simek Cc: U-Boot Mailing List , git , Joe Hershberger , Simon Glass Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Oct 29, 2021 at 2:14 PM Michal Simek wrote: > > When MAC address is randomly generated it should be also saved to > variables. This step is there when MAC address is passed via pdata but not > when it is randomly generated. > > Signed-off-by: Michal Simek > --- > > net/eth-uclass.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/eth-uclass.c b/net/eth-uclass.c > index 0da0e85be031..58c308f33276 100644 > --- a/net/eth-uclass.c > +++ b/net/eth-uclass.c > @@ -583,6 +583,8 @@ static int eth_post_probe(struct udevice *dev) > net_random_ethaddr(pdata->enetaddr); > printf("\nWarning: %s (eth%d) using random MAC address - %pM\n", > dev->name, dev_seq(dev), pdata->enetaddr); > + eth_env_set_enetaddr_by_index("eth", dev_seq(dev), > + pdata->enetaddr); > #else > printf("\nError: %s address not set.\n", > dev->name); > -- > 2.33.1 > Reviewed-by: Ramon Fried