From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFFF6C433F5 for ; Tue, 28 Sep 2021 13:44:52 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5250D61058 for ; Tue, 28 Sep 2021 13:44:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5250D61058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6EC09831A0; Tue, 28 Sep 2021 15:44:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="BBWf9dKK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D119F83135; Tue, 28 Sep 2021 15:44:46 +0200 (CEST) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 76956833BE for ; Tue, 28 Sep 2021 15:33:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x335.google.com with SMTP id j11-20020a9d190b000000b00546fac94456so28952847ota.6 for ; Tue, 28 Sep 2021 06:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7CqR3+6RQPIli+/lTBjDvnhwdudLe9tyB4CGhTK7jGY=; b=BBWf9dKKP1DHrVrPpYI2yqjUVZ7/2KlDqedA0ih9xrHh9oGfweqUU7dcYomZ+usYHd PMmpLRMPXf7kWGBuGYwn8s8Mi38xurA4BOjG1Dl2+G9tAlfdKtL16wnVA4iLuV48oius fs+CGyYYyxXmLWlKRPPKcZrOwz31CY+vZTXL16suKHdfjCDPAjI9kWbPCw5KqH9KcEVp fgSrAauAqWTrfvvdNjTi0KM5XkVrkuIDoGyCGpSDZ+JQcWyc5Kd6t0evA1pn0dVzg52/ Vst5rz2nKtsDjtN2jbAYw5cysH9EPMquEP7q3q3hIt37cn3djZq40x1KXipeCMA8FZJu DA0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7CqR3+6RQPIli+/lTBjDvnhwdudLe9tyB4CGhTK7jGY=; b=7y3q/jZcpvxaQcIQ6zA3EdboKvEfPoK+9kxxq1770+FT/1zGUadaWfoZVEm30KovmH wKfVZOr3Ewoy/i2VAQEI1fOXfIfMXCNCRX+ISVf0JyWc7CZSpe+o2/UXIZsLj6/tTvUd hFKt0TfCam1mBt3G7qgj+HD8B315XGYO/1fAv1bJNsENJEOhfcOhjpVI45hNNtW2uwy7 rQjtKbBS/V70DHubP/tTS92CWdGO/rLcdGapkvnR4vfldyS9wPT8TcwJbwRVcO7S47cF lsEAQlmHOZPBRDfQhuYdyi9GAh2Ae94CvRajjJSQ4UUVwgfKceF3OClCZlLV7ONa3H3M qdZw== X-Gm-Message-State: AOAM53086jWmeb47OYM8rFAJwZcSjKeMu4Nsm1trEYF24hUb0x0egXzW vSXJf6EsLaXgaLOFQPf+jSgXJwnAtIQb41M31Wk= X-Google-Smtp-Source: ABdhPJxt53Bu7nfBjayQx1oi570Eon05iyJNko0rU3A6s4+75ssCw+Jn0og4EQtF5G3lIOgkj1bagDLqzSoWvpmAqoM= X-Received: by 2002:a9d:12ec:: with SMTP id g99mr4090582otg.197.1632836026945; Tue, 28 Sep 2021 06:33:46 -0700 (PDT) MIME-Version: 1.0 References: <20210927112205.301876-1-vladimir.oltean@nxp.com> <20210927112205.301876-20-vladimir.oltean@nxp.com> In-Reply-To: <20210927112205.301876-20-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 28 Sep 2021 16:33:35 +0300 Message-ID: Subject: Re: [PATCH 19/25] net: qe: uec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation To: Vladimir Oltean Cc: U-Boot Mailing List , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previously zero-initialized destination string, but this is more > difficult to maintain. > > The chosen alternative is to use strlcpy(), which properly limits the > copy len in the (srclen >= size) case to "size - 1", and which is also > more efficient than the strncpy() byte-by-byte implementation by using > memcpy. The destination string returned by strlcpy() is always NULL > terminated. > > Signed-off-by: Vladimir Oltean > --- > drivers/qe/uec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c > index 5da971ddc0af..c4bd5c4a147f 100644 > --- a/drivers/qe/uec.c > +++ b/drivers/qe/uec.c > @@ -1407,7 +1407,7 @@ int uec_initialize(struct bd_info *bis, struct uec_inf *uec_info) > > if (!mdiodev) > return -ENOMEM; > - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); > + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); > mdiodev->read = uec_miiphy_read; > mdiodev->write = uec_miiphy_write; > > -- > 2.25.1 > Reviewed-by: Ramon Fried