* [PATCH] net: gem: unregister mdio bus if probe fails
@ 2021-02-10 21:41 Michael Walle
2021-02-11 15:44 ` Ramon Fried
2021-02-11 18:02 ` Michal Simek
0 siblings, 2 replies; 3+ messages in thread
From: Michael Walle @ 2021-02-10 21:41 UTC (permalink / raw)
To: u-boot
If probe fails, the mdio bus isn't unregistered. Fix it.
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/net/zynq_gem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 5cb02bb3a7..585c06d6bd 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -711,10 +711,12 @@ static int zynq_gem_probe(struct udevice *dev)
ret = zynq_phy_init(dev);
if (ret)
- goto err2;
+ goto err3;
return ret;
+err3:
+ mdio_unregister(priv->bus);
err2:
free(priv->rxbuffers);
err1:
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] net: gem: unregister mdio bus if probe fails
2021-02-10 21:41 [PATCH] net: gem: unregister mdio bus if probe fails Michael Walle
@ 2021-02-11 15:44 ` Ramon Fried
2021-02-11 18:02 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Ramon Fried @ 2021-02-11 15:44 UTC (permalink / raw)
To: u-boot
On Wed, Feb 10, 2021 at 11:42 PM Michael Walle <michael@walle.cc> wrote:
>
> If probe fails, the mdio bus isn't unregistered. Fix it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> drivers/net/zynq_gem.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index 5cb02bb3a7..585c06d6bd 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -711,10 +711,12 @@ static int zynq_gem_probe(struct udevice *dev)
>
> ret = zynq_phy_init(dev);
> if (ret)
> - goto err2;
> + goto err3;
>
> return ret;
>
> +err3:
> + mdio_unregister(priv->bus);
> err2:
> free(priv->rxbuffers);
> err1:
> --
> 2.20.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net: gem: unregister mdio bus if probe fails
2021-02-10 21:41 [PATCH] net: gem: unregister mdio bus if probe fails Michael Walle
2021-02-11 15:44 ` Ramon Fried
@ 2021-02-11 18:02 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2021-02-11 18:02 UTC (permalink / raw)
To: u-boot
On 2/10/21 10:41 PM, Michael Walle wrote:
> If probe fails, the mdio bus isn't unregistered. Fix it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> drivers/net/zynq_gem.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index 5cb02bb3a7..585c06d6bd 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -711,10 +711,12 @@ static int zynq_gem_probe(struct udevice *dev)
>
> ret = zynq_phy_init(dev);
> if (ret)
> - goto err2;
> + goto err3;
>
> return ret;
>
> +err3:
> + mdio_unregister(priv->bus);
> err2:
> free(priv->rxbuffers);
> err1:
>
Applied.
M
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-11 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 21:41 [PATCH] net: gem: unregister mdio bus if probe fails Michael Walle
2021-02-11 15:44 ` Ramon Fried
2021-02-11 18:02 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.