From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ramon Fried Date: Thu, 20 May 2021 07:37:57 +0300 Subject: [PATCH 1/2] net: luton: remove address translation after ofnode_read_resource In-Reply-To: <20210518154026.1.I98c378739e65e7fed36a680a86d1c307e71c9460@changeid> References: <20210518134039.26865-1-patrick.delaunay@foss.st.com> <20210518154026.1.I98c378739e65e7fed36a680a86d1c307e71c9460@changeid> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, May 18, 2021 at 4:40 PM Patrick Delaunay wrote: > > Removed call of ofnode_translate_address() after ofnode_read_resource > in luton_switch.c:luton_probe(); it is unnecessary since > the commit feb7ac457c20 ("dm: core: Add address translation in > fdt_get_resource"). > > Fixes: feb7ac457c20 ("dm: core: Add address translation in fdt_get_resource") > Reported-by: Horatiu Vultur > Signed-off-by: Patrick Delaunay > --- > > drivers/net/mscc_eswitch/luton_switch.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/mscc_eswitch/luton_switch.c b/drivers/net/mscc_eswitch/luton_switch.c > index 54afa14c9d..73c950d118 100644 > --- a/drivers/net/mscc_eswitch/luton_switch.c > +++ b/drivers/net/mscc_eswitch/luton_switch.c > @@ -588,7 +588,6 @@ static int luton_probe(struct udevice *dev) > struct luton_private *priv = dev_get_priv(dev); > int i, ret; > struct resource res; > - fdt32_t faddr; > phys_addr_t addr_base; > unsigned long addr_size; > ofnode eth_node, node, mdio_node; > @@ -658,9 +657,7 @@ static int luton_probe(struct udevice *dev) > > if (ofnode_read_resource(mdio_node, 0, &res)) > return -ENOMEM; > - faddr = cpu_to_fdt32(res.start); > - > - addr_base = ofnode_translate_address(mdio_node, &faddr); > + addr_base = res.start; > addr_size = res.end - res.start; > > /* If the bus is new then create a new bus */ > -- > 2.17.1 > Reviewed-by: Ramon Fried