From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0257DC433F5 for ; Tue, 14 Sep 2021 09:24:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6621160FC1 for ; Tue, 14 Sep 2021 09:24:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6621160FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 31DF183377; Tue, 14 Sep 2021 11:24:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Q5plBaaD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B8FF832E9; Tue, 14 Sep 2021 11:24:13 +0200 (CEST) Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A9EE38326D for ; Tue, 14 Sep 2021 11:24:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x333.google.com with SMTP id o16-20020a9d2210000000b0051b1e56c98fso17496783ota.8 for ; Tue, 14 Sep 2021 02:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dhB5Rw/Pasfn4cPGapxnbH+XAHJQif3xYrKTlf8PYL0=; b=Q5plBaaDUCkWBRu1zvznyE3TKPxUyZRVJaW/PL/5I9QgATwq+TDBJn5BKQRTbNe/FU pDbLb88lDsrddFuL8D7bLHaQu6BSqWVQmJaPOBqrIFNeY2Al7sEbtA9a2fRNJoTZHHKR IHdfNyo4rDCSU5qAB5J8Em/xRnYrd+mudLBS7zLAc+rEAp/WDLM5SmzVqd85Kf5SY1R+ aaSV3uSt73pwAjoknLxuvfjrPr+VXNnu0fwfe0dAKQubgX8Idz0YogY8tm1OGfPojSG5 +8R/BnwcUkGkYXsZJ8F81dI17qq/YrRHi8cHyEuo2urfewMv1Pt2y+abMVJnsM8+Bx/K +nWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dhB5Rw/Pasfn4cPGapxnbH+XAHJQif3xYrKTlf8PYL0=; b=uMwfkCSjRjPP4pfZy9jWpKcSctEID0X+ntRoXYpgVf/3urMGfUhfSOqfqtDqrwC09P /bHMJUegKvWVA6gjYNfjqpVQkCWYmuqoiuJqJjO8TTEOWcQ/00aOHeof/rI3ezpQEhdf 5KgFnM7+mfLgXZh/ItZwh1latQ/frL3Y9u62xwuV+6/lU1HMnZ2XSGXIkjFnc8uzItD6 HDGD4B3xHVRX7XvaudjwJe9GUmoRle/HTLRrWGgP6GuARsMBKnKKeTSs+HVmYBxVOXlL cGxrCt3HLdD2h5naImtxcc9lfoa7EzGFL1Ct0IRzWo23QnU9EJdMkTq5PKIyLVGkADnE zYvA== X-Gm-Message-State: AOAM532PJ8hem5HYITBUdnkEU8tctvizz62IbnBUd6f9QeDD71Ni/TsO hlTLRs64eWjn9j9Ey0X3fRrZAiFCO7m1pjBnEZw= X-Google-Smtp-Source: ABdhPJw0YvnqMIQWKRwDKpIHXae/+THy1P62+yXyDSXn4vC0ZkcuAM6nLeEsNbBYESb6Lm6CIMrYKObpFl7D7MpY5z4= X-Received: by 2002:a05:6830:1d69:: with SMTP id l9mr13773537oti.154.1631611444160; Tue, 14 Sep 2021 02:24:04 -0700 (PDT) MIME-Version: 1.0 References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> <20210824120043.3823931-3-vladimir.oltean@nxp.com> In-Reply-To: <20210824120043.3823931-3-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 14 Sep 2021 12:23:52 +0300 Message-ID: Subject: Re: [PATCH v2 2/6] net: dsa: use "err" instead of "ret" in dsa_port_probe To: Vladimir Oltean Cc: Joe Hershberger , U-Boot Mailing List , Claudiu Manoil , Michael Walle , Priyanka Jain Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > DM DSA uses "err" for error code values, so use this consistently. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > Tested-by: Michael Walle > --- > net/dsa-uclass.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > index 694664d81bbb..f279ca7d2d6c 100644 > --- a/net/dsa-uclass.c > +++ b/net/dsa-uclass.c > @@ -248,7 +248,7 @@ static int dsa_port_probe(struct udevice *pdev) > struct dsa_port_pdata *port_pdata; > struct dsa_priv *dsa_priv; > struct udevice *master; > - int ret; > + int err; > > port_pdata = dev_get_parent_plat(pdev); > dsa_priv = dev_get_uclass_priv(dev); > @@ -268,9 +268,9 @@ static int dsa_port_probe(struct udevice *pdev) > * TODO: we assume the master device is always there and doesn't get > * removed during runtime. > */ > - ret = device_probe(master); > - if (ret) > - return ret; > + err = device_probe(master); > + if (err) > + return err; > > /* > * Inherit port's hwaddr from the DSA master, unless the port already > -- > 2.25.1 > Applied to u-boot-net/network-master Thanks, Ramon.