From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759DEC48BE6 for ; Mon, 14 Jun 2021 05:59:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 892FB613C2 for ; Mon, 14 Jun 2021 05:59:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 892FB613C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B22E580412; Mon, 14 Jun 2021 07:59:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CrxjcwT5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D4B3F80C67; Mon, 14 Jun 2021 07:59:17 +0200 (CEST) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D1BC7800B2 for ; Mon, 14 Jun 2021 07:59:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x32c.google.com with SMTP id 5-20020a9d01050000b02903c700c45721so9750811otu.6 for ; Sun, 13 Jun 2021 22:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qd9lTIQZzcRUeUM1duumOmivfhsXeRuI6il62UATYmY=; b=CrxjcwT5t10oYcORYFlMTo6W73uIWa35MwNIDN5kmvGZzAB1/s5xyzrDZf7kwrsHoD 1mE44gTA63kLNgcnC7INMnzGH9h+NG05wMkDbtRjjUW1DbEYS85R5E6KNbQIxZZNOIcI o4MHV+vieLyvzhXZN5HjF7MhfK0qYubrDdT+8EzxiVIG6sGFTpbkIev6ksaX23cDtvwQ V3SVeVydGQ0Oq0tGWgVuQzDvlEdRZ2OwSxUKPJfwFXWd9Q4OKO7bbvkbfMbhLz0jMNo6 B0H11RllNz/Q3AjG9jUul0QwjyhxnhXmfffGwB10NzxvMPh3c6Y6gxwR30W6RvnU2p1D WVqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qd9lTIQZzcRUeUM1duumOmivfhsXeRuI6il62UATYmY=; b=W4ROgErDxyX84mOcZufpSU+qtYGOkr+kH9VaBC/d3BS47XurT6rTX0iOVhQT1aTNyH Gr7PSiF2J7PkE4Ih1xlPuvYEp1Qq9BVfv21zed0ZPesVWwaKL0j81EFVnGkMWBTif/W/ LBT2Qp5KZfyzTDwdnDNcwo5JSC7+I8Kpqx1CNVmj61XAthLc5eC5Bvhue+klS4NOITO8 MIYr5Jd/1JnEl59PLTmwvrGCTzkTekX6PzOt452h0qNxlMUj1y0MKfK5morX/mZkMXl3 b8czs3iqo/gPiUrzwEF9120i4pU89DB6GIfE9wR/OEUINGcp9yll8rz12UQ1VWWw2Row upeA== X-Gm-Message-State: AOAM5302+D90yLVh73bwGjcSrQxUhD4yJQUZWsoY821F6O5LbnHjGFRc xnltAb9XGxdJTGAg9uBuzl4TYQr1FLE2fQxzxDI= X-Google-Smtp-Source: ABdhPJzmBabhYyLL6kg2J2Y31mLUdR9OeGJ7etGmpj5lNrpXE+GqLaeVOVYs3WIDJJnLvpwPkIsRDeiEkWjjYwb1yvs= X-Received: by 2002:a9d:4b02:: with SMTP id q2mr12407473otf.370.1623650353441; Sun, 13 Jun 2021 22:59:13 -0700 (PDT) MIME-Version: 1.0 References: <20210614042745.282502-1-sunxiaoyang2003@gmail.com> In-Reply-To: <20210614042745.282502-1-sunxiaoyang2003@gmail.com> From: Ramon Fried Date: Mon, 14 Jun 2021 08:59:01 +0300 Message-ID: Subject: Re: [PATCH] arm: snapdragon: Use correct GICC register on APQ8016 To: Sheep Sun Cc: U-Boot Mailing List , Mateusz Kulikowski , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Jun 14, 2021 at 7:27 AM Sheep Sun wrote: > > The GICC register used by u-boot is 0x0a20c000, which is actually a GICC > for WCNSS, the WLAN processor. U-boot runs on the Application Processor, > therefore it should use APCS GICC instead. Hence, correct it with APCS GICC > register address. > > Signed-off-by: Sheep Sun > --- > > arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h > index 520e2e6bd7..d9a3b1af98 100644 > --- a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h > +++ b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h > @@ -8,7 +8,7 @@ > #define _MACH_SYSMAP_APQ8016_H > > #define GICD_BASE (0x0b000000) > -#define GICC_BASE (0x0a20c000) > +#define GICC_BASE (0x0b002000) > > /* Clocks: (from CLK_CTL_BASE) */ > #define GPLL0_STATUS (0x2101C) > -- > 2.30.2 > Reviewed-by: Ramon Fried