From: Ramon Fried <rfried.dev@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 09/12] net: ti: am65-cpsw-nuss: Don't cache disabled port ID
Date: Sat, 15 May 2021 22:50:42 +0300 [thread overview]
Message-ID: <CAGi-RULpTu376JDamnmrUzd4v4751D8tr8FqgV9Q-XGbtJYH5Q@mail.gmail.com> (raw)
In-Reply-To: <20210510143613.16512-10-vigneshr@ti.com>
On Mon, May 10, 2021 at 5:37 PM Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> Currently driver may end up caching disabled port ID as active
> interface. Fix this by bailing out earlier in case port is marked
> disabled in the DT.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/net/ti/am65-cpsw-nuss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c
> index 9f11ce63b9..3534a6d807 100644
> --- a/drivers/net/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ti/am65-cpsw-nuss.c
> @@ -719,11 +719,11 @@ static int am65_cpsw_probe_cpsw(struct udevice *dev)
> if (!port_id)
> continue;
>
> - priv->port_id = port_id;
> cpsw_common->ports[port_id].disabled = disabled;
> if (disabled)
> continue;
>
> + priv->port_id = port_id;
> ret = am65_cpsw_ofdata_parse_phy(dev, node);
> if (ret)
> goto out;
> --
> 2.31.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
next prev parent reply other threads:[~2021-05-15 19:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 14:36 [PATCH 00/12] AM64x: DMA and ethernet support Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 01/12] firmware: ti_sci: Update ti_sci_cmd_rm_udmap_tx_ch_cfg() API to the latest Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 02/12] soc: ti: k3-navss-ringacc: Add AM64 ringacc support Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 03/12] soc: ti: k3-navss-ringacc: Remove unused ring modes Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 04/12] dma: ti: k3-psil-am654: Drop unused PSIL EP static data Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 05/12] dma: ti: k3-psil: Extend PSIL EP data extension for AM64 Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 06/12] dma: ti: k3-psil-am64: Add AM64 PSIL endpoint data Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 07/12] dma: ti: k3-udma: Add BCDMA and PKTDMA support Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 08/12] net: ti: am65-cpsw-nuss: Prepare to support non primary ext port Vignesh Raghavendra
2021-05-15 19:50 ` Ramon Fried
2021-05-10 14:36 ` [PATCH 09/12] net: ti: am65-cpsw-nuss: Don't cache disabled port ID Vignesh Raghavendra
2021-05-15 19:50 ` Ramon Fried [this message]
2021-05-10 14:36 ` [PATCH 10/12] net: ti: am65-cpsw-nuss: Add a new compatible for AM64 Vignesh Raghavendra
2021-05-15 19:50 ` Ramon Fried
2021-05-10 14:36 ` [PATCH 11/12] ARM: dts: k3-am64-main: Add CPSW DT nodes Vignesh Raghavendra
2021-05-10 14:36 ` [PATCH 12/12] ARM: dts: k3-am642-sk: Add ethernet related " Vignesh Raghavendra
2021-05-12 14:00 ` [PATCH 00/12] AM64x: DMA and ethernet support Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGi-RULpTu376JDamnmrUzd4v4751D8tr8FqgV9Q-XGbtJYH5Q@mail.gmail.com \
--to=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.