From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E98C433FE for ; Sat, 28 May 2022 13:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354190AbiE1NBT (ORCPT ); Sat, 28 May 2022 09:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344012AbiE1NBT (ORCPT ); Sat, 28 May 2022 09:01:19 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32F0FC2A; Sat, 28 May 2022 06:01:18 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id p13so524555ybm.1; Sat, 28 May 2022 06:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BKJMVmT6xouVZnKHH1t+32fnxpEdpNO/J4+waPk1SMk=; b=OSiwldFcTD5m1v28Gww4fcj+VFEDJoo9LZC550aWzmPrsNO+3qW8HfpbBnXqjc2Z7g iUa0nnqUgmX7kmYypSvvWacDReI3oP6s0Hw6sfBCI3XPT0zWqSGvcduLBF0K/aGBYQYM gGQ79Awih5OGjE8mybtmmiME5UdTgOWxSzp/xW21WwwRaK7KwgqK9x52mC0eagpBmxWO mkT8btHFMDRHPDRC1YBAGxKYjNYz2hykT2NnYil/KXBuDmUV2Zuy5XW77+sOBFU2qL2U omfNyCRIu6iQzyiiFm/tfXfy6R/fUa7KVWluSOlaYQlhWyht7J1q/+h3h0+o7po8X6JC BBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BKJMVmT6xouVZnKHH1t+32fnxpEdpNO/J4+waPk1SMk=; b=e8w0zzDWFoGiH7hHjn9SYOFxFQxpHIRYglyY33r617g2RUNRBXhzmyQ4UJ7TGH7kZV 8CphR9UO81dGccRhnIlAyo6pYEULeXw8mbZjTh6FEeFFcEuWFf/n1xe7XIjox5QRadTL RURvTi2TLs2vRtDCG2z5uhAhujSKzhGjRNNJV1QBXyb522lEXY2tHT+4UOnHwLpQLIRR p4ohEAxgsxGG14BpR54Op+dIxKSnc88Ij0WCNoGjQSTqqzv9RSnOaEhBi6+N+7i6coNN tFzbBYFdinwtioR7HmJGhsf7jPxXQK59kXD3rgD1PTfWobl6r2YMJ3yRYvSVYV8XMs65 v5tg== X-Gm-Message-State: AOAM530gGCHS++IbMu3q6Ys+HgPi53PX6WRrsRG6lceDLB01rA+5wMgT 03yoOsITxYNafN0rjS1r4u0IdynXr6y/67cZZJw= X-Google-Smtp-Source: ABdhPJzXfiv11UhbK8CnwaYDCRHtEgZ8HuWMSXZRgaP0eVRvLfbXS0aYW8xbo6em4yB3lJyMJlTtX9qVH11oqJXS6/U= X-Received: by 2002:a25:af02:0:b0:64f:72b8:ce50 with SMTP id a2-20020a25af02000000b0064f72b8ce50mr34013107ybh.528.1653742876917; Sat, 28 May 2022 06:01:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yegor Yefremov Date: Sat, 28 May 2022 15:01:05 +0200 Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Ard Biesheuvel Cc: Arnd Bergmann , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Sat, May 28, 2022 at 11:07 AM Ard Biesheuvel wrote: > > On Sat, 28 May 2022 at 10:29, Yegor Yefremov = wrote: > > > > On Sat, May 28, 2022 at 9:53 AM Arnd Bergmann wrote: > > > > > > On Sat, May 28, 2022 at 7:48 AM Yegor Yefremov > > > wrote: > > > > > > > > On Fri, May 27, 2022 at 4:13 PM Arnd Bergmann wrote= : > > > > > > > > > > On Fri, May 27, 2022 at 3:12 PM Ard Biesheuvel = wrote: > > > > > > On Fri, 27 May 2022 at 14:54, Arnd Bergmann wro= te: > > > > > > > On Fri, May 27, 2022 at 11:50 AM Yegor Yefremov wrote: > > > > > > > > > > > > Not just per-cpu data: there is also the 'current' global varia= ble > > > > > > which gets used now instead of the user thread ID register, and= this > > > > > > is also different between modules and the core kernel (unless > > > > > > CONFIG_ARM_MODULE_PLTS is disabled) > > > > > > > > > > Right, so if the percpu hack doesn't address it, this one might: > > > > > > > > > > diff --git a/arch/arm/include/asm/current.h b/arch/arm/include/as= m/current.h > > > > > index 1e1178bf176d..306d1a4cae40 100644 > > > > > --- a/arch/arm/include/asm/current.h > > > > > +++ b/arch/arm/include/asm/current.h > > > > > @@ -18,6 +18,8 @@ static __always_inline __attribute_const__ stru= ct > > > > > task_struct *get_current(void) > > > > > { > > > > > struct task_struct *cur; > > > > > > > > > > + return __current; > > > > > + > > > > > #if __has_builtin(__builtin_thread_pointer) && \ > > > > > defined(CONFIG_CURRENT_POINTER_IN_TPIDRURO) && \ > > > > > !(defined(CONFIG_THUMB2_KERNEL) && \ > > > > > > > > I have tried this patch and the system still stalls. > > > > > > Ok, thanks for testing. To clarify: did you test with both the get_cu= rrent() and > > > __my_cpu_offset() changes applied, or just the get_current() one? > > > > I have tested only the get_current() one. Should I also test > > __my_cpu_offset() separately and combined? > > > > That would be helpful, yes. SYNC include/config/auto.conf.cmd CC kernel/bounds.s CALL scripts/atomic/check-atomics.sh In file included from ./include/linux/irqflags.h:17, from ./arch/arm/include/asm/bitops.h:28, from ./include/linux/bitops.h:33, from ./include/linux/log2.h:12, from kernel/bounds.c:13: ./arch/arm/include/asm/percpu.h: In function =E2=80=98__my_cpu_offset=E2=80= =99: ./arch/arm/include/asm/percpu.h:32:9: error: =E2=80=98__per_cpu_offset=E2= =80=99 undeclared (first use in this function); did you mean =E2=80=98__my_cpu_offset=E2=80=99? 32 | return __per_cpu_offset[0]; | ^~~~~~~~~~~~~~~~ | __my_cpu_offset ./arch/arm/include/asm/percpu.h:32:9: note: each undeclared identifier is reported only once for each function it appears in Yegor From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA767C433EF for ; Sat, 28 May 2022 13:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kLGIFthYQAcs6zEa1NFJz51gFUw2aUEZfrY/J1TxQdo=; b=HoIMbhfoAbA78n MMtyUrYcjVDa92hLOiScN0sYy2R+C9fzCVJ/Qch/jyU+GHdZrjxmVnu+rAxa/X8l6ZnTjn9j/hK0M jgO9I36T46ks2YFy+zo53986NoZdxBeOIkmrw5uI6qzQkuU1BZpLuY6aNMtnCnDifui09ZcdGOc6c f9/gd/7JikJDRlwM7hX7vks1AyENpAyxdFnoGJwQ/TNsDk3ukcOZ4RpgQWOtMCQ893U8o+NUJCGcX 32xkzCOeVDS4PPizSzO3hUoFx+GAvE3KLQOqFvGbeG6sXCWy1wC3oShC976vvEjtUZ8TsNadSoQzp ykSBSaplS2+D4bRwffAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuw4J-002B85-PR; Sat, 28 May 2022 13:01:23 +0000 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuw4G-002B7E-6g for linux-arm-kernel@lists.infradead.org; Sat, 28 May 2022 13:01:21 +0000 Received: by mail-yb1-xb33.google.com with SMTP id l204so1369598ybf.10 for ; Sat, 28 May 2022 06:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BKJMVmT6xouVZnKHH1t+32fnxpEdpNO/J4+waPk1SMk=; b=OSiwldFcTD5m1v28Gww4fcj+VFEDJoo9LZC550aWzmPrsNO+3qW8HfpbBnXqjc2Z7g iUa0nnqUgmX7kmYypSvvWacDReI3oP6s0Hw6sfBCI3XPT0zWqSGvcduLBF0K/aGBYQYM gGQ79Awih5OGjE8mybtmmiME5UdTgOWxSzp/xW21WwwRaK7KwgqK9x52mC0eagpBmxWO mkT8btHFMDRHPDRC1YBAGxKYjNYz2hykT2NnYil/KXBuDmUV2Zuy5XW77+sOBFU2qL2U omfNyCRIu6iQzyiiFm/tfXfy6R/fUa7KVWluSOlaYQlhWyht7J1q/+h3h0+o7po8X6JC BBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BKJMVmT6xouVZnKHH1t+32fnxpEdpNO/J4+waPk1SMk=; b=PwP1dmflLPY5DioCgCjQ8uRBcNPKN4lARhGyWxtFBTB0YdPylnHnXvNbZ2bxGXAFhT n/2TphczJJZqooee0dbY8AMVQEpQ2nU4xMZSQ4rDy4WZ/nbywdkW88ooorFvopbSWMuO XW+CL2yE1B8qIwNBDY4aG8h5AuH+EVYCv6LEzjxWj8tf1UzZzNXGA/s8QJlqoMsVgeG3 LEmmp9uJvS/fkLWeJE1YaVnENNyJii0BArHFuqg4n/+utzbHTK/moCenbtaUx83ifsfT VyHw7YVGfe5LBX3nb5hDAyWIdTZs6kYoivHWFf4rIPZTH0NefGDIjFhrhSrbLoSlXHH0 cOkQ== X-Gm-Message-State: AOAM531/lQUvsKuoGnKGztAUlNmrFbrhiMnegmIlmwsABFPpaQQ7zNkS rPfPmOyi8EozFJy5nD0zsPguBeAP3qNbJ/LLyyM= X-Google-Smtp-Source: ABdhPJzXfiv11UhbK8CnwaYDCRHtEgZ8HuWMSXZRgaP0eVRvLfbXS0aYW8xbo6em4yB3lJyMJlTtX9qVH11oqJXS6/U= X-Received: by 2002:a25:af02:0:b0:64f:72b8:ce50 with SMTP id a2-20020a25af02000000b0064f72b8ce50mr34013107ybh.528.1653742876917; Sat, 28 May 2022 06:01:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yegor Yefremov Date: Sat, 28 May 2022 15:01:05 +0200 Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Ard Biesheuvel Cc: Arnd Bergmann , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220528_060120_307200_C62B3AEE X-CRM114-Status: GOOD ( 26.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBNYXkgMjgsIDIwMjIgYXQgMTE6MDcgQU0gQXJkIEJpZXNoZXV2ZWwgPGFyZGJAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4KPiBPbiBTYXQsIDI4IE1heSAyMDIyIGF0IDEwOjI5LCBZZWdvciBZ ZWZyZW1vdiA8eWVnb3JzbGlzdHNAZ29vZ2xlbWFpbC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFNh dCwgTWF5IDI4LCAyMDIyIGF0IDk6NTMgQU0gQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4g d3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFNhdCwgTWF5IDI4LCAyMDIyIGF0IDc6NDggQU0gWWVnb3Ig WWVmcmVtb3YKPiA+ID4gPHllZ29yc2xpc3RzQGdvb2dsZW1haWwuY29tPiB3cm90ZToKPiA+ID4g Pgo+ID4gPiA+IE9uIEZyaSwgTWF5IDI3LCAyMDIyIGF0IDQ6MTMgUE0gQXJuZCBCZXJnbWFubiA8 YXJuZEBhcm5kYi5kZT4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gT24gRnJpLCBNYXkgMjcs IDIwMjIgYXQgMzoxMiBQTSBBcmQgQmllc2hldXZlbCA8YXJkYkBrZXJuZWwub3JnPiB3cm90ZToK PiA+ID4gPiA+ID4gT24gRnJpLCAyNyBNYXkgMjAyMiBhdCAxNDo1NCwgQXJuZCBCZXJnbWFubiA8 YXJuZEBhcm5kYi5kZT4gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gT24gRnJpLCBNYXkgMjcsIDIwMjIg YXQgMTE6NTAgQU0gWWVnb3IgWWVmcmVtb3YgPHllZ29yc2xpc3RzQGdvb2dsZW1haWwuY29tPiB3 cm90ZToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gTm90IGp1c3QgcGVyLWNwdSBkYXRhOiB0aGVy ZSBpcyBhbHNvIHRoZSAnY3VycmVudCcgZ2xvYmFsIHZhcmlhYmxlCj4gPiA+ID4gPiA+IHdoaWNo IGdldHMgdXNlZCBub3cgaW5zdGVhZCBvZiB0aGUgdXNlciB0aHJlYWQgSUQgcmVnaXN0ZXIsIGFu ZCB0aGlzCj4gPiA+ID4gPiA+IGlzIGFsc28gZGlmZmVyZW50IGJldHdlZW4gbW9kdWxlcyBhbmQg dGhlIGNvcmUga2VybmVsICh1bmxlc3MKPiA+ID4gPiA+ID4gQ09ORklHX0FSTV9NT0RVTEVfUExU UyBpcyBkaXNhYmxlZCkKPiA+ID4gPiA+Cj4gPiA+ID4gPiBSaWdodCwgc28gaWYgdGhlIHBlcmNw dSBoYWNrIGRvZXNuJ3QgYWRkcmVzcyBpdCwgdGhpcyBvbmUgbWlnaHQ6Cj4gPiA+ID4gPgo+ID4g PiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2N1cnJlbnQuaCBiL2FyY2gv YXJtL2luY2x1ZGUvYXNtL2N1cnJlbnQuaAo+ID4gPiA+ID4gaW5kZXggMWUxMTc4YmYxNzZkLi4z MDZkMWE0Y2FlNDAgMTAwNjQ0Cj4gPiA+ID4gPiAtLS0gYS9hcmNoL2FybS9pbmNsdWRlL2FzbS9j dXJyZW50LmgKPiA+ID4gPiA+ICsrKyBiL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2N1cnJlbnQuaAo+ ID4gPiA+ID4gQEAgLTE4LDYgKzE4LDggQEAgc3RhdGljIF9fYWx3YXlzX2lubGluZSBfX2F0dHJp YnV0ZV9jb25zdF9fIHN0cnVjdAo+ID4gPiA+ID4gdGFza19zdHJ1Y3QgKmdldF9jdXJyZW50KHZv aWQpCj4gPiA+ID4gPiAgewo+ID4gPiA+ID4gICAgICAgICBzdHJ1Y3QgdGFza19zdHJ1Y3QgKmN1 cjsKPiA+ID4gPiA+Cj4gPiA+ID4gPiArICAgICAgIHJldHVybiBfX2N1cnJlbnQ7Cj4gPiA+ID4g PiArCj4gPiA+ID4gPiAgI2lmIF9faGFzX2J1aWx0aW4oX19idWlsdGluX3RocmVhZF9wb2ludGVy KSAmJiBcCj4gPiA+ID4gPiAgICAgIGRlZmluZWQoQ09ORklHX0NVUlJFTlRfUE9JTlRFUl9JTl9U UElEUlVSTykgJiYgXAo+ID4gPiA+ID4gICAgICAhKGRlZmluZWQoQ09ORklHX1RIVU1CMl9LRVJO RUwpICYmIFwKPiA+ID4gPgo+ID4gPiA+IEkgaGF2ZSB0cmllZCB0aGlzIHBhdGNoIGFuZCB0aGUg c3lzdGVtIHN0aWxsIHN0YWxscy4KPiA+ID4KPiA+ID4gT2ssIHRoYW5rcyBmb3IgdGVzdGluZy4g VG8gY2xhcmlmeTogZGlkIHlvdSB0ZXN0IHdpdGggYm90aCB0aGUgZ2V0X2N1cnJlbnQoKSBhbmQK PiA+ID4gX19teV9jcHVfb2Zmc2V0KCkgY2hhbmdlcyBhcHBsaWVkLCBvciBqdXN0IHRoZSBnZXRf Y3VycmVudCgpIG9uZT8KPiA+Cj4gPiBJIGhhdmUgdGVzdGVkIG9ubHkgdGhlIGdldF9jdXJyZW50 KCkgb25lLiBTaG91bGQgSSBhbHNvIHRlc3QKPiA+IF9fbXlfY3B1X29mZnNldCgpIHNlcGFyYXRl bHkgYW5kIGNvbWJpbmVkPwo+ID4KPgo+IFRoYXQgd291bGQgYmUgaGVscGZ1bCwgeWVzLgoKICBT WU5DICAgIGluY2x1ZGUvY29uZmlnL2F1dG8uY29uZi5jbWQKICBDQyAgICAgIGtlcm5lbC9ib3Vu ZHMucwogIENBTEwgICAgc2NyaXB0cy9hdG9taWMvY2hlY2stYXRvbWljcy5zaApJbiBmaWxlIGlu Y2x1ZGVkIGZyb20gLi9pbmNsdWRlL2xpbnV4L2lycWZsYWdzLmg6MTcsCiAgICAgICAgICAgICAg ICAgZnJvbSAuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2JpdG9wcy5oOjI4LAogICAgICAgICAgICAg ICAgIGZyb20gLi9pbmNsdWRlL2xpbnV4L2JpdG9wcy5oOjMzLAogICAgICAgICAgICAgICAgIGZy b20gLi9pbmNsdWRlL2xpbnV4L2xvZzIuaDoxMiwKICAgICAgICAgICAgICAgICBmcm9tIGtlcm5l bC9ib3VuZHMuYzoxMzoKLi9hcmNoL2FybS9pbmNsdWRlL2FzbS9wZXJjcHUuaDogSW4gZnVuY3Rp b24g4oCYX19teV9jcHVfb2Zmc2V04oCZOgouL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BlcmNwdS5o OjMyOjk6IGVycm9yOiDigJhfX3Blcl9jcHVfb2Zmc2V04oCZCnVuZGVjbGFyZWQgKGZpcnN0IHVz ZSBpbiB0aGlzIGZ1bmN0aW9uKTsgZGlkIHlvdSBtZWFuCuKAmF9fbXlfY3B1X29mZnNldOKAmT8K ICAgMzIgfCAgcmV0dXJuIF9fcGVyX2NwdV9vZmZzZXRbMF07CiAgICAgIHwgICAgICAgICBefn5+ fn5+fn5+fn5+fn5+CiAgICAgIHwgICAgICAgICBfX215X2NwdV9vZmZzZXQKLi9hcmNoL2FybS9p bmNsdWRlL2FzbS9wZXJjcHUuaDozMjo5OiBub3RlOiBlYWNoIHVuZGVjbGFyZWQgaWRlbnRpZmll cgppcyByZXBvcnRlZCBvbmx5IG9uY2UgZm9yIGVhY2ggZnVuY3Rpb24gaXQgYXBwZWFycyBpbgoK WWVnb3IKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK