From: Yegor Yefremov <yegorslists@googlemail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: am335x: 5.18.x: system stalling
Date: Wed, 1 Jun 2022 09:36:11 +0200 [thread overview]
Message-ID: <CAGm1_kswMZkoV9_DnB71ugVTF_rh5SV2NazkHROwXiFqhxTWYA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1nhBnbbocBNkKUKYhw14OYE0WPEyQcJJXzbpW4uASu_Q@mail.gmail.com>
On Tue, May 31, 2022 at 5:23 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, May 31, 2022 at 4:16 PM Yegor Yefremov
> <yegorslists@googlemail.com> wrote:
> > On Tue, May 31, 2022 at 10:36 AM Yegor Yefremov <yegorslists@googlemail.com> wrote:
> > # bad: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART 1] ARM:
> > implement THREAD_INFO_IN_TASK for uniprocessor systems
> > git bisect bad b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103
> > # good: [dccfc18999cf4b4e518f01d5c7c578426166e5f2] ARM: v7m: enable
> > support for IRQ stacks
> > git bisect good dccfc18999cf4b4e518f01d5c7c578426166e5f2
> > # first bad commit: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART
> > 1] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems
> >
> > Though commit b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103 led to a broken
> > kernel that didn't even show any output after the bootloader had
> > started it.
> >
> > Commit 2d3456213319c0277ee6082946c43c3afacca9b4 showed the expected stalling.
>
> Ok, good, so we know that the "ARM: implement THREAD_INFO_IN_TASK for
> uniprocessor system" commit caused the problem then. This is what we had
> already assumed, but now it's confirmed.
>
> Too bad I screwed up that "this_cpu_offset" macro, I think it should
> have been
>
> @@ -286,7 +286,7 @@ THUMB( fpreg .req r7 )
> * register 'rd'
> */
> .macro this_cpu_offset, rd:req
> - mov \rd, #0
> + ldr_va \rd, __per_cpu_offset
> .endm
>
> /*
>
> I've pushed a modified branch now, with that fix on the broken commit,
> and another change to make CONFIG_IRQSTACKS user-selectable rather
> than always enabled. That should tell us if the problem is in the SMP
> patching or in the irqstacks.
>
> Can you test the top of this branch with CONFIG_IRQSTACKS disabled,
> and (if that still stalls) retest the fixed commit f0191ea5c2e5 ("[PART 1]
> ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems")?
1. the top of this branch with CONFIG_IRQSTACKS disabled stalls
2. f0191ea5c2e5 with the same config - not
Yegor
WARNING: multiple messages have this Message-ID (diff)
From: Yegor Yefremov <yegorslists@googlemail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: am335x: 5.18.x: system stalling
Date: Wed, 1 Jun 2022 09:36:11 +0200 [thread overview]
Message-ID: <CAGm1_kswMZkoV9_DnB71ugVTF_rh5SV2NazkHROwXiFqhxTWYA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1nhBnbbocBNkKUKYhw14OYE0WPEyQcJJXzbpW4uASu_Q@mail.gmail.com>
On Tue, May 31, 2022 at 5:23 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, May 31, 2022 at 4:16 PM Yegor Yefremov
> <yegorslists@googlemail.com> wrote:
> > On Tue, May 31, 2022 at 10:36 AM Yegor Yefremov <yegorslists@googlemail.com> wrote:
> > # bad: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART 1] ARM:
> > implement THREAD_INFO_IN_TASK for uniprocessor systems
> > git bisect bad b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103
> > # good: [dccfc18999cf4b4e518f01d5c7c578426166e5f2] ARM: v7m: enable
> > support for IRQ stacks
> > git bisect good dccfc18999cf4b4e518f01d5c7c578426166e5f2
> > # first bad commit: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART
> > 1] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems
> >
> > Though commit b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103 led to a broken
> > kernel that didn't even show any output after the bootloader had
> > started it.
> >
> > Commit 2d3456213319c0277ee6082946c43c3afacca9b4 showed the expected stalling.
>
> Ok, good, so we know that the "ARM: implement THREAD_INFO_IN_TASK for
> uniprocessor system" commit caused the problem then. This is what we had
> already assumed, but now it's confirmed.
>
> Too bad I screwed up that "this_cpu_offset" macro, I think it should
> have been
>
> @@ -286,7 +286,7 @@ THUMB( fpreg .req r7 )
> * register 'rd'
> */
> .macro this_cpu_offset, rd:req
> - mov \rd, #0
> + ldr_va \rd, __per_cpu_offset
> .endm
>
> /*
>
> I've pushed a modified branch now, with that fix on the broken commit,
> and another change to make CONFIG_IRQSTACKS user-selectable rather
> than always enabled. That should tell us if the problem is in the SMP
> patching or in the irqstacks.
>
> Can you test the top of this branch with CONFIG_IRQSTACKS disabled,
> and (if that still stalls) retest the fixed commit f0191ea5c2e5 ("[PART 1]
> ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems")?
1. the top of this branch with CONFIG_IRQSTACKS disabled stalls
2. f0191ea5c2e5 with the same config - not
Yegor
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-01 7:36 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 10:35 am335x: 5.18.x: system stalling Yegor Yefremov
2022-05-05 5:08 ` Tony Lindgren
2022-05-11 14:16 ` Yegor Yefremov
2022-05-12 5:41 ` Tony Lindgren
2022-05-12 5:41 ` Tony Lindgren
2022-05-12 8:14 ` Arnd Bergmann
2022-05-12 8:14 ` Arnd Bergmann
2022-05-12 8:42 ` Arnd Bergmann
2022-05-12 8:42 ` Arnd Bergmann
2022-05-12 10:20 ` Yegor Yefremov
2022-05-12 10:20 ` Yegor Yefremov
2022-05-19 16:52 ` Yegor Yefremov
2022-05-19 16:52 ` Yegor Yefremov
2022-05-21 19:41 ` Arnd Bergmann
2022-05-21 19:41 ` Arnd Bergmann
2022-05-24 13:38 ` Yegor Yefremov
2022-05-24 13:38 ` Yegor Yefremov
2022-05-24 14:19 ` Tony Lindgren
2022-05-24 14:19 ` Tony Lindgren
2022-05-26 5:49 ` Yegor Yefremov
2022-05-26 5:49 ` Yegor Yefremov
2022-05-26 6:20 ` Tony Lindgren
2022-05-26 6:20 ` Tony Lindgren
2022-05-26 8:19 ` Ard Biesheuvel
2022-05-26 8:19 ` Ard Biesheuvel
2022-05-26 12:37 ` Yegor Yefremov
2022-05-26 12:37 ` Yegor Yefremov
2022-05-26 14:15 ` Arnd Bergmann
2022-05-26 14:15 ` Arnd Bergmann
2022-05-27 4:44 ` Yegor Yefremov
2022-05-27 4:44 ` Yegor Yefremov
2022-05-27 6:38 ` Arnd Bergmann
2022-05-27 6:38 ` Arnd Bergmann
2022-05-27 6:50 ` Tony Lindgren
2022-05-27 6:50 ` Tony Lindgren
2022-05-27 6:57 ` Arnd Bergmann
2022-05-27 6:57 ` Arnd Bergmann
2022-05-27 8:17 ` Yegor Yefremov
2022-05-27 8:17 ` Yegor Yefremov
2022-05-27 8:38 ` Arnd Bergmann
2022-05-27 8:38 ` Arnd Bergmann
2022-05-27 9:50 ` Yegor Yefremov
2022-05-27 9:50 ` Yegor Yefremov
2022-05-27 12:53 ` Arnd Bergmann
2022-05-27 12:53 ` Arnd Bergmann
2022-05-27 13:12 ` Ard Biesheuvel
2022-05-27 13:12 ` Ard Biesheuvel
2022-05-27 14:12 ` Arnd Bergmann
2022-05-27 14:12 ` Arnd Bergmann
2022-05-28 5:48 ` Yegor Yefremov
2022-05-28 5:48 ` Yegor Yefremov
2022-05-28 7:53 ` Arnd Bergmann
2022-05-28 7:53 ` Arnd Bergmann
2022-05-28 8:29 ` Yegor Yefremov
2022-05-28 8:29 ` Yegor Yefremov
2022-05-28 9:07 ` Ard Biesheuvel
2022-05-28 9:07 ` Ard Biesheuvel
2022-05-28 13:01 ` Yegor Yefremov
2022-05-28 13:01 ` Yegor Yefremov
2022-05-28 13:13 ` Arnd Bergmann
2022-05-28 13:13 ` Arnd Bergmann
2022-05-28 19:28 ` Yegor Yefremov
2022-05-28 19:28 ` Yegor Yefremov
2022-05-30 10:16 ` Ard Biesheuvel
2022-05-30 10:16 ` Ard Biesheuvel
2022-05-30 12:09 ` Yegor Yefremov
2022-05-30 12:09 ` Yegor Yefremov
2022-05-30 13:54 ` Arnd Bergmann
2022-05-30 13:54 ` Arnd Bergmann
2022-05-30 15:14 ` Ard Biesheuvel
2022-05-30 15:14 ` Ard Biesheuvel
2022-05-31 8:36 ` Yegor Yefremov
2022-05-31 8:36 ` Yegor Yefremov
2022-05-31 14:16 ` Yegor Yefremov
2022-05-31 14:16 ` Yegor Yefremov
2022-05-31 15:22 ` Arnd Bergmann
2022-05-31 15:22 ` Arnd Bergmann
2022-06-01 7:36 ` Yegor Yefremov [this message]
2022-06-01 7:36 ` Yegor Yefremov
2022-06-01 7:59 ` Arnd Bergmann
2022-06-01 7:59 ` Arnd Bergmann
2022-06-01 8:08 ` Ard Biesheuvel
2022-06-01 8:08 ` Ard Biesheuvel
2022-06-01 9:27 ` Ard Biesheuvel
2022-06-01 9:27 ` Ard Biesheuvel
2022-06-01 10:03 ` Yegor Yefremov
2022-06-01 10:03 ` Yegor Yefremov
2022-06-01 10:06 ` Ard Biesheuvel
2022-06-01 10:06 ` Ard Biesheuvel
2022-06-01 10:46 ` Yegor Yefremov
2022-06-01 10:46 ` Yegor Yefremov
2022-06-01 10:49 ` Ard Biesheuvel
2022-06-01 10:49 ` Ard Biesheuvel
2022-06-02 10:17 ` Yegor Yefremov
2022-06-02 10:17 ` Yegor Yefremov
2022-06-02 10:37 ` Ard Biesheuvel
2022-06-02 10:37 ` Ard Biesheuvel
2022-06-02 12:27 ` Yegor Yefremov
2022-06-02 12:27 ` Yegor Yefremov
2022-06-03 8:54 ` Yegor Yefremov
2022-06-03 8:54 ` Yegor Yefremov
2022-06-03 9:32 ` Arnd Bergmann
2022-06-03 9:32 ` Arnd Bergmann
2022-06-03 19:11 ` Yegor Yefremov
2022-06-03 19:11 ` Yegor Yefremov
2022-06-03 20:46 ` Arnd Bergmann
2022-06-03 20:46 ` Arnd Bergmann
2022-06-05 14:59 ` Ard Biesheuvel
2022-06-05 14:59 ` Ard Biesheuvel
2022-06-07 8:55 ` Yegor Yefremov
2022-06-07 8:55 ` Yegor Yefremov
2022-08-12 7:35 ` Arnd Bergmann
2022-08-12 7:35 ` Arnd Bergmann
2022-05-24 14:36 ` Arnd Bergmann
2022-05-24 14:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGm1_kswMZkoV9_DnB71ugVTF_rh5SV2NazkHROwXiFqhxTWYA@mail.gmail.com \
--to=yegorslists@googlemail.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.