From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21686C433FE for ; Wed, 1 Jun 2022 07:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345682AbiFAHg2 (ORCPT ); Wed, 1 Jun 2022 03:36:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345599AbiFAHgZ (ORCPT ); Wed, 1 Jun 2022 03:36:25 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 867BB8BD2E; Wed, 1 Jun 2022 00:36:23 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-306b5b452b1so9307017b3.1; Wed, 01 Jun 2022 00:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7CCQa39SGQ9dVfo6kYlr8Pz8EWwXxGFs+Ui1e66PB8U=; b=brofxjrOJHt1PACyZ46xvD4vWJ8JJyiRQP+f62CYBQFOgISBkGBEnugmpZ0hDPNkby vv+TeqtwR2FDFnjidTGtjvGW5fr/g/gUijbmZiRZtOQA8q+ybM91bYUwEZmuMleAPaqT BKkH8ZUxs91xT+5C3QCOVyOrH5WP6+MRsxwMUDUScJybF3mlrjLVPU0VVHgMWU/h6l1X WaXB/7NSrkhd3KA4cKwX6AotiTFIb3/Dy9O59MD8DNkOh4jCE+F5GytJ5ec0x7zI93mr t8x9NNoSOgoKF8hHCoCucAMlUODvvNACGQLgKN6HFzFgfT+g8aodYvOF6Ysg/b96nhLs jp5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7CCQa39SGQ9dVfo6kYlr8Pz8EWwXxGFs+Ui1e66PB8U=; b=r7b+nyHJOOZeHDeMkqTBy1e380KfzCITUuCFs6MurjFEwOQPrD4N0lSh03cf8n7eTy tMiBz4cWukWcmaEvs/iZxChIzLINYA7TO1wp+nIlIK2NSzCGezAwZ2Vy0ZCRN6B7m/BR WNF+G9QgUCFPEPODFHJ13y5f5xKhpe8YY0RM/xgXYo3FfbdDsU1nxm25eqKedaDZ2NSP xH07YHx5+UR4YS3/fOR0whDJD9PB2axPD+3vlkNUB5izka1YRbkbwNkB+aykkH3yudqQ vYd4F8BkpSFMMOdwBPHVeMyVRHRgWS0LZ1fzqqV74mUxjqgV39oTyRZjr/RPfZr5hxOQ FbDA== X-Gm-Message-State: AOAM533Vx6mlkbFMNEwKizO/nRPQfbzTw/CCrVMcdO1DlBmqCK+G85SE GJCEjFID35botGWsqNmYLCTUFoEGnjA80tcf3q8FlofwjfU= X-Google-Smtp-Source: ABdhPJy1YMedQNa6c5TKF2oWOm2qRGAFR7bQLRhS8gDTqJgtMv5B9JnCe2XnJW/ELrrnHsx1QcVgh8tEuvG2q2RQKsM= X-Received: by 2002:a05:690c:102:b0:2ef:48d8:24c3 with SMTP id bd2-20020a05690c010200b002ef48d824c3mr69734516ywb.153.1654068982718; Wed, 01 Jun 2022 00:36:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yegor Yefremov Date: Wed, 1 Jun 2022 09:36:11 +0200 Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Arnd Bergmann Cc: Ard Biesheuvel , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, May 31, 2022 at 5:23 PM Arnd Bergmann wrote: > > On Tue, May 31, 2022 at 4:16 PM Yegor Yefremov > wrote: > > On Tue, May 31, 2022 at 10:36 AM Yegor Yefremov wrote: > > # bad: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART 1] ARM: > > implement THREAD_INFO_IN_TASK for uniprocessor systems > > git bisect bad b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103 > > # good: [dccfc18999cf4b4e518f01d5c7c578426166e5f2] ARM: v7m: enable > > support for IRQ stacks > > git bisect good dccfc18999cf4b4e518f01d5c7c578426166e5f2 > > # first bad commit: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART > > 1] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems > > > > Though commit b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103 led to a broken > > kernel that didn't even show any output after the bootloader had > > started it. > > > > Commit 2d3456213319c0277ee6082946c43c3afacca9b4 showed the expected stalling. > > Ok, good, so we know that the "ARM: implement THREAD_INFO_IN_TASK for > uniprocessor system" commit caused the problem then. This is what we had > already assumed, but now it's confirmed. > > Too bad I screwed up that "this_cpu_offset" macro, I think it should > have been > > @@ -286,7 +286,7 @@ THUMB( fpreg .req r7 ) > * register 'rd' > */ > .macro this_cpu_offset, rd:req > - mov \rd, #0 > + ldr_va \rd, __per_cpu_offset > .endm > > /* > > I've pushed a modified branch now, with that fix on the broken commit, > and another change to make CONFIG_IRQSTACKS user-selectable rather > than always enabled. That should tell us if the problem is in the SMP > patching or in the irqstacks. > > Can you test the top of this branch with CONFIG_IRQSTACKS disabled, > and (if that still stalls) retest the fixed commit f0191ea5c2e5 ("[PART 1] > ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems")? 1. the top of this branch with CONFIG_IRQSTACKS disabled stalls 2. f0191ea5c2e5 with the same config - not Yegor From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF0ECC433F5 for ; Wed, 1 Jun 2022 07:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3YdKW7w/aMSEyIJb4VpYabKdIwzzN4Xxj2s/FGtaAI4=; b=nx994/VrzgfKRV Oe2Md1BMlwMIORFa9G5LEu+5zB58yVikGIxGDl+dPJxrV9/v2NYb4+rrx5bR73B2PHNdinLcw0g9n qUd8pREwIO2nTIrw7UPDJaAkomY31wh2qiZaYhB9+skaCzVDtEi58RvMbZnc07gLSPrBOJfHX0d/D vD1hHMc3E0qzU/9aVfbCqcFViOmzl8VW/ooRmM3UDPiY6irAVaLqimLjeimT5oMWpVmc7w+zqN1+H MwHxsx13KrydEkv6KSC4ujLC838Jp8tz7Q0Xc/HPSZVusa0EcbSt3z1nJalSrwuLuSeqyW4Y3LY/S Ks18+0YMIyqtuSzoSKtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwIuC-00EONN-JV; Wed, 01 Jun 2022 07:36:36 +0000 Received: from mail-yw1-x112a.google.com ([2607:f8b0:4864:20::112a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwIu0-00EOEq-Gh for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 07:36:26 +0000 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-2ff90e0937aso9206857b3.4 for ; Wed, 01 Jun 2022 00:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7CCQa39SGQ9dVfo6kYlr8Pz8EWwXxGFs+Ui1e66PB8U=; b=brofxjrOJHt1PACyZ46xvD4vWJ8JJyiRQP+f62CYBQFOgISBkGBEnugmpZ0hDPNkby vv+TeqtwR2FDFnjidTGtjvGW5fr/g/gUijbmZiRZtOQA8q+ybM91bYUwEZmuMleAPaqT BKkH8ZUxs91xT+5C3QCOVyOrH5WP6+MRsxwMUDUScJybF3mlrjLVPU0VVHgMWU/h6l1X WaXB/7NSrkhd3KA4cKwX6AotiTFIb3/Dy9O59MD8DNkOh4jCE+F5GytJ5ec0x7zI93mr t8x9NNoSOgoKF8hHCoCucAMlUODvvNACGQLgKN6HFzFgfT+g8aodYvOF6Ysg/b96nhLs jp5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7CCQa39SGQ9dVfo6kYlr8Pz8EWwXxGFs+Ui1e66PB8U=; b=xXy/LemEPeMiTuAwFo/9fospZYibF2yRbtfyb2eCovNmtCscdU8tiSPdiklXlXjcFk o3FQEUC/uA6P8HMT58EGHmiKclpVhJKRJPikdMJrhwfZdHPNSipxyE5+Pk1skkD2y+ci DhKA8EdvLjynI68I35PzBhSlz1gochSIycevvns9ToU5N8+IGn6NEhqSorZPtm1FbDgT M1puwVZCFs7Qx4vQz8/rK9lNh2EcwjAX2HrA0rd5Ssay6h9xWBK/xSf4jnUsPZtsbwDl l3FtQ6UqdStN4OabyJk58/DGwip0kjWJl2r7DMmVzOVMg2N0YiPoi1U4Wj/1Q2MBuNF1 5oWg== X-Gm-Message-State: AOAM533N5hoNXhcORww6f1zU5GPiwfY290wOMXVB/PMx8mHOsDamla+6 eeF8LJloCDsCKR38H+zQ3Hbm4KxthmW1ysKCOWw= X-Google-Smtp-Source: ABdhPJy1YMedQNa6c5TKF2oWOm2qRGAFR7bQLRhS8gDTqJgtMv5B9JnCe2XnJW/ELrrnHsx1QcVgh8tEuvG2q2RQKsM= X-Received: by 2002:a05:690c:102:b0:2ef:48d8:24c3 with SMTP id bd2-20020a05690c010200b002ef48d824c3mr69734516ywb.153.1654068982718; Wed, 01 Jun 2022 00:36:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yegor Yefremov Date: Wed, 1 Jun 2022 09:36:11 +0200 Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Arnd Bergmann Cc: Ard Biesheuvel , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_003624_609674_3AE8AD75 X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 31, 2022 at 5:23 PM Arnd Bergmann wrote: > > On Tue, May 31, 2022 at 4:16 PM Yegor Yefremov > wrote: > > On Tue, May 31, 2022 at 10:36 AM Yegor Yefremov wrote: > > # bad: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART 1] ARM: > > implement THREAD_INFO_IN_TASK for uniprocessor systems > > git bisect bad b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103 > > # good: [dccfc18999cf4b4e518f01d5c7c578426166e5f2] ARM: v7m: enable > > support for IRQ stacks > > git bisect good dccfc18999cf4b4e518f01d5c7c578426166e5f2 > > # first bad commit: [b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103] [PART > > 1] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems > > > > Though commit b6b3b4814e77d2f5a7517297e9ac1d1aa1cda103 led to a broken > > kernel that didn't even show any output after the bootloader had > > started it. > > > > Commit 2d3456213319c0277ee6082946c43c3afacca9b4 showed the expected stalling. > > Ok, good, so we know that the "ARM: implement THREAD_INFO_IN_TASK for > uniprocessor system" commit caused the problem then. This is what we had > already assumed, but now it's confirmed. > > Too bad I screwed up that "this_cpu_offset" macro, I think it should > have been > > @@ -286,7 +286,7 @@ THUMB( fpreg .req r7 ) > * register 'rd' > */ > .macro this_cpu_offset, rd:req > - mov \rd, #0 > + ldr_va \rd, __per_cpu_offset > .endm > > /* > > I've pushed a modified branch now, with that fix on the broken commit, > and another change to make CONFIG_IRQSTACKS user-selectable rather > than always enabled. That should tell us if the problem is in the SMP > patching or in the irqstacks. > > Can you test the top of this branch with CONFIG_IRQSTACKS disabled, > and (if that still stalls) retest the fixed commit f0191ea5c2e5 ("[PART 1] > ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems")? 1. the top of this branch with CONFIG_IRQSTACKS disabled stalls 2. f0191ea5c2e5 with the same config - not Yegor _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel