All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
@ 2021-07-12  9:18 Aleksander Morgado
  2021-07-16 20:54 ` Thomas Petazzoni
  0 siblings, 1 reply; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-12  9:18 UTC (permalink / raw)
  To: buildroot

https://lists.freedesktop.org/archives/libmbim-devel/2021-June/001151.html

Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
 package/libmbim/libmbim.hash | 2 +-
 package/libmbim/libmbim.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libmbim/libmbim.hash b/package/libmbim/libmbim.hash
index b6a82e367d..2779be1e96 100644
--- a/package/libmbim/libmbim.hash
+++ b/package/libmbim/libmbim.hash
@@ -1,4 +1,4 @@
 # Locally computed
-sha256  760465caaa1ccd699c14290e9791da456d5300dd11ebf4c1486151033e875dfd  libmbim-1.24.6.tar.xz
+sha256  02590736163fff10e5732191fccc1b9920969616ddc59613a003052a116a3c25  libmbim-1.24.8.tar.xz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
diff --git a/package/libmbim/libmbim.mk b/package/libmbim/libmbim.mk
index 175111381f..e21194ca20 100644
--- a/package/libmbim/libmbim.mk
+++ b/package/libmbim/libmbim.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBMBIM_VERSION = 1.24.6
+LIBMBIM_VERSION = 1.24.8
 LIBMBIM_SITE = https://www.freedesktop.org/software/libmbim
 LIBMBIM_SOURCE = libmbim-$(LIBMBIM_VERSION).tar.xz
 LIBMBIM_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs)
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-12  9:18 [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8 Aleksander Morgado
@ 2021-07-16 20:54 ` Thomas Petazzoni
  2021-07-20  6:15   ` Yegor Yefremov
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Petazzoni @ 2021-07-16 20:54 UTC (permalink / raw)
  To: buildroot

On Mon, 12 Jul 2021 11:18:27 +0200
Aleksander Morgado <aleksander@aleksander.es> wrote:

> https://lists.freedesktop.org/archives/libmbim-devel/2021-June/001151.html
> 
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
>  package/libmbim/libmbim.hash | 2 +-
>  package/libmbim/libmbim.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-16 20:54 ` Thomas Petazzoni
@ 2021-07-20  6:15   ` Yegor Yefremov
  2021-07-20  8:45     ` Aleksander Morgado
  0 siblings, 1 reply; 18+ messages in thread
From: Yegor Yefremov @ 2021-07-20  6:15 UTC (permalink / raw)
  To: buildroot

Hi Aleksander, All,

On Fri, Jul 16, 2021 at 10:54 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Mon, 12 Jul 2021 11:18:27 +0200
> Aleksander Morgado <aleksander@aleksander.es> wrote:
>
> > https://lists.freedesktop.org/archives/libmbim-devel/2021-June/001151.html
> >
> > Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > ---
> >  package/libmbim/libmbim.hash | 2 +-
> >  package/libmbim/libmbim.mk   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
>
> Applied to master, thanks.

I still experience this error [1]. Any ideas?

I have also applied libgudev patches as their build was failing.

[1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log

Best regards,
Yegor

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-20  6:15   ` Yegor Yefremov
@ 2021-07-20  8:45     ` Aleksander Morgado
  2021-07-20  8:56       ` Yegor Yefremov
  0 siblings, 1 reply; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-20  8:45 UTC (permalink / raw)
  To: buildroot

>
> I still experience this error [1]. Any ideas?
>
> I have also applied libgudev patches as their build was failing.
>
> [1]
> http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
>
>
My eyes are failing, I'm not sure which is the issue that triggers the
build error. Is it the -Winline issues? The build should go on in that
case, as we don't have -Werror. Not really sure.


-- 
Aleksander
https://aleksander.es
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210720/840662aa/attachment-0001.html>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-20  8:45     ` Aleksander Morgado
@ 2021-07-20  8:56       ` Yegor Yefremov
  2021-07-20  9:07         ` Aleksander Morgado
  0 siblings, 1 reply; 18+ messages in thread
From: Yegor Yefremov @ 2021-07-20  8:56 UTC (permalink / raw)
  To: buildroot

Hi Aleksander,

On Tue, Jul 20, 2021 at 10:45 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
>
>>
>> I still experience this error [1]. Any ideas?
>>
>> I have also applied libgudev patches as their build was failing.
>>
>> [1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
>>
>
> My eyes are failing, I'm not sure which is the issue that triggers the build error. Is it the -Winline issues? The build should go on in that case, as we don't have -Werror. Not really sure.

If I rerun "make", it ends as follows:

/usr/bin/make  all-recursive
Making all in .
Making all in build-aux
Making all in templates
make[5]: Nothing to be done for 'all'.
Making all in mbim-codegen
make[5]: Nothing to be done for 'all'.
Making all in .
make[5]: Nothing to be done for 'all-am'.
Making all in data
Making all in .
make[5]: Nothing to be done for 'all-am'.
Making all in pkg-config
make[5]: Nothing to be done for 'all'.
Making all in src
Making all in common
Making all in .
make[6]: Nothing to be done for 'all-am'.
Making all in test
make[6]: Nothing to be done for 'all'.
Making all in libmbim-glib
Making all in generated
/usr/bin/make  all-am
make[7]: Nothing to be done for 'all-am'.
Making all in .
make[6]: *** No rule to make target 'Mbim-1.0.typelib', needed by
'all-am'.  Stop.
Makefile:802: recipe for target 'all-recursive' failed
make[5]: *** [all-recursive] Error 1
Makefile:399: recipe for target 'all-recursive' failed
make[4]: *** [all-recursive] Error 1
Makefile:456: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
Makefile:388: recipe for target 'all' failed
make[2]: *** [all] Error 2

The problem seems to be: No rule to make target 'Mbim-1.0.typelib',
needed by 'all-am'.

Best regards,
Yegor

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-20  8:56       ` Yegor Yefremov
@ 2021-07-20  9:07         ` Aleksander Morgado
  2021-07-20  9:15           ` Yegor Yefremov
  0 siblings, 1 reply; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-20  9:07 UTC (permalink / raw)
  To: buildroot

> >> I still experience this error [1]. Any ideas?
> >>
> >> I have also applied libgudev patches as their build was failing.
> >>
> >> [1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
> >>
> >
> > My eyes are failing, I'm not sure which is the issue that triggers the build error. Is it the -Winline issues? The build should go on in that case, as we don't have -Werror. Not really sure.
>
> If I rerun "make", it ends as follows:
>
> /usr/bin/make  all-recursive
> Making all in .
> Making all in build-aux
> Making all in templates
> make[5]: Nothing to be done for 'all'.
> Making all in mbim-codegen
> make[5]: Nothing to be done for 'all'.
> Making all in .
> make[5]: Nothing to be done for 'all-am'.
> Making all in data
> Making all in .
> make[5]: Nothing to be done for 'all-am'.
> Making all in pkg-config
> make[5]: Nothing to be done for 'all'.
> Making all in src
> Making all in common
> Making all in .
> make[6]: Nothing to be done for 'all-am'.
> Making all in test
> make[6]: Nothing to be done for 'all'.
> Making all in libmbim-glib
> Making all in generated
> /usr/bin/make  all-am
> make[7]: Nothing to be done for 'all-am'.
> Making all in .
> make[6]: *** No rule to make target 'Mbim-1.0.typelib', needed by
> 'all-am'.  Stop.
> Makefile:802: recipe for target 'all-recursive' failed
> make[5]: *** [all-recursive] Error 1
> Makefile:399: recipe for target 'all-recursive' failed
> make[4]: *** [all-recursive] Error 1
> Makefile:456: recipe for target 'all-recursive' failed
> make[3]: *** [all-recursive] Error 1
> Makefile:388: recipe for target 'all' failed
> make[2]: *** [all] Error 2
>
> The problem seems to be: No rule to make target 'Mbim-1.0.typelib',
> needed by 'all-am'.
>

That looks like a problem in the gobject-introspection setup in that
build. The configure check detects the introspection support:
....
checking for gobject-introspection... yes
....
But then it fails to create the typelib.

Is there any way to manually play with that build?

-- 
Aleksander
https://aleksander.es

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-20  9:07         ` Aleksander Morgado
@ 2021-07-20  9:15           ` Yegor Yefremov
  2021-07-20  9:21             ` Aleksander Morgado
  0 siblings, 1 reply; 18+ messages in thread
From: Yegor Yefremov @ 2021-07-20  9:15 UTC (permalink / raw)
  To: buildroot

On Tue, Jul 20, 2021 at 11:07 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> > >> I still experience this error [1]. Any ideas?
> > >>
> > >> I have also applied libgudev patches as their build was failing.
> > >>
> > >> [1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
> > >>
> > >
> > > My eyes are failing, I'm not sure which is the issue that triggers the build error. Is it the -Winline issues? The build should go on in that case, as we don't have -Werror. Not really sure.
> >
> > If I rerun "make", it ends as follows:
> >
> > /usr/bin/make  all-recursive
> > Making all in .
> > Making all in build-aux
> > Making all in templates
> > make[5]: Nothing to be done for 'all'.
> > Making all in mbim-codegen
> > make[5]: Nothing to be done for 'all'.
> > Making all in .
> > make[5]: Nothing to be done for 'all-am'.
> > Making all in data
> > Making all in .
> > make[5]: Nothing to be done for 'all-am'.
> > Making all in pkg-config
> > make[5]: Nothing to be done for 'all'.
> > Making all in src
> > Making all in common
> > Making all in .
> > make[6]: Nothing to be done for 'all-am'.
> > Making all in test
> > make[6]: Nothing to be done for 'all'.
> > Making all in libmbim-glib
> > Making all in generated
> > /usr/bin/make  all-am
> > make[7]: Nothing to be done for 'all-am'.
> > Making all in .
> > make[6]: *** No rule to make target 'Mbim-1.0.typelib', needed by
> > 'all-am'.  Stop.
> > Makefile:802: recipe for target 'all-recursive' failed
> > make[5]: *** [all-recursive] Error 1
> > Makefile:399: recipe for target 'all-recursive' failed
> > make[4]: *** [all-recursive] Error 1
> > Makefile:456: recipe for target 'all-recursive' failed
> > make[3]: *** [all-recursive] Error 1
> > Makefile:388: recipe for target 'all' failed
> > make[2]: *** [all] Error 2
> >
> > The problem seems to be: No rule to make target 'Mbim-1.0.typelib',
> > needed by 'all-am'.
> >
>
> That looks like a problem in the gobject-introspection setup in that
> build. The configure check detects the introspection support:
> ....
> checking for gobject-introspection... yes
> ....
> But then it fails to create the typelib.
>
> Is there any way to manually play with that build?

I can try to create a minimal config that reproduces this issue.

Or what tests would you want me to do with my ARM build?

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-20  9:15           ` Yegor Yefremov
@ 2021-07-20  9:21             ` Aleksander Morgado
  2021-07-20 10:39               ` Yegor Yefremov
  0 siblings, 1 reply; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-20  9:21 UTC (permalink / raw)
  To: buildroot

On Tue, Jul 20, 2021 at 11:15 AM Yegor Yefremov
<yegorslists@googlemail.com> wrote:
>
> On Tue, Jul 20, 2021 at 11:07 AM Aleksander Morgado
> <aleksander@aleksander.es> wrote:
> >
> > > >> I still experience this error [1]. Any ideas?
> > > >>
> > > >> I have also applied libgudev patches as their build was failing.
> > > >>
> > > >> [1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
> > > >>
> > > >
> > > > My eyes are failing, I'm not sure which is the issue that triggers the build error. Is it the -Winline issues? The build should go on in that case, as we don't have -Werror. Not really sure.
> > >
> > > If I rerun "make", it ends as follows:
> > >
> > > /usr/bin/make  all-recursive
> > > Making all in .
> > > Making all in build-aux
> > > Making all in templates
> > > make[5]: Nothing to be done for 'all'.
> > > Making all in mbim-codegen
> > > make[5]: Nothing to be done for 'all'.
> > > Making all in .
> > > make[5]: Nothing to be done for 'all-am'.
> > > Making all in data
> > > Making all in .
> > > make[5]: Nothing to be done for 'all-am'.
> > > Making all in pkg-config
> > > make[5]: Nothing to be done for 'all'.
> > > Making all in src
> > > Making all in common
> > > Making all in .
> > > make[6]: Nothing to be done for 'all-am'.
> > > Making all in test
> > > make[6]: Nothing to be done for 'all'.
> > > Making all in libmbim-glib
> > > Making all in generated
> > > /usr/bin/make  all-am
> > > make[7]: Nothing to be done for 'all-am'.
> > > Making all in .
> > > make[6]: *** No rule to make target 'Mbim-1.0.typelib', needed by
> > > 'all-am'.  Stop.
> > > Makefile:802: recipe for target 'all-recursive' failed
> > > make[5]: *** [all-recursive] Error 1
> > > Makefile:399: recipe for target 'all-recursive' failed
> > > make[4]: *** [all-recursive] Error 1
> > > Makefile:456: recipe for target 'all-recursive' failed
> > > make[3]: *** [all-recursive] Error 1
> > > Makefile:388: recipe for target 'all' failed
> > > make[2]: *** [all] Error 2
> > >
> > > The problem seems to be: No rule to make target 'Mbim-1.0.typelib',
> > > needed by 'all-am'.
> > >
> >
> > That looks like a problem in the gobject-introspection setup in that
> > build. The configure check detects the introspection support:
> > ....
> > checking for gobject-introspection... yes
> > ....
> > But then it fails to create the typelib.
> >
> > Is there any way to manually play with that build?
>
> I can try to create a minimal config that reproduces this issue.
>
> Or what tests would you want me to do with my ARM build?

We should inspect the generated Makefile, and see whether it contains
the gobject introspection bits or not. The Makefile.am in libmbim-glib
defines the .gir and .typelib targets, but then we include
$(INTROSPECTION_MAKEFILE). In my local PC build, I can see the
following in the generated Makefile:
INTROSPECTION_MAKEFILE =
/usr/share/gobject-introspection-1.0/Makefile.introspection

What does the Makefile say in this build, and if there's a path given,
does it contain the correct path to the Makefile.introspection file?

-- 
Aleksander
https://aleksander.es

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-20  9:21             ` Aleksander Morgado
@ 2021-07-20 10:39               ` Yegor Yefremov
  2021-07-20 23:35                   ` Yegor Yefremov via buildroot
  0 siblings, 1 reply; 18+ messages in thread
From: Yegor Yefremov @ 2021-07-20 10:39 UTC (permalink / raw)
  To: buildroot

On Tue, Jul 20, 2021 at 11:22 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> On Tue, Jul 20, 2021 at 11:15 AM Yegor Yefremov
> <yegorslists@googlemail.com> wrote:
> >
> > On Tue, Jul 20, 2021 at 11:07 AM Aleksander Morgado
> > <aleksander@aleksander.es> wrote:
> > >
> > > > >> I still experience this error [1]. Any ideas?
> > > > >>
> > > > >> I have also applied libgudev patches as their build was failing.
> > > > >>
> > > > >> [1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
> > > > >>
> > > > >
> > > > > My eyes are failing, I'm not sure which is the issue that triggers the build error. Is it the -Winline issues? The build should go on in that case, as we don't have -Werror. Not really sure.
> > > >
> > > > If I rerun "make", it ends as follows:
> > > >
> > > > /usr/bin/make  all-recursive
> > > > Making all in .
> > > > Making all in build-aux
> > > > Making all in templates
> > > > make[5]: Nothing to be done for 'all'.
> > > > Making all in mbim-codegen
> > > > make[5]: Nothing to be done for 'all'.
> > > > Making all in .
> > > > make[5]: Nothing to be done for 'all-am'.
> > > > Making all in data
> > > > Making all in .
> > > > make[5]: Nothing to be done for 'all-am'.
> > > > Making all in pkg-config
> > > > make[5]: Nothing to be done for 'all'.
> > > > Making all in src
> > > > Making all in common
> > > > Making all in .
> > > > make[6]: Nothing to be done for 'all-am'.
> > > > Making all in test
> > > > make[6]: Nothing to be done for 'all'.
> > > > Making all in libmbim-glib
> > > > Making all in generated
> > > > /usr/bin/make  all-am
> > > > make[7]: Nothing to be done for 'all-am'.
> > > > Making all in .
> > > > make[6]: *** No rule to make target 'Mbim-1.0.typelib', needed by
> > > > 'all-am'.  Stop.
> > > > Makefile:802: recipe for target 'all-recursive' failed
> > > > make[5]: *** [all-recursive] Error 1
> > > > Makefile:399: recipe for target 'all-recursive' failed
> > > > make[4]: *** [all-recursive] Error 1
> > > > Makefile:456: recipe for target 'all-recursive' failed
> > > > make[3]: *** [all-recursive] Error 1
> > > > Makefile:388: recipe for target 'all' failed
> > > > make[2]: *** [all] Error 2
> > > >
> > > > The problem seems to be: No rule to make target 'Mbim-1.0.typelib',
> > > > needed by 'all-am'.
> > > >
> > >
> > > That looks like a problem in the gobject-introspection setup in that
> > > build. The configure check detects the introspection support:
> > > ....
> > > checking for gobject-introspection... yes
> > > ....
> > > But then it fails to create the typelib.
> > >
> > > Is there any way to manually play with that build?
> >
> > I can try to create a minimal config that reproduces this issue.
> >
> > Or what tests would you want me to do with my ARM build?
>
> We should inspect the generated Makefile, and see whether it contains
> the gobject introspection bits or not. The Makefile.am in libmbim-glib
> defines the .gir and .typelib targets, but then we include
> $(INTROSPECTION_MAKEFILE). In my local PC build, I can see the
> following in the generated Makefile:
> INTROSPECTION_MAKEFILE =
> /usr/share/gobject-introspection-1.0/Makefile.introspection
>
> What does the Makefile say in this build, and if there's a path given,
> does it contain the correct path to the Makefile.introspection file?

INTROSPECTION_MAKEFILE =
/usr/share/gobject-introspection-1.0/Makefile.introspection

hm.. it doesn't show the BR's location but the location of my host.
This doesn't look right.

INTROSPECTION_LIBS shows BR location, but INTROSPECTION_GIRDIR = /share/gir-1.0

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
@ 2021-07-20 23:35                   ` Yegor Yefremov via buildroot
  0 siblings, 0 replies; 18+ messages in thread
From: Yegor Yefremov @ 2021-07-20 23:35 UTC (permalink / raw)
  To: buildroot

On Tue, Jul 20, 2021 at 12:39 PM Yegor Yefremov
<yegorslists@googlemail.com> wrote:
>
> On Tue, Jul 20, 2021 at 11:22 AM Aleksander Morgado
> <aleksander@aleksander.es> wrote:
> >
> > On Tue, Jul 20, 2021 at 11:15 AM Yegor Yefremov
> > <yegorslists@googlemail.com> wrote:
> > >
> > > On Tue, Jul 20, 2021 at 11:07 AM Aleksander Morgado
> > > <aleksander@aleksander.es> wrote:
> > > >
> > > > > >> I still experience this error [1]. Any ideas?
> > > > > >>
> > > > > >> I have also applied libgudev patches as their build was failing.
> > > > > >>
> > > > > >> [1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
> > > > > >>
> > > > > >
> > > > > > My eyes are failing, I'm not sure which is the issue that triggers the build error. Is it the -Winline issues? The build should go on in that case, as we don't have -Werror. Not really sure.
> > > > >
> > > > > If I rerun "make", it ends as follows:
> > > > >
> > > > > /usr/bin/make  all-recursive
> > > > > Making all in .
> > > > > Making all in build-aux
> > > > > Making all in templates
> > > > > make[5]: Nothing to be done for 'all'.
> > > > > Making all in mbim-codegen
> > > > > make[5]: Nothing to be done for 'all'.
> > > > > Making all in .
> > > > > make[5]: Nothing to be done for 'all-am'.
> > > > > Making all in data
> > > > > Making all in .
> > > > > make[5]: Nothing to be done for 'all-am'.
> > > > > Making all in pkg-config
> > > > > make[5]: Nothing to be done for 'all'.
> > > > > Making all in src
> > > > > Making all in common
> > > > > Making all in .
> > > > > make[6]: Nothing to be done for 'all-am'.
> > > > > Making all in test
> > > > > make[6]: Nothing to be done for 'all'.
> > > > > Making all in libmbim-glib
> > > > > Making all in generated
> > > > > /usr/bin/make  all-am
> > > > > make[7]: Nothing to be done for 'all-am'.
> > > > > Making all in .
> > > > > make[6]: *** No rule to make target 'Mbim-1.0.typelib', needed by
> > > > > 'all-am'.  Stop.
> > > > > Makefile:802: recipe for target 'all-recursive' failed
> > > > > make[5]: *** [all-recursive] Error 1
> > > > > Makefile:399: recipe for target 'all-recursive' failed
> > > > > make[4]: *** [all-recursive] Error 1
> > > > > Makefile:456: recipe for target 'all-recursive' failed
> > > > > make[3]: *** [all-recursive] Error 1
> > > > > Makefile:388: recipe for target 'all' failed
> > > > > make[2]: *** [all] Error 2
> > > > >
> > > > > The problem seems to be: No rule to make target 'Mbim-1.0.typelib',
> > > > > needed by 'all-am'.
> > > > >
> > > >
> > > > That looks like a problem in the gobject-introspection setup in that
> > > > build. The configure check detects the introspection support:
> > > > ....
> > > > checking for gobject-introspection... yes
> > > > ....
> > > > But then it fails to create the typelib.
> > > >
> > > > Is there any way to manually play with that build?
> > >
> > > I can try to create a minimal config that reproduces this issue.
> > >
> > > Or what tests would you want me to do with my ARM build?
> >
> > We should inspect the generated Makefile, and see whether it contains
> > the gobject introspection bits or not. The Makefile.am in libmbim-glib
> > defines the .gir and .typelib targets, but then we include
> > $(INTROSPECTION_MAKEFILE). In my local PC build, I can see the
> > following in the generated Makefile:
> > INTROSPECTION_MAKEFILE =
> > /usr/share/gobject-introspection-1.0/Makefile.introspection
> >
> > What does the Makefile say in this build, and if there's a path given,
> > does it contain the correct path to the Makefile.introspection file?
>
> INTROSPECTION_MAKEFILE =
> /usr/share/gobject-introspection-1.0/Makefile.introspection
>
> hm.. it doesn't show the BR's location but the location of my host.
> This doesn't look right.
>
> INTROSPECTION_LIBS shows BR location, but INTROSPECTION_GIRDIR = /share/gir-1.0

INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
path inside my BR, everything is working (the same issue is with
Qmi-1.0.typelib).

My Linux host doesn't have
/usr/share/gobject-introspection-1.0/Makefile.introspection. Can it be
that your host does and that's why you don't experience this issue?

Regards,
Yegor

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
@ 2021-07-20 23:35                   ` Yegor Yefremov via buildroot
  0 siblings, 0 replies; 18+ messages in thread
From: Yegor Yefremov via buildroot @ 2021-07-20 23:35 UTC (permalink / raw)
  To: Aleksander Morgado; +Cc: Thomas Petazzoni, buildroot

On Tue, Jul 20, 2021 at 12:39 PM Yegor Yefremov
<yegorslists@googlemail.com> wrote:
>
> On Tue, Jul 20, 2021 at 11:22 AM Aleksander Morgado
> <aleksander@aleksander.es> wrote:
> >
> > On Tue, Jul 20, 2021 at 11:15 AM Yegor Yefremov
> > <yegorslists@googlemail.com> wrote:
> > >
> > > On Tue, Jul 20, 2021 at 11:07 AM Aleksander Morgado
> > > <aleksander@aleksander.es> wrote:
> > > >
> > > > > >> I still experience this error [1]. Any ideas?
> > > > > >>
> > > > > >> I have also applied libgudev patches as their build was failing.
> > > > > >>
> > > > > >> [1] http://autobuild.buildroot.net/results/f8a81aad0e262a567a2b31712575472ae92e5518/build-end.log
> > > > > >>
> > > > > >
> > > > > > My eyes are failing, I'm not sure which is the issue that triggers the build error. Is it the -Winline issues? The build should go on in that case, as we don't have -Werror. Not really sure.
> > > > >
> > > > > If I rerun "make", it ends as follows:
> > > > >
> > > > > /usr/bin/make  all-recursive
> > > > > Making all in .
> > > > > Making all in build-aux
> > > > > Making all in templates
> > > > > make[5]: Nothing to be done for 'all'.
> > > > > Making all in mbim-codegen
> > > > > make[5]: Nothing to be done for 'all'.
> > > > > Making all in .
> > > > > make[5]: Nothing to be done for 'all-am'.
> > > > > Making all in data
> > > > > Making all in .
> > > > > make[5]: Nothing to be done for 'all-am'.
> > > > > Making all in pkg-config
> > > > > make[5]: Nothing to be done for 'all'.
> > > > > Making all in src
> > > > > Making all in common
> > > > > Making all in .
> > > > > make[6]: Nothing to be done for 'all-am'.
> > > > > Making all in test
> > > > > make[6]: Nothing to be done for 'all'.
> > > > > Making all in libmbim-glib
> > > > > Making all in generated
> > > > > /usr/bin/make  all-am
> > > > > make[7]: Nothing to be done for 'all-am'.
> > > > > Making all in .
> > > > > make[6]: *** No rule to make target 'Mbim-1.0.typelib', needed by
> > > > > 'all-am'.  Stop.
> > > > > Makefile:802: recipe for target 'all-recursive' failed
> > > > > make[5]: *** [all-recursive] Error 1
> > > > > Makefile:399: recipe for target 'all-recursive' failed
> > > > > make[4]: *** [all-recursive] Error 1
> > > > > Makefile:456: recipe for target 'all-recursive' failed
> > > > > make[3]: *** [all-recursive] Error 1
> > > > > Makefile:388: recipe for target 'all' failed
> > > > > make[2]: *** [all] Error 2
> > > > >
> > > > > The problem seems to be: No rule to make target 'Mbim-1.0.typelib',
> > > > > needed by 'all-am'.
> > > > >
> > > >
> > > > That looks like a problem in the gobject-introspection setup in that
> > > > build. The configure check detects the introspection support:
> > > > ....
> > > > checking for gobject-introspection... yes
> > > > ....
> > > > But then it fails to create the typelib.
> > > >
> > > > Is there any way to manually play with that build?
> > >
> > > I can try to create a minimal config that reproduces this issue.
> > >
> > > Or what tests would you want me to do with my ARM build?
> >
> > We should inspect the generated Makefile, and see whether it contains
> > the gobject introspection bits or not. The Makefile.am in libmbim-glib
> > defines the .gir and .typelib targets, but then we include
> > $(INTROSPECTION_MAKEFILE). In my local PC build, I can see the
> > following in the generated Makefile:
> > INTROSPECTION_MAKEFILE =
> > /usr/share/gobject-introspection-1.0/Makefile.introspection
> >
> > What does the Makefile say in this build, and if there's a path given,
> > does it contain the correct path to the Makefile.introspection file?
>
> INTROSPECTION_MAKEFILE =
> /usr/share/gobject-introspection-1.0/Makefile.introspection
>
> hm.. it doesn't show the BR's location but the location of my host.
> This doesn't look right.
>
> INTROSPECTION_LIBS shows BR location, but INTROSPECTION_GIRDIR = /share/gir-1.0

INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
path inside my BR, everything is working (the same issue is with
Qmi-1.0.typelib).

My Linux host doesn't have
/usr/share/gobject-introspection-1.0/Makefile.introspection. Can it be
that your host does and that's why you don't experience this issue?

Regards,
Yegor
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-20 23:35                   ` Yegor Yefremov via buildroot
  (?)
@ 2021-07-21  7:20                   ` Aleksander Morgado
  2021-07-21  7:38                     ` Yegor Yefremov via buildroot
  -1 siblings, 1 reply; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-21  7:20 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: Thomas Petazzoni, buildroot

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hey,

> INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> path inside my BR, everything is working (the same issue is with
> Qmi-1.0.typelib).
>

The introspection.m4 included in the sources is a bit outdated, the
attached patch syncs it with the newest one I have installed in my
system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
in the patch, so these may be enough. Any chance you can give this
patch a try? You may need to force autoreconf as we're patching a m4
file-


-- 
Aleksander
https://aleksander.es

[-- Attachment #2: 0001-build-fix-introspection-setup-in-cross-builds.patch --]
[-- Type: text/x-patch, Size: 4181 bytes --]

From d051210c3b35962393f0fc9d934435b20743bebd Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander@aleksander.es>
Date: Wed, 21 Jul 2021 09:17:53 +0200
Subject: [PATCH] build: fix introspection setup in cross builds

---
 m4/introspection.m4 | 59 +++++++++++++++++++++++++++++++++++++++------
 1 file changed, 52 insertions(+), 7 deletions(-)

diff --git a/m4/introspection.m4 b/m4/introspection.m4
index 61f0cc3..b0ccd68 100644
--- a/m4/introspection.m4
+++ b/m4/introspection.m4
@@ -8,6 +8,47 @@ dnl
 
 # serial 1
 
+dnl This is a copy of AS_AC_EXPAND
+dnl
+dnl (C) 2003, 2004, 2005 Thomas Vander Stichele <thomas at apestaart dot org>
+dnl Copying and distribution of this file, with or without modification,
+dnl are permitted in any medium without royalty provided the copyright
+dnl notice and this notice are preserved.
+m4_define([_GOBJECT_INTROSPECTION_AS_AC_EXPAND],
+[
+  EXP_VAR=[$1]
+  FROM_VAR=[$2]
+
+  dnl first expand prefix and exec_prefix if necessary
+  prefix_save=$prefix
+  exec_prefix_save=$exec_prefix
+
+  dnl if no prefix given, then use /usr/local, the default prefix
+  if test "x$prefix" = "xNONE"; then
+    prefix="$ac_default_prefix"
+  fi
+  dnl if no exec_prefix given, then use prefix
+  if test "x$exec_prefix" = "xNONE"; then
+    exec_prefix=$prefix
+  fi
+
+  full_var="$FROM_VAR"
+  dnl loop until it doesn't change anymore
+  while true; do
+    new_full_var="`eval echo $full_var`"
+    if test "x$new_full_var" = "x$full_var"; then break; fi
+    full_var=$new_full_var
+  done
+
+  dnl clean up
+  full_var=$new_full_var
+  AC_SUBST([$1], "$full_var")
+
+  dnl restore prefix and exec_prefix
+  prefix=$prefix_save
+  exec_prefix=$exec_prefix_save
+])
+
 m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL],
 [
     AC_BEFORE([AC_PROG_LIBTOOL],[$0])dnl setup libtool first
@@ -50,20 +91,25 @@ m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL],
 
     AC_MSG_RESULT([$found_introspection])
 
+    dnl expand datadir/libdir so we can pass them to pkg-config
+    dnl and get paths relative to our target directories
+    _GOBJECT_INTROSPECTION_AS_AC_EXPAND(_GI_EXP_DATADIR, "$datadir")
+    _GOBJECT_INTROSPECTION_AS_AC_EXPAND(_GI_EXP_LIBDIR, "$libdir")
+
     INTROSPECTION_SCANNER=
     INTROSPECTION_COMPILER=
     INTROSPECTION_GENERATE=
     INTROSPECTION_GIRDIR=
     INTROSPECTION_TYPELIBDIR=
     if test "x$found_introspection" = "xyes"; then
-       INTROSPECTION_SCANNER=`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0`
-       INTROSPECTION_COMPILER=`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0`
-       INTROSPECTION_GENERATE=`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0`
-       INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir gobject-introspection-1.0`
-       INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)"
+       INTROSPECTION_SCANNER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0`
+       INTROSPECTION_COMPILER=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0`
+       INTROSPECTION_GENERATE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0`
+       INTROSPECTION_GIRDIR=`$PKG_CONFIG --define-variable=datadir="${_GI_EXP_DATADIR}" --variable=girdir gobject-introspection-1.0`
+       INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --define-variable=libdir="${_GI_EXP_LIBDIR}" --variable=typelibdir gobject-introspection-1.0)"
        INTROSPECTION_CFLAGS=`$PKG_CONFIG --cflags gobject-introspection-1.0`
        INTROSPECTION_LIBS=`$PKG_CONFIG --libs gobject-introspection-1.0`
-       INTROSPECTION_MAKEFILE=`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
+       INTROSPECTION_MAKEFILE=$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection
     fi
     AC_SUBST(INTROSPECTION_SCANNER)
     AC_SUBST(INTROSPECTION_COMPILER)
@@ -94,4 +140,3 @@ AC_DEFUN([GOBJECT_INTROSPECTION_REQUIRE],
 [
   _GOBJECT_INTROSPECTION_CHECK_INTERNAL([$1], [require])
 ])
-
-- 
2.32.0


[-- Attachment #3: Type: text/plain, Size: 145 bytes --]

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-21  7:20                   ` Aleksander Morgado
@ 2021-07-21  7:38                     ` Yegor Yefremov via buildroot
  2021-07-21  8:07                       ` Aleksander Morgado
  0 siblings, 1 reply; 18+ messages in thread
From: Yegor Yefremov via buildroot @ 2021-07-21  7:38 UTC (permalink / raw)
  To: Aleksander Morgado; +Cc: Thomas Petazzoni, buildroot

Hi,

On Wed, Jul 21, 2021 at 9:21 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> Hey,
>
> > INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> > path inside my BR, everything is working (the same issue is with
> > Qmi-1.0.typelib).
> >
>
> The introspection.m4 included in the sources is a bit outdated, the
> attached patch syncs it with the newest one I have installed in my
> system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
> in the patch, so these may be enough. Any chance you can give this
> patch a try? You may need to force autoreconf as we're patching a m4
> file-

>>> libmbim 1.24.8 Patching

Applying 0001-build-fix-introspection-setup-in-cross-builds.patch using patch:
patching file m4/introspection.m4
>>> libmbim 1.24.8 Updating config.sub and config.guess
for file in config.guess config.sub; do for i in $(find
/home/user/MyProjects/oss/br-test-v2/s2srv/build/libmbim-1.24.8 -name
$file); do cp support/gnuconfig/$file $i; done; done
>>> libmbim 1.24.8 Configuring
>>> libmbim 1.24.8 Autoreconfiguring
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:65: error: Unexpanded AX_ macro found. Please install GNU
autoconf-archive
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:66: error: Unexpanded AX_ macro found. Please install GNU
autoconf-archive

Regards,
Yegor
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-21  7:38                     ` Yegor Yefremov via buildroot
@ 2021-07-21  8:07                       ` Aleksander Morgado
  2021-07-21 12:11                         ` Yegor Yefremov via buildroot
  0 siblings, 1 reply; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-21  8:07 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: Thomas Petazzoni, buildroot

Hey!

> > > INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> > > path inside my BR, everything is working (the same issue is with
> > > Qmi-1.0.typelib).
> > >
> >
> > The introspection.m4 included in the sources is a bit outdated, the
> > attached patch syncs it with the newest one I have installed in my
> > system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
> > in the patch, so these may be enough. Any chance you can give this
> > patch a try? You may need to force autoreconf as we're patching a m4
> > file-
>
> >>> libmbim 1.24.8 Patching
>
> Applying 0001-build-fix-introspection-setup-in-cross-builds.patch using patch:
> patching file m4/introspection.m4
> >>> libmbim 1.24.8 Updating config.sub and config.guess
> for file in config.guess config.sub; do for i in $(find
> /home/user/MyProjects/oss/br-test-v2/s2srv/build/libmbim-1.24.8 -name
> $file); do cp support/gnuconfig/$file $i; done; done
> >>> libmbim 1.24.8 Configuring
> >>> libmbim 1.24.8 Autoreconfiguring
> libtoolize: putting auxiliary files in '.'.
> libtoolize: copying file './ltmain.sh'
> libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> libtoolize: copying file 'm4/libtool.m4'
> libtoolize: copying file 'm4/ltoptions.m4'
> libtoolize: copying file 'm4/ltsugar.m4'
> libtoolize: copying file 'm4/ltversion.m4'
> libtoolize: copying file 'm4/lt~obsolete.m4'
> configure.ac:65: error: Unexpanded AX_ macro found. Please install GNU
> autoconf-archive
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> configure.ac:66: error: Unexpanded AX_ macro found. Please install GNU
> autoconf-archive
>

Gah... forgot autoconf-archive is a prerequisite when autoreconf-ing.

I don't have time myself to test it right now, but the steps to do
this properly would be to git clone the libmbim git repo, switch to
mbim-1-24 branch, apply the patch, "NOCONFIGURE=1 ./autogen.sh &&
./configure --enable-gtk-doc && make && make distcheck". And once you
have the release tarball, use that in buildroot.

I can probably play with that later today if you don't do it earlier :)


-- 
Aleksander
https://aleksander.es
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-21  8:07                       ` Aleksander Morgado
@ 2021-07-21 12:11                         ` Yegor Yefremov via buildroot
  2021-07-21 12:55                           ` Aleksander Morgado
  0 siblings, 1 reply; 18+ messages in thread
From: Yegor Yefremov via buildroot @ 2021-07-21 12:11 UTC (permalink / raw)
  To: Aleksander Morgado; +Cc: Thomas Petazzoni, buildroot

On Wed, Jul 21, 2021 at 10:07 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> Hey!
>
> > > > INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> > > > path inside my BR, everything is working (the same issue is with
> > > > Qmi-1.0.typelib).
> > > >
> > >
> > > The introspection.m4 included in the sources is a bit outdated, the
> > > attached patch syncs it with the newest one I have installed in my
> > > system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
> > > in the patch, so these may be enough. Any chance you can give this
> > > patch a try? You may need to force autoreconf as we're patching a m4
> > > file-
> >
> > >>> libmbim 1.24.8 Patching
> >
> > Applying 0001-build-fix-introspection-setup-in-cross-builds.patch using patch:
> > patching file m4/introspection.m4
> > >>> libmbim 1.24.8 Updating config.sub and config.guess
> > for file in config.guess config.sub; do for i in $(find
> > /home/user/MyProjects/oss/br-test-v2/s2srv/build/libmbim-1.24.8 -name
> > $file); do cp support/gnuconfig/$file $i; done; done
> > >>> libmbim 1.24.8 Configuring
> > >>> libmbim 1.24.8 Autoreconfiguring
> > libtoolize: putting auxiliary files in '.'.
> > libtoolize: copying file './ltmain.sh'
> > libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> > libtoolize: copying file 'm4/libtool.m4'
> > libtoolize: copying file 'm4/ltoptions.m4'
> > libtoolize: copying file 'm4/ltsugar.m4'
> > libtoolize: copying file 'm4/ltversion.m4'
> > libtoolize: copying file 'm4/lt~obsolete.m4'
> > configure.ac:65: error: Unexpanded AX_ macro found. Please install GNU
> > autoconf-archive
> >       If this token and others are legitimate, please use m4_pattern_allow.
> >       See the Autoconf documentation.
> > configure.ac:66: error: Unexpanded AX_ macro found. Please install GNU
> > autoconf-archive
> >
>
> Gah... forgot autoconf-archive is a prerequisite when autoreconf-ing.

My BR has autoconf-archive installed. Why does it fail?

> I don't have time myself to test it right now, but the steps to do
> this properly would be to git clone the libmbim git repo, switch to
> mbim-1-24 branch, apply the patch, "NOCONFIGURE=1 ./autogen.sh &&
> ./configure --enable-gtk-doc && make && make distcheck". And once you
> have the release tarball, use that in buildroot.
>
> I can probably play with that later today if you don't do it earlier :)

It doesn't work :-( Though I see introspection.m4 file in
output/build/libmbim/m4 folder after replacing the tarball, the result
in Makefile is still the same.

Best regards,
Yegor
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-21 12:11                         ` Yegor Yefremov via buildroot
@ 2021-07-21 12:55                           ` Aleksander Morgado
  2021-07-21 13:15                             ` Yegor Yefremov via buildroot
  0 siblings, 1 reply; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-21 12:55 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: Thomas Petazzoni, buildroot

Hey,

> >
> > > > > INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> > > > > path inside my BR, everything is working (the same issue is with
> > > > > Qmi-1.0.typelib).
> > > > >
> > > >
> > > > The introspection.m4 included in the sources is a bit outdated, the
> > > > attached patch syncs it with the newest one I have installed in my
> > > > system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
> > > > in the patch, so these may be enough. Any chance you can give this
> > > > patch a try? You may need to force autoreconf as we're patching a m4
> > > > file-
> > >
> > > >>> libmbim 1.24.8 Patching
> > >
> > > Applying 0001-build-fix-introspection-setup-in-cross-builds.patch using patch:
> > > patching file m4/introspection.m4
> > > >>> libmbim 1.24.8 Updating config.sub and config.guess
> > > for file in config.guess config.sub; do for i in $(find
> > > /home/user/MyProjects/oss/br-test-v2/s2srv/build/libmbim-1.24.8 -name
> > > $file); do cp support/gnuconfig/$file $i; done; done
> > > >>> libmbim 1.24.8 Configuring
> > > >>> libmbim 1.24.8 Autoreconfiguring
> > > libtoolize: putting auxiliary files in '.'.
> > > libtoolize: copying file './ltmain.sh'
> > > libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> > > libtoolize: copying file 'm4/libtool.m4'
> > > libtoolize: copying file 'm4/ltoptions.m4'
> > > libtoolize: copying file 'm4/ltsugar.m4'
> > > libtoolize: copying file 'm4/ltversion.m4'
> > > libtoolize: copying file 'm4/lt~obsolete.m4'
> > > configure.ac:65: error: Unexpanded AX_ macro found. Please install GNU
> > > autoconf-archive
> > >       If this token and others are legitimate, please use m4_pattern_allow.
> > >       See the Autoconf documentation.
> > > configure.ac:66: error: Unexpanded AX_ macro found. Please install GNU
> > > autoconf-archive
> > >
> >
> > Gah... forgot autoconf-archive is a prerequisite when autoreconf-ing.
>
> My BR has autoconf-archive installed. Why does it fail?
>
> > I don't have time myself to test it right now, but the steps to do
> > this properly would be to git clone the libmbim git repo, switch to
> > mbim-1-24 branch, apply the patch, "NOCONFIGURE=1 ./autogen.sh &&
> > ./configure --enable-gtk-doc && make && make distcheck". And once you
> > have the release tarball, use that in buildroot.
> >
> > I can probably play with that later today if you don't do it earlier :)
>
> It doesn't work :-( Though I see introspection.m4 file in
> output/build/libmbim/m4 folder after replacing the tarball, the result
> in Makefile is still the same.
>

I've opened this issue in GNOME bugzilla:
https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/391
I believe I know how to fix it, I'm giving it a try now.

-- 
Aleksander
https://aleksander.es
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-21 12:55                           ` Aleksander Morgado
@ 2021-07-21 13:15                             ` Yegor Yefremov via buildroot
  2021-07-21 13:53                               ` Aleksander Morgado
  0 siblings, 1 reply; 18+ messages in thread
From: Yegor Yefremov via buildroot @ 2021-07-21 13:15 UTC (permalink / raw)
  To: Aleksander Morgado; +Cc: Thomas Petazzoni, buildroot

Hi,

On Wed, Jul 21, 2021 at 2:55 PM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> Hey,
>
> > >
> > > > > > INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> > > > > > path inside my BR, everything is working (the same issue is with
> > > > > > Qmi-1.0.typelib).
> > > > > >
> > > > >
> > > > > The introspection.m4 included in the sources is a bit outdated, the
> > > > > attached patch syncs it with the newest one I have installed in my
> > > > > system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
> > > > > in the patch, so these may be enough. Any chance you can give this
> > > > > patch a try? You may need to force autoreconf as we're patching a m4
> > > > > file-
> > > >
> > > > >>> libmbim 1.24.8 Patching
> > > >
> > > > Applying 0001-build-fix-introspection-setup-in-cross-builds.patch using patch:
> > > > patching file m4/introspection.m4
> > > > >>> libmbim 1.24.8 Updating config.sub and config.guess
> > > > for file in config.guess config.sub; do for i in $(find
> > > > /home/user/MyProjects/oss/br-test-v2/s2srv/build/libmbim-1.24.8 -name
> > > > $file); do cp support/gnuconfig/$file $i; done; done
> > > > >>> libmbim 1.24.8 Configuring
> > > > >>> libmbim 1.24.8 Autoreconfiguring
> > > > libtoolize: putting auxiliary files in '.'.
> > > > libtoolize: copying file './ltmain.sh'
> > > > libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> > > > libtoolize: copying file 'm4/libtool.m4'
> > > > libtoolize: copying file 'm4/ltoptions.m4'
> > > > libtoolize: copying file 'm4/ltsugar.m4'
> > > > libtoolize: copying file 'm4/ltversion.m4'
> > > > libtoolize: copying file 'm4/lt~obsolete.m4'
> > > > configure.ac:65: error: Unexpanded AX_ macro found. Please install GNU
> > > > autoconf-archive
> > > >       If this token and others are legitimate, please use m4_pattern_allow.
> > > >       See the Autoconf documentation.
> > > > configure.ac:66: error: Unexpanded AX_ macro found. Please install GNU
> > > > autoconf-archive
> > > >
> > >
> > > Gah... forgot autoconf-archive is a prerequisite when autoreconf-ing.
> >
> > My BR has autoconf-archive installed. Why does it fail?
> >
> > > I don't have time myself to test it right now, but the steps to do
> > > this properly would be to git clone the libmbim git repo, switch to
> > > mbim-1-24 branch, apply the patch, "NOCONFIGURE=1 ./autogen.sh &&
> > > ./configure --enable-gtk-doc && make && make distcheck". And once you
> > > have the release tarball, use that in buildroot.
> > >
> > > I can probably play with that later today if you don't do it earlier :)
> >
> > It doesn't work :-( Though I see introspection.m4 file in
> > output/build/libmbim/m4 folder after replacing the tarball, the result
> > in Makefile is still the same.
> >
>
> I've opened this issue in GNOME bugzilla:
> https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/391
> I believe I know how to fix it, I'm giving it a try now.

Great, thanks.

Just curious, are you going to port mm and libs to meson?

Best regards,
Yegor
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8
  2021-07-21 13:15                             ` Yegor Yefremov via buildroot
@ 2021-07-21 13:53                               ` Aleksander Morgado
  0 siblings, 0 replies; 18+ messages in thread
From: Aleksander Morgado @ 2021-07-21 13:53 UTC (permalink / raw)
  To: Yegor Yefremov, Aduskett; +Cc: Thomas Petazzoni, buildroot

Hey,

> > > > > > > INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> > > > > > > path inside my BR, everything is working (the same issue is with
> > > > > > > Qmi-1.0.typelib).
> > > > > > >
> > > > > >
> > > > > > The introspection.m4 included in the sources is a bit outdated, the
> > > > > > attached patch syncs it with the newest one I have installed in my
> > > > > > system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
> > > > > > in the patch, so these may be enough. Any chance you can give this
> > > > > > patch a try? You may need to force autoreconf as we're patching a m4
> > > > > > file-
> > > > >
> > > > > >>> libmbim 1.24.8 Patching
> > > > >
> > > > > Applying 0001-build-fix-introspection-setup-in-cross-builds.patch using patch:
> > > > > patching file m4/introspection.m4
> > > > > >>> libmbim 1.24.8 Updating config.sub and config.guess
> > > > > for file in config.guess config.sub; do for i in $(find
> > > > > /home/user/MyProjects/oss/br-test-v2/s2srv/build/libmbim-1.24.8 -name
> > > > > $file); do cp support/gnuconfig/$file $i; done; done
> > > > > >>> libmbim 1.24.8 Configuring
> > > > > >>> libmbim 1.24.8 Autoreconfiguring
> > > > > libtoolize: putting auxiliary files in '.'.
> > > > > libtoolize: copying file './ltmain.sh'
> > > > > libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> > > > > libtoolize: copying file 'm4/libtool.m4'
> > > > > libtoolize: copying file 'm4/ltoptions.m4'
> > > > > libtoolize: copying file 'm4/ltsugar.m4'
> > > > > libtoolize: copying file 'm4/ltversion.m4'
> > > > > libtoolize: copying file 'm4/lt~obsolete.m4'
> > > > > configure.ac:65: error: Unexpanded AX_ macro found. Please install GNU
> > > > > autoconf-archive
> > > > >       If this token and others are legitimate, please use m4_pattern_allow.
> > > > >       See the Autoconf documentation.
> > > > > configure.ac:66: error: Unexpanded AX_ macro found. Please install GNU
> > > > > autoconf-archive
> > > > >
> > > >
> > > > Gah... forgot autoconf-archive is a prerequisite when autoreconf-ing.
> > >
> > > My BR has autoconf-archive installed. Why does it fail?
> > >
> > > > I don't have time myself to test it right now, but the steps to do
> > > > this properly would be to git clone the libmbim git repo, switch to
> > > > mbim-1-24 branch, apply the patch, "NOCONFIGURE=1 ./autogen.sh &&
> > > > ./configure --enable-gtk-doc && make && make distcheck". And once you
> > > > have the release tarball, use that in buildroot.
> > > >
> > > > I can probably play with that later today if you don't do it earlier :)
> > >
> > > It doesn't work :-( Though I see introspection.m4 file in
> > > output/build/libmbim/m4 folder after replacing the tarball, the result
> > > in Makefile is still the same.
> > >
> >
> > I've opened this issue in GNOME bugzilla:
> > https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/391
> > I believe I know how to fix it, I'm giving it a try now.
>

Nah, it's getting out of hand, don't have time to get deep into
solving the bug today I'm afraid.

I think it could be some lack of alignment between the latest
gobject-introspection release and what buildroot is doing in
GOBJECT_INTROSPECTION_INSTALL_WRAPPERS (in
package/gobject-introspection/gobject-introspection.mk). That logic is
replacing how girdir and typelibdir are being built, using exec_prefix
instead of datadir and libdir, and in my build, that gives us some
unexpected results when INTROSPECTION_GIRDIR and
INTROSPECTION_TYPELIBDIR are built:

INTROSPECTION_GIRDIR = /share/gir-1.0
INTROSPECTION_TYPELIBDIR = /lib/girepository-1.0

As if the exec_prefix replacement gave an empty string?

And the same kind of issue when building INTROSPECTION_MAKEFILE. The
buildroot specific wrappers attempt to define a datarootdir based on
$(libdir)/../share, but still, we're getting a path to the host prefix
instead:

INTROSPECTION_MAKEFILE =
/usr/share/gobject-introspection-1.0/Makefile.introspection

The fact that libmbim ships its own introspection.m4 file also doesn't
help clear the issue, even if I think it could be unrelated to the
actual problem (the bug is reproduced in the very same way when
updating the file in libmbim to the newest one). E.g. the
gobject-introspection from release 1.68 does some AS_AC_EXPAND()
operations on datadir and libdir, and the one shipped with libmbim
doesn't do any of that. Maybe I should also make it a requirement when
building from git, instead of shipping our own, so that the
introspection.m4 from /usr/share/aclocal is used, not sure about that
though.

Adding Adam Duskett in CC to see if he has any idea about this
problem. It's easily reproducible here as well, with a clean buildroot
build using glibc toolchain, python3 enabled, gobject-introspection
enabled, and libmbim enabled (and without gobject-introspection in the
host). Adam, could you help us solve this issue?

>
> Just curious, are you going to port mm and libs to meson?
>

libmbim and libqmi are already ported in git master, next releases
will support both autotools and meson. MM is not ported yet, patches
welcome :)

-- 
Aleksander
https://aleksander.es
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2021-07-21 13:53 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12  9:18 [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8 Aleksander Morgado
2021-07-16 20:54 ` Thomas Petazzoni
2021-07-20  6:15   ` Yegor Yefremov
2021-07-20  8:45     ` Aleksander Morgado
2021-07-20  8:56       ` Yegor Yefremov
2021-07-20  9:07         ` Aleksander Morgado
2021-07-20  9:15           ` Yegor Yefremov
2021-07-20  9:21             ` Aleksander Morgado
2021-07-20 10:39               ` Yegor Yefremov
2021-07-20 23:35                 ` Yegor Yefremov
2021-07-20 23:35                   ` Yegor Yefremov via buildroot
2021-07-21  7:20                   ` Aleksander Morgado
2021-07-21  7:38                     ` Yegor Yefremov via buildroot
2021-07-21  8:07                       ` Aleksander Morgado
2021-07-21 12:11                         ` Yegor Yefremov via buildroot
2021-07-21 12:55                           ` Aleksander Morgado
2021-07-21 13:15                             ` Yegor Yefremov via buildroot
2021-07-21 13:53                               ` Aleksander Morgado

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.