All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yegor Yefremov via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: "Wojciech M . Zabolotny" <wzab01@gmail.com>,
	buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8
Date: Tue, 12 Apr 2022 08:06:24 +0200	[thread overview]
Message-ID: <CAGm1_kv5XD3upSOVM3bX310qmf7Pn10CXO5LcmrKH1CiGfXMzw@mail.gmail.com> (raw)
In-Reply-To: <20220411221248.609465-1-fontaine.fabrice@gmail.com>

On Tue, Apr 12, 2022 at 12:14 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> SPI unconditionally uses GPIOHANDLE_SET_LINE_VALUES_IOCTL which is only
> available since kernel 4.8 and
> https://github.com/torvalds/linux/commit/d7c51b47ac11e66f547b55640405c1c474642d72
> resulting in the following build failure since switch to upstream in
> commit 03fa36df7e6aca0f4a1c8ae2fe691c0cda6ddc7a:
>
> linuxspi.c: In function 'linuxspi_reset_mcu':
> linuxspi.c:102:28: error: storage size of 'data' isn't known
>      struct gpiohandle_data data;
>                             ^~~~
> linuxspi.c:110:32: error: 'GPIOHANDLE_SET_LINE_VALUES_IOCTL' undeclared (first use in this function)
>      ret = ioctl(fd_linehandle, GPIOHANDLE_SET_LINE_VALUES_IOCTL, &data);
>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes:
>  - http://autobuild.buildroot.org/results/769021040e5e9293584734e4f461baeaa6dd91cd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

>  package/avrdude/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
> index 89558a5ff5..cbbd076667 100644
> --- a/package/avrdude/Config.in
> +++ b/package/avrdude/Config.in
> @@ -20,10 +20,10 @@ if BR2_PACKAGE_AVRDUDE
>  config BR2_PACKAGE_AVRDUDE_SPI
>         bool "SPI support"
>         default y # Backward compatibility
> -       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
>
> -comment "SPI support needs a toolchain w/ linux headers >= 4.6"
> -       depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +comment "SPI support needs a toolchain w/ linux headers >= 4.8"
> +       depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
>
>  endif
>
> --
> 2.35.1
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-04-12  6:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 22:12 [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8 Fabrice Fontaine
2022-04-12  6:06 ` Yegor Yefremov via buildroot [this message]
2022-04-14 20:25 ` Arnout Vandecappelle
2022-05-22 10:07 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGm1_kv5XD3upSOVM3bX310qmf7Pn10CXO5LcmrKH1CiGfXMzw@mail.gmail.com \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=wzab01@gmail.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.