All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yegor Yefremov <yegorslists@googlemail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libftdi1: fix python support
Date: Fri, 14 Feb 2020 16:06:06 +0100	[thread overview]
Message-ID: <CAGm1_kvBo0hfYTayZJ0AGQTFfAsU=5ur2O7rvOHcas6sXBbcxw@mail.gmail.com> (raw)
In-Reply-To: <CAGm1_ktss6p4wNv7FrZSgH8N=jQbnRTepEHNk_r6+MoGxy23Xg@mail.gmail.com>

Hi Peter,

On Fri, Feb 7, 2020 at 3:55 PM Yegor Yefremov
<yegorslists@googlemail.com> wrote:
>
> On Fri, Feb 7, 2020 at 3:53 PM Peter Korsgaard <peter@korsgaard.com> wrote:
> >
> > >>>>> "Yegor" == Yegor Yefremov <yegorslists@googlemail.com> writes:
> >
> > Hi,
> >
> >  > This is what I get when invoking "make libftdi1"
> >
> > Ok. It is not really clear to me why it fails for you but not for me,
> > but ok - Committed, thanks.
> >
> >  > P.S. another issue is that as you can see cmake has found the host's
> >  > own SWIG version and not BR's version which is 4.0.x.
> >
> > Hmm, indeed. We do add our host-swig to the path, so I guess something
> > is hardcoded to look in /usr/bin first?
> >
> > Care to take a look?
>
> Will do.

I have looked at the problem. CMake 3.10.2 doesn't know anything about
SWIG4.0 so it looks for the SWIG binaries in this order (see
Modules/FindSWIG.cmake):

find_program(SWIG_EXECUTABLE NAMES swig3.0 swig2.0 swig)

This way swig3.0 on our host will be detected first. I've added
swig4.0 to my "/usr/share/cmake-3.10/Modules/FindSWIG.cmake" and it
now detects the SWIG built with BR. So for now, the only solution is
either to install an up-to-date CMake via "pip install cmake" or to
bump our CMake requirement to a newer version.

This is the reference of the commit adding SWIG4.0 support: Refs:
v3.14.3-1-g65c5c1b567 [1].

[1] https://github.com/Kitware/CMake/commit/65c5c1b567bdeb4c33ac2f6ad92786c159edf82a

Yegor

  reply	other threads:[~2020-02-14 15:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06  9:54 [Buildroot] [PATCH] package/libftdi1: fix python support yegorslists at googlemail.com
2020-02-07  9:13 ` Peter Korsgaard
2020-02-07  9:30   ` Yegor Yefremov
2020-02-07 10:55     ` Peter Korsgaard
2020-02-07 12:26       ` Yegor Yefremov
2020-02-07 14:53         ` Peter Korsgaard
2020-02-07 14:55           ` Yegor Yefremov
2020-02-14 15:06             ` Yegor Yefremov [this message]
2020-02-15 13:02               ` Peter Korsgaard
2020-02-17  7:14                 ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGm1_kvBo0hfYTayZJ0AGQTFfAsU=5ur2O7rvOHcas6sXBbcxw@mail.gmail.com' \
    --to=yegorslists@googlemail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.