All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yegor Yefremov via buildroot <buildroot@buildroot.org>
To: Sergey Matyukevich <geomatsi@gmail.com>
Cc: Matt Weber <matthew.weber@collins.com>,
	buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/wpa_supplicant: wired driver needs headers >= 4.6
Date: Thu, 12 May 2022 09:22:10 +0200	[thread overview]
Message-ID: <CAGm1_kvOq3F_BNFqWOQhaJsRthOLG1k8vNWtJr3cAqZex2A4Eg@mail.gmail.com> (raw)
In-Reply-To: <20220511194616.2272499-1-geomatsi@gmail.com>

Hi Sergey,

On Wed, May 11, 2022 at 9:46 PM Sergey Matyukevich <geomatsi@gmail.com> wrote:
>
> Wired driver enables macsec support which depends on if_macsec.h.
> That header has only been exported since kernel v4.6, see commit:
> https://github.com/torvalds/linux/commit/dece8d2b78d19df7fe5e4e965f1f0d1a3e188d1b
>
> Fixes:
> - http://autobuild.buildroot.net/results/6bb619eb7fdecf7824fcc549c4ccb8e487665d10/
>
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Regards,
Yegor

> ---
>  package/wpa_supplicant/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 7e2432985c..92953f69f0 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -42,6 +42,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
>  config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>         bool "Enable wired support"
>         depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
> +       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
>         select BR2_PACKAGE_LIBNL
>         select BR2_PACKAGE_WPA_SUPPLICANT_EAP
>         help
> @@ -49,6 +50,9 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>           supplicant can be used with Ethernet.  This also enables
>           support for MACSEC.
>
> +comment "wired macsec support needs a toolchain w/ headers >= 4.6"
> +       depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +
>  comment "wired support needs a toolchain w/ threads"
>         depends on !BR2_TOOLCHAIN_HAS_THREADS
>
> --
> 2.35.1
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-05-12  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 19:46 [Buildroot] [PATCH 1/1] package/wpa_supplicant: wired driver needs headers >= 4.6 Sergey Matyukevich
2022-05-12  7:22 ` Yegor Yefremov via buildroot [this message]
2022-05-14  9:47 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGm1_kvOq3F_BNFqWOQhaJsRthOLG1k8vNWtJr3cAqZex2A4Eg@mail.gmail.com \
    --to=buildroot@buildroot.org \
    --cc=geomatsi@gmail.com \
    --cc=matthew.weber@collins.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.