All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] rauc: new package
@ 2017-06-28  6:07 Andrey Yurovsky
  2017-06-28  6:44 ` Yegor Yefremov
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Andrey Yurovsky @ 2017-06-28  6:07 UTC (permalink / raw)
  To: buildroot

RAUC is the Robust Auto-Update Controller developed by the folks at
Penguintronix. It supports updating embedded systems from the network
(ex: HawkBit) or from a disk and provides a d-bus interface.

Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
---
 package/rauc/Config.in | 18 ++++++++++++++++++
 package/rauc/rauc.hash |  2 ++
 package/rauc/rauc.mk   | 19 +++++++++++++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 package/rauc/Config.in
 create mode 100644 package/rauc/rauc.hash
 create mode 100644 package/rauc/rauc.mk

diff --git a/package/rauc/Config.in b/package/rauc/Config.in
new file mode 100644
index 0000000..8a210a4
--- /dev/null
+++ b/package/rauc/Config.in
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_RAUC
+	bool "rauc"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus-glib -> glib2
+	depends on BR2_USE_WCHAR # glib2
+	depends on BR2_USE_MMU # glib2
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_DBUS_GLIB
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_JSON_GLIB
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
+	help
+	  RAUC controls the update process on embedded Linux systems.
+	  See the documentation at
+	  https://rauc.readthedocs.io/en/latest/ for more
+	  information.
diff --git a/package/rauc/rauc.hash b/package/rauc/rauc.hash
new file mode 100644
index 0000000..7ee9798
--- /dev/null
+++ b/package/rauc/rauc.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  d867a81b9e414c8db9268851011fb2d404a3ee60ae297c007a2f140abfa607d1 rauc-v0.1.1.tar.gz
diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
new file mode 100644
index 0000000..e036387
--- /dev/null
+++ b/package/rauc/rauc.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# rauc
+#
+################################################################################
+
+RAUC_VERSION = v0.1.1
+RAUC_SITE = $(call github,rauc,rauc,$(RAUC_VERSION))
+RAUC_LICENSE = GPL-2.1
+RAUC_LICENSE_FILES = COPYING
+RAUC_AUTORECONF = YES
+RAUC_DEPENDENCIES = libcurl openssl libglib2 json-glib dbus-glib host-pkgconf \
+					dbus util-linux
+
+HOST_RAUC_DEPENDENCIES = host-pkgconf
+HOST_RAUC_CONF_OPTS = --disable-network --disable-json
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH] rauc: new package
  2017-06-28  6:07 [Buildroot] [PATCH] rauc: new package Andrey Yurovsky
@ 2017-06-28  6:44 ` Yegor Yefremov
  2017-06-28 19:59 ` Arnout Vandecappelle
  2017-06-28 21:40 ` [Buildroot] [PATCH v2] " Andrey Yurovsky
  2 siblings, 0 replies; 10+ messages in thread
From: Yegor Yefremov @ 2017-06-28  6:44 UTC (permalink / raw)
  To: buildroot

Hi Andrey,

thanks for your contribution.

On Wed, Jun 28, 2017 at 8:07 AM, Andrey Yurovsky <yurovsky@gmail.com> wrote:
> RAUC is the Robust Auto-Update Controller developed by the folks at
> Penguintronix. It supports updating embedded systems from the network
> (ex: HawkBit) or from a disk and provides a d-bus interface.
>
> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
> ---
>  package/rauc/Config.in | 18 ++++++++++++++++++
>  package/rauc/rauc.hash |  2 ++
>  package/rauc/rauc.mk   | 19 +++++++++++++++++++

An entry to the DEVELOPERS and package/Config.in files is missing.

>  3 files changed, 39 insertions(+)
>  create mode 100644 package/rauc/Config.in
>  create mode 100644 package/rauc/rauc.hash
>  create mode 100644 package/rauc/rauc.mk
>
> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
> new file mode 100644
> index 0000000..8a210a4
> --- /dev/null
> +++ b/package/rauc/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_RAUC
> +       bool "rauc"
> +       depends on BR2_TOOLCHAIN_HAS_THREADS # dbus-glib -> glib2
> +       depends on BR2_USE_WCHAR # glib2
> +       depends on BR2_USE_MMU # glib2
> +       select BR2_PACKAGE_LIBGLIB2
> +       select BR2_PACKAGE_DBUS
> +       select BR2_PACKAGE_DBUS_GLIB
> +       select BR2_PACKAGE_OPENSSL
> +       select BR2_PACKAGE_LIBCURL
> +       select BR2_PACKAGE_JSON_GLIB
> +       select BR2_PACKAGE_UTIL_LINUX
> +       select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
> +       help
> +         RAUC controls the update process on embedded Linux systems.
> +         See the documentation at
> +         https://rauc.readthedocs.io/en/latest/ for more
> +         information.

Though you have depends statements you don't provide a corresponding
message for the case where these dependencies are not met. See
package/modem-manager/Config.in for example.

> diff --git a/package/rauc/rauc.hash b/package/rauc/rauc.hash
> new file mode 100644
> index 0000000..7ee9798
> --- /dev/null
> +++ b/package/rauc/rauc.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  d867a81b9e414c8db9268851011fb2d404a3ee60ae297c007a2f140abfa607d1 rauc-v0.1.1.tar.gz
> diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
> new file mode 100644
> index 0000000..e036387
> --- /dev/null
> +++ b/package/rauc/rauc.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# rauc
> +#
> +################################################################################
> +
> +RAUC_VERSION = v0.1.1
> +RAUC_SITE = $(call github,rauc,rauc,$(RAUC_VERSION))
> +RAUC_LICENSE = GPL-2.1
> +RAUC_LICENSE_FILES = COPYING
> +RAUC_AUTORECONF = YES
> +RAUC_DEPENDENCIES = libcurl openssl libglib2 json-glib dbus-glib host-pkgconf \
> +                                       dbus util-linux
> +
> +HOST_RAUC_DEPENDENCIES = host-pkgconf
> +HOST_RAUC_CONF_OPTS = --disable-network --disable-json

Could you elaborate more on why rauc requires a host variant?

Yegor

> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 2.9.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH] rauc: new package
  2017-06-28  6:07 [Buildroot] [PATCH] rauc: new package Andrey Yurovsky
  2017-06-28  6:44 ` Yegor Yefremov
@ 2017-06-28 19:59 ` Arnout Vandecappelle
  2017-06-28 20:34   ` Andrey Yurovsky
  2017-06-28 21:40 ` [Buildroot] [PATCH v2] " Andrey Yurovsky
  2 siblings, 1 reply; 10+ messages in thread
From: Arnout Vandecappelle @ 2017-06-28 19:59 UTC (permalink / raw)
  To: buildroot

 Hi Andrey,

On 28-06-17 08:07, Andrey Yurovsky wrote:
> RAUC is the Robust Auto-Update Controller developed by the folks at
> Penguintronix. It supports updating embedded systems from the network
  ^^^^^^^^^^^^^Pengutronix

> (ex: HawkBit) or from a disk and provides a d-bus interface.

 So this is Pengutronix' competitor to swupdate?

> 
> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
> ---
>  package/rauc/Config.in | 18 ++++++++++++++++++
>  package/rauc/rauc.hash |  2 ++
>  package/rauc/rauc.mk   | 19 +++++++++++++++++++

 You don't add it to package/Config.in, so it is not possible to select this
package.

 Have you checked the package with support/scripts/check-package ?
 Have you validated it with support/scripts/test-pkg ?

>  3 files changed, 39 insertions(+)
>  create mode 100644 package/rauc/Config.in
>  create mode 100644 package/rauc/rauc.hash
>  create mode 100644 package/rauc/rauc.mk
> 
> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
> new file mode 100644
> index 0000000..8a210a4
> --- /dev/null
> +++ b/package/rauc/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_RAUC
> +	bool "rauc"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus-glib -> glib2
> +	depends on BR2_USE_WCHAR # glib2
> +	depends on BR2_USE_MMU # glib2
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_DBUS_GLIB
> +	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_LIBCURL
> +	select BR2_PACKAGE_JSON_GLIB
> +	select BR2_PACKAGE_UTIL_LINUX
> +	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
> +	help
> +	  RAUC controls the update process on embedded Linux systems.
> +	  See the documentation at
> +	  https://rauc.readthedocs.io/en/latest/ for more
> +	  information.

 You can include the full text that you have in the commit log. Also, we need an
upstream URL. And with that added, the reference to the documentation is not
really needed (it's one click away from the upstream URL). So:

	  RAUC is the Robust Auto-Update Controller developed by Pengutronix.
	  It controls the update process on embedded Linux systems. It supports
	  updating from the network or from a disk. It provides a D-Bus
	  interface.

	  http://rauc.io/

> diff --git a/package/rauc/rauc.hash b/package/rauc/rauc.hash
> new file mode 100644
> index 0000000..7ee9798
> --- /dev/null
> +++ b/package/rauc/rauc.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated

 Please verify the tarball against the upstream signature, and write:

# Locally calculated, after verifying against
# https://github.com/rauc/rauc/releases/download/v0.1.1/rauc-0.1.1.tar.xz.asc

> +sha256  d867a81b9e414c8db9268851011fb2d404a3ee60ae297c007a2f140abfa607d1 rauc-v0.1.1.tar.gz
> diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
> new file mode 100644
> index 0000000..e036387
> --- /dev/null
> +++ b/package/rauc/rauc.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# rauc
> +#
> +################################################################################
> +
> +RAUC_VERSION = v0.1.1
> +RAUC_SITE = $(call github,rauc,rauc,$(RAUC_VERSION))

 There is an upstream tarball, so you should use that:

RAUC_VERSION = 0.1.1
RAUC_SITE = https://github.com/rauc/rauc/releases/download/v$(RAUC_VERSION)
RAUC_SOURCE = rauc-$(RAUC_VERSION).tar.xz

> +RAUC_LICENSE = GPL-2.1

 GPL-2.1 doesn't exist, it's LGPL-2.1.

> +RAUC_LICENSE_FILES = COPYING
> +RAUC_AUTORECONF = YES

 With the uploaded tarball this shouldn't be needed anymore.

> +RAUC_DEPENDENCIES = libcurl openssl libglib2 json-glib dbus-glib host-pkgconf \
> +					dbus util-linux

 It seems that most of these are optional:

libcurl is only needed if --enable-network
json-glib is only needed if --enable-json

 And configure.ac has no dependency at all on dbus-glib, dbus or libmount.

 On the other hand, configure uses pkg-config to determine the systemd install
directories, so you should have a conditional dependency on this package:

ifeq ($(BR2_PACKAGE_SYSTEMD),y)
# configure uses pkg-config --variable=systemdsystemunitdir systemd
RAUC_DEPENDENCIES += systemd
endif


 Regards,
 Arnout

> +
> +HOST_RAUC_DEPENDENCIES = host-pkgconf
> +HOST_RAUC_CONF_OPTS = --disable-network --disable-json
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH] rauc: new package
  2017-06-28 19:59 ` Arnout Vandecappelle
@ 2017-06-28 20:34   ` Andrey Yurovsky
  0 siblings, 0 replies; 10+ messages in thread
From: Andrey Yurovsky @ 2017-06-28 20:34 UTC (permalink / raw)
  To: buildroot

Hi Arnout,

On Wed, Jun 28, 2017 at 12:59 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
>  Hi Andrey,
>
> On 28-06-17 08:07, Andrey Yurovsky wrote:
>> RAUC is the Robust Auto-Update Controller developed by the folks at
>> Penguintronix. It supports updating embedded systems from the network
>   ^^^^^^^^^^^^^Pengutronix
>
>> (ex: HawkBit) or from a disk and provides a d-bus interface.
>
>  So this is Pengutronix' competitor to swupdate?

I believe so. I have no personal involvement in either one but rauc's
approach is a little different and it may offer advantages for certain
systems (for example its d-bus interface vs. a UNIX socket) and the
firmware bundle/image format is different. They're roughly equivalent
in the problem they're solving though.

>>
>> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
>> ---
>>  package/rauc/Config.in | 18 ++++++++++++++++++
>>  package/rauc/rauc.hash |  2 ++
>>  package/rauc/rauc.mk   | 19 +++++++++++++++++++
>
>  You don't add it to package/Config.in, so it is not possible to select this
> package.

That's right, I have no idea how I messed that up and it'll be addressed in v2.

>  Have you checked the package with support/scripts/check-package ?
>  Have you validated it with support/scripts/test-pkg ?

I did run check-package but not test-pkg, I'll make sure both are run
next time, again sorry about that.

>  You can include the full text that you have in the commit log. Also, we need an
> upstream URL. And with that added, the reference to the documentation is not
> really needed (it's one click away from the upstream URL). So:
>
>           RAUC is the Robust Auto-Update Controller developed by Pengutronix.
>           It controls the update process on embedded Linux systems. It supports
>           updating from the network or from a disk. It provides a D-Bus
>           interface.
>
>           http://rauc.io/

Understood. Will do.

>  Please verify the tarball against the upstream signature, and write:
>
> # Locally calculated, after verifying against
> # https://github.com/rauc/rauc/releases/download/v0.1.1/rauc-0.1.1.tar.xz.asc

Ok.

>  There is an upstream tarball, so you should use that:

Ok, I was following another package, I'll use the tarball directly
since indeed they have tarball releases.

> RAUC_VERSION = 0.1.1
> RAUC_SITE = https://github.com/rauc/rauc/releases/download/v$(RAUC_VERSION)
> RAUC_SOURCE = rauc-$(RAUC_VERSION).tar.xz
>
>> +RAUC_LICENSE = GPL-2.1
>
>  GPL-2.1 doesn't exist, it's LGPL-2.1.

That's a very bad typo on my part, thanks for catching it.

>> +RAUC_LICENSE_FILES = COPYING
>> +RAUC_AUTORECONF = YES
>
>  With the uploaded tarball this shouldn't be needed anymore.

Understood.

>> +RAUC_DEPENDENCIES = libcurl openssl libglib2 json-glib dbus-glib host-pkgconf \
>> +                                     dbus util-linux
>
>  It seems that most of these are optional:
>
> libcurl is only needed if --enable-network
> json-glib is only needed if --enable-json

I debated about this and thought users would generally want both
features, I now see that in buildroot it's more common to make them
optional so I'll add networking and JSON support as high-level options
and make them conditional on that (I suppose someone may be building a
non-networked device that still needs rauc to perform updates from a
USB disk).

>  And configure.ac has no dependency at all on dbus-glib, dbus or libmount.

You're right, I missed that they use the GIO dbus interface instead
and indeed dbus-glib isn't needed. Is d-bus acceptable as a runtime
dependency? That is, rauc won't be terribly useful if the target
doesn't have d-bus at runtime.

>  On the other hand, configure uses pkg-config to determine the systemd install
> directories, so you should have a conditional dependency on this package:
>
> ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> # configure uses pkg-config --variable=systemdsystemunitdir systemd
> RAUC_DEPENDENCIES += systemd
> endif

Will do, thanks again for all of the feedback.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2] rauc: new package
  2017-06-28  6:07 [Buildroot] [PATCH] rauc: new package Andrey Yurovsky
  2017-06-28  6:44 ` Yegor Yefremov
  2017-06-28 19:59 ` Arnout Vandecappelle
@ 2017-06-28 21:40 ` Andrey Yurovsky
  2017-06-29  5:20   ` Yegor Yefremov
  2017-06-29 18:58   ` Peter Seiderer
  2 siblings, 2 replies; 10+ messages in thread
From: Andrey Yurovsky @ 2017-06-28 21:40 UTC (permalink / raw)
  To: buildroot

RAUC is the Robust Auto-Update Controller developed by the folks at
Penguintronix. It supports updating embedded systems from the network
(ex: HawkBit) or from a disk and provides a d-bus interface.

Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
---
 DEVELOPERS                  |  3 +++
 package/Config.in           |  1 +
 package/Config.in.host      |  1 +
 package/rauc/Config.in      | 37 +++++++++++++++++++++++++++++++++++++
 package/rauc/Config.in.host |  9 +++++++++
 package/rauc/rauc.hash      |  3 +++
 package/rauc/rauc.mk        | 36 ++++++++++++++++++++++++++++++++++++
 7 files changed, 90 insertions(+)
 create mode 100644 package/rauc/Config.in
 create mode 100644 package/rauc/Config.in.host
 create mode 100644 package/rauc/rauc.hash
 create mode 100644 package/rauc/rauc.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 9e421f4..7600cb5 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -95,6 +95,9 @@ F:	package/python-scandir/
 F:	package/python-simplegeneric/
 F:	package/python-traitlets/
 
+N:  Andrey Yurovsky <yurovsky@gmail.com>
+F:  package/rauc
+
 N:	Andy Kennedy <andy.kennedy@adtran.com>
 F:	package/libunwind/
 
diff --git a/package/Config.in b/package/Config.in
index f69f67f..fdfcd02 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1865,6 +1865,7 @@ menu "System tools"
 	source "package/psmisc/Config.in"
 	source "package/pwgen/Config.in"
 	source "package/quota/Config.in"
+	source "package/rauc/Config.in"
 	source "package/rsyslog/Config.in"
 	source "package/runc/Config.in"
 	source "package/s6/Config.in"
diff --git a/package/Config.in.host b/package/Config.in.host
index 38f919a..0932b9f 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -39,6 +39,7 @@ menu "Host utilities"
 	source "package/python-lxml/Config.in.host"
 	source "package/qemu/Config.in.host"
 	source "package/raspberrypi-usbboot/Config.in.host"
+	source "package/rauc/Config.in.host"
 	source "package/s6-rc/Config.in.host"
 	source "package/sam-ba/Config.in.host"
 	source "package/squashfs/Config.in.host"
diff --git a/package/rauc/Config.in b/package/rauc/Config.in
new file mode 100644
index 0000000..f63ab54
--- /dev/null
+++ b/package/rauc/Config.in
@@ -0,0 +1,37 @@
+config BR2_PACKAGE_RAUC
+	bool "rauc"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
+	depends on BR2_USE_MMU # glib2
+	depends on BR2_USE_WCHAR # glib2
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_DBUS # run-time dependency
+	help
+	  RAUC is the Robust Auto-Update Controller developed by
+	  Penguintronix. It supports updating embedded Linux
+	  systems over the network or from disks and provides a
+	  d-bus interface.
+
+	  http://rauc.io/
+
+if BR2_PACKAGE_RAUC
+
+config BR2_PACKAGE_RAUC_NETWORK
+	bool "network support"
+	select BR2_PACKAGE_LIBCURL
+	help
+	  This option enables support for updating firmware over
+	  the network using libcurl.
+
+config BR2_PACKAGE_RAUC_JSON
+	bool "JSON output support"
+	select BR2_PACKAGE_JSON_GLIB
+	help
+	  This option enables support for providing output in
+	  JSON format.
+
+endif
+
+comment "rauc needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_MMU
diff --git a/package/rauc/Config.in.host b/package/rauc/Config.in.host
new file mode 100644
index 0000000..e45406e
--- /dev/null
+++ b/package/rauc/Config.in.host
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_HOST_RAUC
+	bool "host rauc"
+	help
+	  RAUC is the Robust Auto-Update Controller developed by
+	  Penguintronix. Enable this option to build the rauc
+	  host tool which may be used to generate firmware
+	  bundles that are handled by the target rauc service.
+
+	  http://rauc.io/
diff --git a/package/rauc/rauc.hash b/package/rauc/rauc.hash
new file mode 100644
index 0000000..78c3e27
--- /dev/null
+++ b/package/rauc/rauc.hash
@@ -0,0 +1,3 @@
+# Locally calculated, after verifying against
+# https://github.com/rauc/rauc/releases/download/v0.1.1/rauc-0.1.1.tar.xz.asc
+sha256 d2901d493f1d3210aef6411e83b02edac3a678d6d825d71a1c61b5b6afc7e478 rauc-0.1.1.tar.xz
diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
new file mode 100644
index 0000000..12819d9
--- /dev/null
+++ b/package/rauc/rauc.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# rauc
+#
+################################################################################
+
+RAUC_VERSION = 0.1.1
+RAUC_SITE = https://github.com/rauc/rauc/releases/download/v$(RAUC_VERSION)
+RAUC_SOURCE = rauc-$(RAUC_VERSION).tar.xz
+RAUC_LICENSE = LGPL-2.1
+RAUC_DEPENDENCIES = host-pkgconf openssl libglib2
+
+ifeq ($(BR2_PACKAGE_RAUC_NETWORK),y)
+RAUC_CONF_OPTS += --enable-network
+RAUC_DEPENDENCIES += libcurl
+else
+RAUC_CONF_OPTS += --disable-network
+endif
+
+ifeq ($(BR2_PACKAGE_RAUC_JSON),y)
+RAUC_CONF_OPTS += --enable-json
+RAUC_DEPENDENCIES += json-glib
+else
+RAUC_CONF_OPTS += --disable-json
+endif
+
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+# configure uses pkg-config --variable=systemdsystemunitdir systemd
+RAUC_DEPENDENCIES += systemd
+endif
+
+HOST_RAUC_DEPENDENCIES = host-pkgconf
+HOST_RAUC_CONF_OPTS += --disable-network --disable-json --disable-service
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2] rauc: new package
  2017-06-28 21:40 ` [Buildroot] [PATCH v2] " Andrey Yurovsky
@ 2017-06-29  5:20   ` Yegor Yefremov
  2017-06-29 18:58   ` Peter Seiderer
  1 sibling, 0 replies; 10+ messages in thread
From: Yegor Yefremov @ 2017-06-29  5:20 UTC (permalink / raw)
  To: buildroot

On Wed, Jun 28, 2017 at 11:40 PM, Andrey Yurovsky <yurovsky@gmail.com> wrote:
> RAUC is the Robust Auto-Update Controller developed by the folks at
> Penguintronix. It supports updating embedded systems from the network
> (ex: HawkBit) or from a disk and provides a d-bus interface.
>
> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

> ---
>  DEVELOPERS                  |  3 +++
>  package/Config.in           |  1 +
>  package/Config.in.host      |  1 +
>  package/rauc/Config.in      | 37 +++++++++++++++++++++++++++++++++++++
>  package/rauc/Config.in.host |  9 +++++++++
>  package/rauc/rauc.hash      |  3 +++
>  package/rauc/rauc.mk        | 36 ++++++++++++++++++++++++++++++++++++
>  7 files changed, 90 insertions(+)
>  create mode 100644 package/rauc/Config.in
>  create mode 100644 package/rauc/Config.in.host
>  create mode 100644 package/rauc/rauc.hash
>  create mode 100644 package/rauc/rauc.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9e421f4..7600cb5 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -95,6 +95,9 @@ F:    package/python-scandir/
>  F:     package/python-simplegeneric/
>  F:     package/python-traitlets/
>
> +N:  Andrey Yurovsky <yurovsky@gmail.com>
> +F:  package/rauc
> +
>  N:     Andy Kennedy <andy.kennedy@adtran.com>
>  F:     package/libunwind/
>
> diff --git a/package/Config.in b/package/Config.in
> index f69f67f..fdfcd02 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1865,6 +1865,7 @@ menu "System tools"
>         source "package/psmisc/Config.in"
>         source "package/pwgen/Config.in"
>         source "package/quota/Config.in"
> +       source "package/rauc/Config.in"
>         source "package/rsyslog/Config.in"
>         source "package/runc/Config.in"
>         source "package/s6/Config.in"
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 38f919a..0932b9f 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -39,6 +39,7 @@ menu "Host utilities"
>         source "package/python-lxml/Config.in.host"
>         source "package/qemu/Config.in.host"
>         source "package/raspberrypi-usbboot/Config.in.host"
> +       source "package/rauc/Config.in.host"
>         source "package/s6-rc/Config.in.host"
>         source "package/sam-ba/Config.in.host"
>         source "package/squashfs/Config.in.host"
> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
> new file mode 100644
> index 0000000..f63ab54
> --- /dev/null
> +++ b/package/rauc/Config.in
> @@ -0,0 +1,37 @@
> +config BR2_PACKAGE_RAUC
> +       bool "rauc"
> +       depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> +       depends on BR2_USE_MMU # glib2
> +       depends on BR2_USE_WCHAR # glib2
> +       select BR2_PACKAGE_LIBGLIB2
> +       select BR2_PACKAGE_OPENSSL
> +       select BR2_PACKAGE_DBUS # run-time dependency
> +       help
> +         RAUC is the Robust Auto-Update Controller developed by
> +         Penguintronix. It supports updating embedded Linux
> +         systems over the network or from disks and provides a
> +         d-bus interface.
> +
> +         http://rauc.io/
> +
> +if BR2_PACKAGE_RAUC
> +
> +config BR2_PACKAGE_RAUC_NETWORK
> +       bool "network support"
> +       select BR2_PACKAGE_LIBCURL
> +       help
> +         This option enables support for updating firmware over
> +         the network using libcurl.
> +
> +config BR2_PACKAGE_RAUC_JSON
> +       bool "JSON output support"
> +       select BR2_PACKAGE_JSON_GLIB
> +       help
> +         This option enables support for providing output in
> +         JSON format.
> +
> +endif
> +
> +comment "rauc needs a toolchain w/ wchar, threads"
> +       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +       depends on BR2_USE_MMU
> diff --git a/package/rauc/Config.in.host b/package/rauc/Config.in.host
> new file mode 100644
> index 0000000..e45406e
> --- /dev/null
> +++ b/package/rauc/Config.in.host
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_HOST_RAUC
> +       bool "host rauc"
> +       help
> +         RAUC is the Robust Auto-Update Controller developed by
> +         Penguintronix. Enable this option to build the rauc
> +         host tool which may be used to generate firmware
> +         bundles that are handled by the target rauc service.
> +
> +         http://rauc.io/
> diff --git a/package/rauc/rauc.hash b/package/rauc/rauc.hash
> new file mode 100644
> index 0000000..78c3e27
> --- /dev/null
> +++ b/package/rauc/rauc.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated, after verifying against
> +# https://github.com/rauc/rauc/releases/download/v0.1.1/rauc-0.1.1.tar.xz.asc
> +sha256 d2901d493f1d3210aef6411e83b02edac3a678d6d825d71a1c61b5b6afc7e478 rauc-0.1.1.tar.xz
> diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
> new file mode 100644
> index 0000000..12819d9
> --- /dev/null
> +++ b/package/rauc/rauc.mk
> @@ -0,0 +1,36 @@
> +################################################################################
> +#
> +# rauc
> +#
> +################################################################################
> +
> +RAUC_VERSION = 0.1.1
> +RAUC_SITE = https://github.com/rauc/rauc/releases/download/v$(RAUC_VERSION)
> +RAUC_SOURCE = rauc-$(RAUC_VERSION).tar.xz
> +RAUC_LICENSE = LGPL-2.1
> +RAUC_DEPENDENCIES = host-pkgconf openssl libglib2
> +
> +ifeq ($(BR2_PACKAGE_RAUC_NETWORK),y)
> +RAUC_CONF_OPTS += --enable-network
> +RAUC_DEPENDENCIES += libcurl
> +else
> +RAUC_CONF_OPTS += --disable-network
> +endif
> +
> +ifeq ($(BR2_PACKAGE_RAUC_JSON),y)
> +RAUC_CONF_OPTS += --enable-json
> +RAUC_DEPENDENCIES += json-glib
> +else
> +RAUC_CONF_OPTS += --disable-json
> +endif
> +
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +# configure uses pkg-config --variable=systemdsystemunitdir systemd
> +RAUC_DEPENDENCIES += systemd
> +endif
> +
> +HOST_RAUC_DEPENDENCIES = host-pkgconf
> +HOST_RAUC_CONF_OPTS += --disable-network --disable-json --disable-service
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 2.9.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2] rauc: new package
  2017-06-28 21:40 ` [Buildroot] [PATCH v2] " Andrey Yurovsky
  2017-06-29  5:20   ` Yegor Yefremov
@ 2017-06-29 18:58   ` Peter Seiderer
  2017-06-29 19:08     ` [Buildroot] [PATCH v3] " Andrey Yurovsky
  1 sibling, 1 reply; 10+ messages in thread
From: Peter Seiderer @ 2017-06-29 18:58 UTC (permalink / raw)
  To: buildroot

Hello Andrey,

On Wed, 28 Jun 2017 14:40:09 -0700, Andrey Yurovsky <yurovsky@gmail.com> wrote:

> RAUC is the Robust Auto-Update Controller developed by the folks at
> Penguintronix. It supports updating embedded systems from the network

Typo: s/Penguintronix/Pengutronix/ and some more occurrences below...

Regards,
Peter

 
> (ex: HawkBit) or from a disk and provides a d-bus interface.
> 
> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
> ---
>  DEVELOPERS                  |  3 +++
>  package/Config.in           |  1 +
>  package/Config.in.host      |  1 +
>  package/rauc/Config.in      | 37 +++++++++++++++++++++++++++++++++++++
>  package/rauc/Config.in.host |  9 +++++++++
>  package/rauc/rauc.hash      |  3 +++
>  package/rauc/rauc.mk        | 36 ++++++++++++++++++++++++++++++++++++
>  7 files changed, 90 insertions(+)
>  create mode 100644 package/rauc/Config.in
>  create mode 100644 package/rauc/Config.in.host
>  create mode 100644 package/rauc/rauc.hash
>  create mode 100644 package/rauc/rauc.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9e421f4..7600cb5 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -95,6 +95,9 @@ F:	package/python-scandir/
>  F:	package/python-simplegeneric/
>  F:	package/python-traitlets/
>  
> +N:  Andrey Yurovsky <yurovsky@gmail.com>
> +F:  package/rauc
> +
>  N:	Andy Kennedy <andy.kennedy@adtran.com>
>  F:	package/libunwind/
>  
> diff --git a/package/Config.in b/package/Config.in
> index f69f67f..fdfcd02 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1865,6 +1865,7 @@ menu "System tools"
>  	source "package/psmisc/Config.in"
>  	source "package/pwgen/Config.in"
>  	source "package/quota/Config.in"
> +	source "package/rauc/Config.in"
>  	source "package/rsyslog/Config.in"
>  	source "package/runc/Config.in"
>  	source "package/s6/Config.in"
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 38f919a..0932b9f 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -39,6 +39,7 @@ menu "Host utilities"
>  	source "package/python-lxml/Config.in.host"
>  	source "package/qemu/Config.in.host"
>  	source "package/raspberrypi-usbboot/Config.in.host"
> +	source "package/rauc/Config.in.host"
>  	source "package/s6-rc/Config.in.host"
>  	source "package/sam-ba/Config.in.host"
>  	source "package/squashfs/Config.in.host"
> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
> new file mode 100644
> index 0000000..f63ab54
> --- /dev/null
> +++ b/package/rauc/Config.in
> @@ -0,0 +1,37 @@
> +config BR2_PACKAGE_RAUC
> +	bool "rauc"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> +	depends on BR2_USE_MMU # glib2
> +	depends on BR2_USE_WCHAR # glib2
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_DBUS # run-time dependency
> +	help
> +	  RAUC is the Robust Auto-Update Controller developed by
> +	  Penguintronix. It supports updating embedded Linux
> +	  systems over the network or from disks and provides a
> +	  d-bus interface.
> +
> +	  http://rauc.io/
> +
> +if BR2_PACKAGE_RAUC
> +
> +config BR2_PACKAGE_RAUC_NETWORK
> +	bool "network support"
> +	select BR2_PACKAGE_LIBCURL
> +	help
> +	  This option enables support for updating firmware over
> +	  the network using libcurl.
> +
> +config BR2_PACKAGE_RAUC_JSON
> +	bool "JSON output support"
> +	select BR2_PACKAGE_JSON_GLIB
> +	help
> +	  This option enables support for providing output in
> +	  JSON format.
> +
> +endif
> +
> +comment "rauc needs a toolchain w/ wchar, threads"
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_USE_MMU
> diff --git a/package/rauc/Config.in.host b/package/rauc/Config.in.host
> new file mode 100644
> index 0000000..e45406e
> --- /dev/null
> +++ b/package/rauc/Config.in.host
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_HOST_RAUC
> +	bool "host rauc"
> +	help
> +	  RAUC is the Robust Auto-Update Controller developed by
> +	  Penguintronix. Enable this option to build the rauc
> +	  host tool which may be used to generate firmware
> +	  bundles that are handled by the target rauc service.
> +
> +	  http://rauc.io/
> diff --git a/package/rauc/rauc.hash b/package/rauc/rauc.hash
> new file mode 100644
> index 0000000..78c3e27
> --- /dev/null
> +++ b/package/rauc/rauc.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated, after verifying against
> +# https://github.com/rauc/rauc/releases/download/v0.1.1/rauc-0.1.1.tar.xz.asc
> +sha256 d2901d493f1d3210aef6411e83b02edac3a678d6d825d71a1c61b5b6afc7e478 rauc-0.1.1.tar.xz
> diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
> new file mode 100644
> index 0000000..12819d9
> --- /dev/null
> +++ b/package/rauc/rauc.mk
> @@ -0,0 +1,36 @@
> +################################################################################
> +#
> +# rauc
> +#
> +################################################################################
> +
> +RAUC_VERSION = 0.1.1
> +RAUC_SITE = https://github.com/rauc/rauc/releases/download/v$(RAUC_VERSION)
> +RAUC_SOURCE = rauc-$(RAUC_VERSION).tar.xz
> +RAUC_LICENSE = LGPL-2.1
> +RAUC_DEPENDENCIES = host-pkgconf openssl libglib2
> +
> +ifeq ($(BR2_PACKAGE_RAUC_NETWORK),y)
> +RAUC_CONF_OPTS += --enable-network
> +RAUC_DEPENDENCIES += libcurl
> +else
> +RAUC_CONF_OPTS += --disable-network
> +endif
> +
> +ifeq ($(BR2_PACKAGE_RAUC_JSON),y)
> +RAUC_CONF_OPTS += --enable-json
> +RAUC_DEPENDENCIES += json-glib
> +else
> +RAUC_CONF_OPTS += --disable-json
> +endif
> +
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +# configure uses pkg-config --variable=systemdsystemunitdir systemd
> +RAUC_DEPENDENCIES += systemd
> +endif
> +
> +HOST_RAUC_DEPENDENCIES = host-pkgconf
> +HOST_RAUC_CONF_OPTS += --disable-network --disable-json --disable-service
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v3] rauc: new package
  2017-06-29 18:58   ` Peter Seiderer
@ 2017-06-29 19:08     ` Andrey Yurovsky
  2017-06-30 10:15       ` Arnout Vandecappelle
  2017-07-01 11:17       ` Thomas Petazzoni
  0 siblings, 2 replies; 10+ messages in thread
From: Andrey Yurovsky @ 2017-06-29 19:08 UTC (permalink / raw)
  To: buildroot

RAUC is the Robust Auto-Update Controller developed by the folks at
Pengutronix. It supports updating embedded systems from the network
(ex: HawkBit) or from a disk and provides a d-bus interface.

Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 DEVELOPERS                  |  3 +++
 package/Config.in           |  1 +
 package/Config.in.host      |  1 +
 package/rauc/Config.in      | 37 +++++++++++++++++++++++++++++++++++++
 package/rauc/Config.in.host |  9 +++++++++
 package/rauc/rauc.hash      |  3 +++
 package/rauc/rauc.mk        | 36 ++++++++++++++++++++++++++++++++++++
 7 files changed, 90 insertions(+)
 create mode 100644 package/rauc/Config.in
 create mode 100644 package/rauc/Config.in.host
 create mode 100644 package/rauc/rauc.hash
 create mode 100644 package/rauc/rauc.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 9e421f4..7600cb5 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -95,6 +95,9 @@ F:	package/python-scandir/
 F:	package/python-simplegeneric/
 F:	package/python-traitlets/
 
+N:  Andrey Yurovsky <yurovsky@gmail.com>
+F:  package/rauc
+
 N:	Andy Kennedy <andy.kennedy@adtran.com>
 F:	package/libunwind/
 
diff --git a/package/Config.in b/package/Config.in
index f69f67f..fdfcd02 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1865,6 +1865,7 @@ menu "System tools"
 	source "package/psmisc/Config.in"
 	source "package/pwgen/Config.in"
 	source "package/quota/Config.in"
+	source "package/rauc/Config.in"
 	source "package/rsyslog/Config.in"
 	source "package/runc/Config.in"
 	source "package/s6/Config.in"
diff --git a/package/Config.in.host b/package/Config.in.host
index 38f919a..0932b9f 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -39,6 +39,7 @@ menu "Host utilities"
 	source "package/python-lxml/Config.in.host"
 	source "package/qemu/Config.in.host"
 	source "package/raspberrypi-usbboot/Config.in.host"
+	source "package/rauc/Config.in.host"
 	source "package/s6-rc/Config.in.host"
 	source "package/sam-ba/Config.in.host"
 	source "package/squashfs/Config.in.host"
diff --git a/package/rauc/Config.in b/package/rauc/Config.in
new file mode 100644
index 0000000..6433b82
--- /dev/null
+++ b/package/rauc/Config.in
@@ -0,0 +1,37 @@
+config BR2_PACKAGE_RAUC
+	bool "rauc"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
+	depends on BR2_USE_MMU # glib2
+	depends on BR2_USE_WCHAR # glib2
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_DBUS # run-time dependency
+	help
+	  RAUC is the Robust Auto-Update Controller developed by
+	  Pengutronix. It supports updating embedded Linux
+	  systems over the network or from disks and provides a
+	  d-bus interface.
+
+	  http://rauc.io/
+
+if BR2_PACKAGE_RAUC
+
+config BR2_PACKAGE_RAUC_NETWORK
+	bool "network support"
+	select BR2_PACKAGE_LIBCURL
+	help
+	  This option enables support for updating firmware over
+	  the network using libcurl.
+
+config BR2_PACKAGE_RAUC_JSON
+	bool "JSON output support"
+	select BR2_PACKAGE_JSON_GLIB
+	help
+	  This option enables support for providing output in
+	  JSON format.
+
+endif
+
+comment "rauc needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_MMU
diff --git a/package/rauc/Config.in.host b/package/rauc/Config.in.host
new file mode 100644
index 0000000..a58685a
--- /dev/null
+++ b/package/rauc/Config.in.host
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_HOST_RAUC
+	bool "host rauc"
+	help
+	  RAUC is the Robust Auto-Update Controller developed by
+	  Pengutronix. Enable this option to build the rauc
+	  host tool which may be used to generate firmware
+	  bundles that are handled by the target rauc service.
+
+	  http://rauc.io/
diff --git a/package/rauc/rauc.hash b/package/rauc/rauc.hash
new file mode 100644
index 0000000..78c3e27
--- /dev/null
+++ b/package/rauc/rauc.hash
@@ -0,0 +1,3 @@
+# Locally calculated, after verifying against
+# https://github.com/rauc/rauc/releases/download/v0.1.1/rauc-0.1.1.tar.xz.asc
+sha256 d2901d493f1d3210aef6411e83b02edac3a678d6d825d71a1c61b5b6afc7e478 rauc-0.1.1.tar.xz
diff --git a/package/rauc/rauc.mk b/package/rauc/rauc.mk
new file mode 100644
index 0000000..12819d9
--- /dev/null
+++ b/package/rauc/rauc.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# rauc
+#
+################################################################################
+
+RAUC_VERSION = 0.1.1
+RAUC_SITE = https://github.com/rauc/rauc/releases/download/v$(RAUC_VERSION)
+RAUC_SOURCE = rauc-$(RAUC_VERSION).tar.xz
+RAUC_LICENSE = LGPL-2.1
+RAUC_DEPENDENCIES = host-pkgconf openssl libglib2
+
+ifeq ($(BR2_PACKAGE_RAUC_NETWORK),y)
+RAUC_CONF_OPTS += --enable-network
+RAUC_DEPENDENCIES += libcurl
+else
+RAUC_CONF_OPTS += --disable-network
+endif
+
+ifeq ($(BR2_PACKAGE_RAUC_JSON),y)
+RAUC_CONF_OPTS += --enable-json
+RAUC_DEPENDENCIES += json-glib
+else
+RAUC_CONF_OPTS += --disable-json
+endif
+
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+# configure uses pkg-config --variable=systemdsystemunitdir systemd
+RAUC_DEPENDENCIES += systemd
+endif
+
+HOST_RAUC_DEPENDENCIES = host-pkgconf
+HOST_RAUC_CONF_OPTS += --disable-network --disable-json --disable-service
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v3] rauc: new package
  2017-06-29 19:08     ` [Buildroot] [PATCH v3] " Andrey Yurovsky
@ 2017-06-30 10:15       ` Arnout Vandecappelle
  2017-07-01 11:17       ` Thomas Petazzoni
  1 sibling, 0 replies; 10+ messages in thread
From: Arnout Vandecappelle @ 2017-06-30 10:15 UTC (permalink / raw)
  To: buildroot

 Hi Andrey,

 Thank you for the quick turnaround on this patch!

On 29-06-17 21:08, Andrey Yurovsky wrote:
> RAUC is the Robust Auto-Update Controller developed by the folks at
> Pengutronix. It supports updating embedded systems from the network
> (ex: HawkBit) or from a disk and provides a d-bus interface.
> 
> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---

 For future submissions: it is convenient to put a patch history in the commit
log. Put it below a --- line, which causes git-am to remove it when it is
committed to the repository. So you could put here:

---
v2 -> v3:
 - Correct spelling of Pengutronix (Peter)

v1 -> v2:
 - Add myself to DEVELOPERS (Yegor)
 - Add Config.in.host option (Yegor)
 - Add inclusion in package/Config.in and package/Config.in.host (Arnout)
 - Use uploaded tarball instead of automatic one (Arnout)
 - Verified signature of tarball (Arnout)
 - Fix license (LGPL-2.1 instead of GPL-2.1) (Arnout)
 - Convert libcurl and json-glib to automatic dependencies (Arnout)
 - Remove dbus-glib and util-linux(libmount) dependencies (Arnout)
 - Mark dbus as a runtime dependency

[I reconstructed this history because I need it to be able to review the patch.]


 Also, it's convenient to add the people who commented on the patch in Cc, to
motivate them to look at your new version.

 Obviously, no need to spin a v4 for the above. I have a few small fixes still
below, but they can probably be done while applying, so:

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


>  DEVELOPERS                  |  3 +++
>  package/Config.in           |  1 +
>  package/Config.in.host      |  1 +
>  package/rauc/Config.in      | 37 +++++++++++++++++++++++++++++++++++++
>  package/rauc/Config.in.host |  9 +++++++++
>  package/rauc/rauc.hash      |  3 +++
>  package/rauc/rauc.mk        | 36 ++++++++++++++++++++++++++++++++++++
>  7 files changed, 90 insertions(+)
>  create mode 100644 package/rauc/Config.in
>  create mode 100644 package/rauc/Config.in.host
>  create mode 100644 package/rauc/rauc.hash
>  create mode 100644 package/rauc/rauc.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9e421f4..7600cb5 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -95,6 +95,9 @@ F:	package/python-scandir/
>  F:	package/python-simplegeneric/
>  F:	package/python-traitlets/
>  
> +N:  Andrey Yurovsky <yurovsky@gmail.com>
> +F:  package/rauc

 Although the DEVELOPERS syntax doesn't strictly require it, we normally put a /
at the end to make it clear it's a directory.

> +
>  N:	Andy Kennedy <andy.kennedy@adtran.com>
>  F:	package/libunwind/
>  

[snip]
> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
> new file mode 100644
> index 0000000..6433b82
> --- /dev/null
> +++ b/package/rauc/Config.in
> @@ -0,0 +1,37 @@
> +config BR2_PACKAGE_RAUC
> +	bool "rauc"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> +	depends on BR2_USE_MMU # glib2
> +	depends on BR2_USE_WCHAR # glib2
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_DBUS # run-time dependency
> +	help
> +	  RAUC is the Robust Auto-Update Controller developed by
> +	  Pengutronix. It supports updating embedded Linux
> +	  systems over the network or from disks and provides a
> +	  d-bus interface.

 Proper spelling is D-Bus or DBus.

> +
> +	  http://rauc.io/
> +
> +if BR2_PACKAGE_RAUC
> +
> +config BR2_PACKAGE_RAUC_NETWORK
> +	bool "network support"
> +	select BR2_PACKAGE_LIBCURL
> +	help
> +	  This option enables support for updating firmware over
> +	  the network using libcurl.
> +
> +config BR2_PACKAGE_RAUC_JSON
> +	bool "JSON output support"
> +	select BR2_PACKAGE_JSON_GLIB
> +	help
> +	  This option enables support for providing output in
> +	  JSON format.

 We don't usually add sub-options for the different package configuration
options. However, in this case it does indeed make sense:
- they are not really easy to discover for the user;
- it's unlikely that these options will change much in future versions.


 Regards,
 Arnout

> +
> +endif
> +
> +comment "rauc needs a toolchain w/ wchar, threads"
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_USE_MMU
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v3] rauc: new package
  2017-06-29 19:08     ` [Buildroot] [PATCH v3] " Andrey Yurovsky
  2017-06-30 10:15       ` Arnout Vandecappelle
@ 2017-07-01 11:17       ` Thomas Petazzoni
  1 sibling, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2017-07-01 11:17 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 29 Jun 2017 12:08:11 -0700, Andrey Yurovsky wrote:

> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9e421f4..7600cb5 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -95,6 +95,9 @@ F:	package/python-scandir/
>  F:	package/python-simplegeneric/
>  F:	package/python-traitlets/
>  
> +N:  Andrey Yurovsky <yurovsky@gmail.com>
> +F:  package/rauc

In addition to what Arnout said, indentation was wrong here, we use a
tab to separate the field name (N:, F:) from its contents.

The rest looked good to me, so I've applied your patch. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-07-01 11:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28  6:07 [Buildroot] [PATCH] rauc: new package Andrey Yurovsky
2017-06-28  6:44 ` Yegor Yefremov
2017-06-28 19:59 ` Arnout Vandecappelle
2017-06-28 20:34   ` Andrey Yurovsky
2017-06-28 21:40 ` [Buildroot] [PATCH v2] " Andrey Yurovsky
2017-06-29  5:20   ` Yegor Yefremov
2017-06-29 18:58   ` Peter Seiderer
2017-06-29 19:08     ` [Buildroot] [PATCH v3] " Andrey Yurovsky
2017-06-30 10:15       ` Arnout Vandecappelle
2017-07-01 11:17       ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.