From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3DFC433FE for ; Fri, 11 Dec 2020 02:07:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60C6B23E52 for ; Fri, 11 Dec 2020 02:07:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388787AbgLKCHY (ORCPT ); Thu, 10 Dec 2020 21:07:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387840AbgLKCG5 (ORCPT ); Thu, 10 Dec 2020 21:06:57 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0012EC0613CF for ; Thu, 10 Dec 2020 18:06:16 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id d189so8130629oig.11 for ; Thu, 10 Dec 2020 18:06:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f9RSyWHl3Z1A9igwbyiPb+HKfrL5RmW/7S10//clEIc=; b=e2yI+Iplee0/vctTdk8XUsTgKJ7vxYwhrkV2a5JcjCHSrCc2JRRAb64vCVfsV7yo78 B0ZNIum9QeuLW3JNwUuaZG2g3bxfLuTUkStSp4GcrnHR6b8aD2Qmu4beiT2tlp1Xk2uj i85VZRIc2PPfL0mUEg+9jE+n36rrkc2HX6ZuTgjxVFN0X4I11Z8HwAa/kA9GZWqcHwBk l77av4ppjbBvFERMzXJyIApvE62pju92vDXmohXXDF5Vqi+KkqV8HH8t8qdhWjlxmMJS D8KLMcTacHU/v/6HJSMsAdX8qKruqZqekPjW2AfUob9e1Imxo4+qvUVHofsCjxYLg1PQ 9mEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f9RSyWHl3Z1A9igwbyiPb+HKfrL5RmW/7S10//clEIc=; b=BXrgR7gJ392nryfdTMKq5oWapmVLNYMKRYiZQO6UEeVgGRAHw/dtQiA7Du0b5RleBp VLwxEESkeMDLqXiwKkSu+qPuWTeozzzo6TVSLItiNrqLRK2d4OajngZEivmRcpANEGvz p23zhcDUnY7WgK9/Nl7lIEfqYexx8+KjF7oQflxVHMIa0WJ4cnBbEW6rUcDPTqV+y1m5 0iJ0Pxu3cC7fLTTItKd+6BRKfpLJqH9a++kzgc6AUZU9MMXY8t4EoDSyV674RmO9Naji f+n8UBIVlAFY0dG+N1knoAWP4KvSB0uZiwSc5451lhSFeoW4Ng1rxFc58EYp5TGNveEu rlpA== X-Gm-Message-State: AOAM532FDMr39tM64XGmo6m3ACfm7t0PGAvdBflDgnr2AfkNZ3XbmXgD 6e4MBm8c8ISgjKhImoNOAUydYDqUUFYZYNgznTrrEQ== X-Google-Smtp-Source: ABdhPJzs0/lE6TSq5HnlKNF+j99NifDWVBECFpzx5ngO00Z+i5z0ERHOjWxD76IkEiusio5CVOYgPLUR+7AXcIsYuE0= X-Received: by 2002:aca:5e03:: with SMTP id s3mr7651344oib.125.1607652376343; Thu, 10 Dec 2020 18:06:16 -0800 (PST) MIME-Version: 1.0 References: <20201210092853.303-1-wangzhiqiang.bj@bytedance.com> In-Reply-To: From: Lei Yu Date: Fri, 11 Dec 2020 10:06:05 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 1/3] misc: aspeed: Add Aspeed UART routing control driver. To: Oskar Senft Cc: Greg Kroah-Hartman , John Wang , Lotus Xu , Yong Li , Vernon Mauery , Joel Stanley , Andrew Jeffery , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "open list:DOCUMENTATION" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 8:33 PM Oskar Senft wrote: > > The purpose of this driver is to allow manipulation of the UART routing a= t runtime. Setting the routing in the DTS would obviously not allow that. > > From what I remember, I used am existing unrelated driver as template. Ap= ologies for using the wrong APIs - I literally just followed what I had see= n elsewhere. > > Since posting this driver, we found that while it solved our initial use = case, that use case has evolved. We're now using Aspeed's VUART where bytes= are routed "manually" (i.e. copied between devices) rather than in hardwar= e. So I don't need this driver anymore. > > If it's still useful to anyone, please take ownership and modify it as ne= eded to be able to submit it. I'm still happy to keep an eye on it and help= explain its purpose. > The driver is useful for our system, and it's used in intel-openbmc as well= . We (John and I work for the same employer) have the chance to use Andrew Jefery's ["bmc-misc" driver][1] to configure the various registers in dts to setup the UART routing, but that driver was not accepted by upstream. So we end up sending this patch here for upstream's comment. If it's considered not a good option, we will have to keep it downstream. [1] https://lore.kernel.org/openbmc/20180711053122.30773-1-andrew@aj.id.au/ --=20 BRs, Lei YU From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7EF7C4361B for ; Fri, 11 Dec 2020 02:07:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51ACB23E52 for ; Fri, 11 Dec 2020 02:07:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51ACB23E52 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7A1xb+LczUtHp/5/LdAuyoIpD4LwZgq5sdrux3bHg4s=; b=KN928V9n6XYQWTi4SpNwAREzg rd4QZ/mCQmALB75iD44jTCuQiPMwUGQOZ8cctg66ouJ3a08djL9V2XRourV7Bmnr1GBsG5MSomgfs 1o1NuW1cgrJ7RO4+i5L5bmIXkCXlofcOAi/Co0KXg4YYVl+oI8pwv8vj6sNxx3bX8oyd5L06BS4X2 YsTAVmtU+y/roVSeIBJkcM6SLXbkvbaXQuB6EKhB4qtRinunz15i2rjHFX8blFbptAC7DOUanzeYO 81aetWLN+bJ8cx9xhAS2J6uFWlx+p+ZISn9KheTWGbSc6cmKzJsZ/yjsvumlUnBekp6IYh3zIoVc4 uqtwf1tsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knXp9-0005fs-Sc; Fri, 11 Dec 2020 02:06:23 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knXp6-0005et-Bj for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2020 02:06:21 +0000 Received: by mail-oi1-x243.google.com with SMTP id l207so8176096oib.4 for ; Thu, 10 Dec 2020 18:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f9RSyWHl3Z1A9igwbyiPb+HKfrL5RmW/7S10//clEIc=; b=e2yI+Iplee0/vctTdk8XUsTgKJ7vxYwhrkV2a5JcjCHSrCc2JRRAb64vCVfsV7yo78 B0ZNIum9QeuLW3JNwUuaZG2g3bxfLuTUkStSp4GcrnHR6b8aD2Qmu4beiT2tlp1Xk2uj i85VZRIc2PPfL0mUEg+9jE+n36rrkc2HX6ZuTgjxVFN0X4I11Z8HwAa/kA9GZWqcHwBk l77av4ppjbBvFERMzXJyIApvE62pju92vDXmohXXDF5Vqi+KkqV8HH8t8qdhWjlxmMJS D8KLMcTacHU/v/6HJSMsAdX8qKruqZqekPjW2AfUob9e1Imxo4+qvUVHofsCjxYLg1PQ 9mEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f9RSyWHl3Z1A9igwbyiPb+HKfrL5RmW/7S10//clEIc=; b=RVivHBcPN5kOJM9iLZRph0QpYydEAoaUeWgh2crVZP9PS8EbnblN9W1QKaogTm4lNw da6j2EqplVrd4Q8mnu9rC0Hf05b5kXwf7RkL85uRIOarB64oSmJ68PFcdkni1yR9FuHe WYo6sPoSFcrbi1CxK5CWb1aNRn4yrPjRX9TD0n2lWJhXLadHScVL5UI3cNQ3iPvsXRrk R2LZFaNQ1t/1dM2Zc6F0mO3hDlBCDkvTmcHyNHJ/r/hgt/dEqndOtLD5YNwatQccUFIT 6JnYVpDoPXOja+L/L04cOR95g5aFrV8Oeq8cSnddYyqqo7pmUYMjy6dFwfRtrzMu8bOJ 9z0g== X-Gm-Message-State: AOAM531+EbgdPwtLnStq2ihCurh2H++eYHMpZnSbsAi7H1rp5z3MzmPC FaHC7G20RDakXNlTjLMPVX9Rwon2jPbUOTXHRsUsBA== X-Google-Smtp-Source: ABdhPJzs0/lE6TSq5HnlKNF+j99NifDWVBECFpzx5ngO00Z+i5z0ERHOjWxD76IkEiusio5CVOYgPLUR+7AXcIsYuE0= X-Received: by 2002:aca:5e03:: with SMTP id s3mr7651344oib.125.1607652376343; Thu, 10 Dec 2020 18:06:16 -0800 (PST) MIME-Version: 1.0 References: <20201210092853.303-1-wangzhiqiang.bj@bytedance.com> In-Reply-To: From: Lei Yu Date: Fri, 11 Dec 2020 10:06:05 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 1/3] misc: aspeed: Add Aspeed UART routing control driver. To: Oskar Senft X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201210_210620_545339_9A2D2238 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:ARM/ASPEED MACHINE SUPPORT" , Arnd Bergmann , Jonathan Corbet , Andrew Jeffery , Greg Kroah-Hartman , Dragan Cvetic , "open list:DOCUMENTATION" , Yong Li , open list , John Wang , Joel Stanley , Vernon Mauery , Derek Kiernan , Lotus Xu , "moderated list:ARM/ASPEED MACHINE SUPPORT" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 10, 2020 at 8:33 PM Oskar Senft wrote: > > The purpose of this driver is to allow manipulation of the UART routing at runtime. Setting the routing in the DTS would obviously not allow that. > > From what I remember, I used am existing unrelated driver as template. Apologies for using the wrong APIs - I literally just followed what I had seen elsewhere. > > Since posting this driver, we found that while it solved our initial use case, that use case has evolved. We're now using Aspeed's VUART where bytes are routed "manually" (i.e. copied between devices) rather than in hardware. So I don't need this driver anymore. > > If it's still useful to anyone, please take ownership and modify it as needed to be able to submit it. I'm still happy to keep an eye on it and help explain its purpose. > The driver is useful for our system, and it's used in intel-openbmc as well. We (John and I work for the same employer) have the chance to use Andrew Jefery's ["bmc-misc" driver][1] to configure the various registers in dts to setup the UART routing, but that driver was not accepted by upstream. So we end up sending this patch here for upstream's comment. If it's considered not a good option, we will have to keep it downstream. [1] https://lore.kernel.org/openbmc/20180711053122.30773-1-andrew@aj.id.au/ -- BRs, Lei YU _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel