From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 962A2C433B4 for ; Fri, 16 Apr 2021 07:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74DB16117A for ; Fri, 16 Apr 2021 07:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239670AbhDPHfm (ORCPT ); Fri, 16 Apr 2021 03:35:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239201AbhDPHfk (ORCPT ); Fri, 16 Apr 2021 03:35:40 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB0FC061574 for ; Fri, 16 Apr 2021 00:35:13 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id n184so948903oia.12 for ; Fri, 16 Apr 2021 00:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tJD4Wffy8UFddOPkdi2YXR6U7i7vtfGmTFUKn6fdSpQ=; b=G+yNnwMnLDElOBnF2B2+GxANp7XTkHj2DLoP/s3CNBCAi6w7gglXHy8oFGuZ6Qp2Qm OkeIpoc212lPbkc1hyJkm4A51KOcLo2OlS6K9uJ5dEF7gXETSsxiw5XJDsJgsXb3s2oE lTp4C8qSueJ08ORlfJ2m5xth4v57F+vKbyegAMM9luRp1wBe//U+v9gUr3+lZXdesng9 WwQpdi/QHfafpxLKTrJMbumRxFxzlDgN3ecEtb/fdhrAiLMY2USct0BXoIde0q8IFcLB IWa4uZRPhHVPfVLPtQM/ta90PyYBStMFJkJZJ9KNDBnVYP5W6ET3vQKd71EAnaMFp0Hu 7rPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tJD4Wffy8UFddOPkdi2YXR6U7i7vtfGmTFUKn6fdSpQ=; b=heuAM+B3lbVv3OFir37gbOLsp5JL0ZxZhIySOTiTthwGSCz921g2leMh+/TGTIBBOh 5E/A2Wxh1BtPZMGuM/w6ishdQXn15fy3yz1+SBGRh86y7I4lyFvftnXe9Do+vugyEwaz wjrmJGfV51spqq/gWgDTdYF08KDZq+zK6MBrTFKwKBC1+lB07Erli4K9LOvlFFxGP3KB Imh2+SvYDJmrvBUZANVN/vAEzMn0fb9azHOTGr0y+GOPz8qEQtBv3qYFi/21tmht6qTY stHxCG7W0d3OFrz9nhLAlHRGiQuwPiz5qWQ8i5x9lKhuyjlwGJzBcjetaBxViA42grgO DKdA== X-Gm-Message-State: AOAM530WbfQa5YeKMiEl3ihmORTPATBiA3DbWZF3vuegbTqquuvlPo2U eTCYq/mR4Ldnw16xQeIbTcajmj01OQSC0CLaf7uFyg== X-Google-Smtp-Source: ABdhPJyyb5uCrc4pETT//wgeijjcWgZHJwhyFG2hghIXA58CpkcDpTKOEaIX3WAcbBOMndCKUQq/lHReczEGRuQm9ms= X-Received: by 2002:a05:6808:d50:: with SMTP id w16mr5521425oik.28.1618558512880; Fri, 16 Apr 2021 00:35:12 -0700 (PDT) MIME-Version: 1.0 References: <20210316085932.2601-1-troy_lee@aspeedtech.com> In-Reply-To: From: Lei Yu Date: Fri, 16 Apr 2021 15:35:01 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v1] ARM: dts: Fix 64MiB OpenBMC flash layout and aspeed-ast2600-evb.dts To: Joel Stanley Cc: Troy Lee , John Wang , Rob Herring , Andrew Jeffery , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , leetroy@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 11:03 AM Joel Stanley wrote: > > On Tue, 16 Mar 2021 at 08:59, Troy Lee wrote: > > > > Aspeed AST2600 u-boot requires 600KiB+ flash space. Sharing the same > > openbmc-flash-layout-64.dtsi requires to resize the flash partition. > > > > The updated flash layout as follows: > > - u-boot: 896 KiB > > - u-boot-env: 128 KiB > > - kernel: 9MiB > > - rofs: 32 MiB > > - rwfs: 22 MiB > > Changing the 64MB layout will break the systems that are already using > this layout. I'll get the Bytedance people to chime in, as theirs is > the only system using this layout so far. > > John, Lei? Because the kernel's offset is updated, several other changes are required: 1. The related offsets, which is already sent to https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/39343 2. The u-boot patch to update the `bootm` address and make sure it only applies to the 64MiB layout. Without the above two changes, I would suggest holding the merge. -- BRs, Lei YU From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38DCC433B4 for ; Fri, 16 Apr 2021 07:58:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 146D66113D for ; Fri, 16 Apr 2021 07:58:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 146D66113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fY+YM4vuUGOPhjs04Jewryn5TgKrhlqJV5dUzF8KKCk=; b=Z1xMfYRmT6Raju41DglDw7TKb Sc/lmKUI5RqA6PdMmrkPa8xt1GGxVNyKTj6FCrgc56dF8p1DVlW/6dJ4kJYSy45NTcPU2TasKkBkQ VnELE9ptAh2rqju2es5oK5bkd/vGgdOPTR8PYzJ+Sryrw0R4OCTatPiOu2Dmxj+HS6W3xqA1qiOTC ct4RmIUVH9VoGGp25ojfdhYsKmfdITjLzMoQCySzWDOgUR5T0UUDPeH2cj2a7vynBivG23R0CGk1D a/IczS05p3WaBUyUYngciwpADN9EfsPRweg26kCGbgtism3y0ueoE0rREeI03pMB3po7U2vzvTiG9 mdnJNPwhw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXJKT-001G3a-K0; Fri, 16 Apr 2021 07:55:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXJ0Y-001Cj4-Ks for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 07:35:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tJD4Wffy8UFddOPkdi2YXR6U7i7vtfGmTFUKn6fdSpQ=; b=Psd4AGQx2Btb97W21Kb9JPCLMK 2W+kva3OXQdGrLqemtbW3GzbKAzK1XNKi629AqXuQLEfnm7eQ4G+LWg/dzQYQV/uVAN1MVXhpR5/l vI2S0wklbXhPkHAVKSxYaVtrp+UJaGOknGYWRKAYGLUSHrl9jWB8Nf3Uh3eXDVgrqlt1VFEF0eH4o xE6GnN6sr4nPw/t5vRJ5lJZWp3mkgaoe1Keg5dl1MJt8iWpegJqVTvr/8bq1UXXd7jmMxNAKvmbX3 UKAdH+nGorZMxdivqJXTHw7G4QsiWzI/9GBwrlYHHTQcfT7taGPe5d7a7j/7xxqgMpPDk9D9qGAGN +7IpDuFw==; Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXJ0V-0099gS-3Q for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 07:35:16 +0000 Received: by mail-oi1-x235.google.com with SMTP id b3so12205078oie.5 for ; Fri, 16 Apr 2021 00:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tJD4Wffy8UFddOPkdi2YXR6U7i7vtfGmTFUKn6fdSpQ=; b=G+yNnwMnLDElOBnF2B2+GxANp7XTkHj2DLoP/s3CNBCAi6w7gglXHy8oFGuZ6Qp2Qm OkeIpoc212lPbkc1hyJkm4A51KOcLo2OlS6K9uJ5dEF7gXETSsxiw5XJDsJgsXb3s2oE lTp4C8qSueJ08ORlfJ2m5xth4v57F+vKbyegAMM9luRp1wBe//U+v9gUr3+lZXdesng9 WwQpdi/QHfafpxLKTrJMbumRxFxzlDgN3ecEtb/fdhrAiLMY2USct0BXoIde0q8IFcLB IWa4uZRPhHVPfVLPtQM/ta90PyYBStMFJkJZJ9KNDBnVYP5W6ET3vQKd71EAnaMFp0Hu 7rPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tJD4Wffy8UFddOPkdi2YXR6U7i7vtfGmTFUKn6fdSpQ=; b=od/PhNGXMRdC87CSPgEV29lgHlKGbAS2sifcbtClCTQX6WduJY5NRUsKCisRlmHBfr UBjdUn3cb85d7Fn2N+1sMBHldsoRrMHTjw07t3iRGrl3XaXQjs2Q75Nj5F6fNJvdyVcC EqafRLd5XqGvi1TJzVDoYXKfoHrx9MEKy4jhW2+n9pFUu7O4gA/UmLpMwSFnKXc4Tcbg iGnqpqzRaCW0wtesGjjQfm/TsF01Pz0nIEUq109+Vgr7XnlDPNMKfaw8Yck0jr9NYnkT XrIQ3qH4XN2RnvHkfE1Ke217r1T3bOFnyad2cZujN4xdgwvHf5D/HKHcuN4b1GeZ093P /FAg== X-Gm-Message-State: AOAM533PwmObyozT/qM7U/B6kgh3KpRisWH2k2dD3fd/mpwuBdB0vvbo Ua3SDZIq1ABpPjt2FzqMW0+HndaY4PRfPe7Hl8HE6w== X-Google-Smtp-Source: ABdhPJyyb5uCrc4pETT//wgeijjcWgZHJwhyFG2hghIXA58CpkcDpTKOEaIX3WAcbBOMndCKUQq/lHReczEGRuQm9ms= X-Received: by 2002:a05:6808:d50:: with SMTP id w16mr5521425oik.28.1618558512880; Fri, 16 Apr 2021 00:35:12 -0700 (PDT) MIME-Version: 1.0 References: <20210316085932.2601-1-troy_lee@aspeedtech.com> In-Reply-To: From: Lei Yu Date: Fri, 16 Apr 2021 15:35:01 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v1] ARM: dts: Fix 64MiB OpenBMC flash layout and aspeed-ast2600-evb.dts To: Joel Stanley Cc: Troy Lee , John Wang , Rob Herring , Andrew Jeffery , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , leetroy@gmail.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_003515_202917_A9E0CEF3 X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 16, 2021 at 11:03 AM Joel Stanley wrote: > > On Tue, 16 Mar 2021 at 08:59, Troy Lee wrote: > > > > Aspeed AST2600 u-boot requires 600KiB+ flash space. Sharing the same > > openbmc-flash-layout-64.dtsi requires to resize the flash partition. > > > > The updated flash layout as follows: > > - u-boot: 896 KiB > > - u-boot-env: 128 KiB > > - kernel: 9MiB > > - rofs: 32 MiB > > - rwfs: 22 MiB > > Changing the 64MB layout will break the systems that are already using > this layout. I'll get the Bytedance people to chime in, as theirs is > the only system using this layout so far. > > John, Lei? Because the kernel's offset is updated, several other changes are required: 1. The related offsets, which is already sent to https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/39343 2. The u-boot patch to update the `bootm` address and make sure it only applies to the 64MiB layout. Without the above two changes, I would suggest holding the merge. -- BRs, Lei YU _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel