From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vikas Sajjan Subject: Re: [PATCH v2 1/7] ARM: dts: Move display-timimg information inside FIMD DT node for exynos5250 Date: Mon, 12 Aug 2013 12:27:53 +0530 Message-ID: References: <1375183178-8201-1-git-send-email-vikas.sajjan@linaro.org> <1375183178-8201-2-git-send-email-vikas.sajjan@linaro.org> <171932162.BeOHtLbZec@amdc1227> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-we0-f170.google.com ([74.125.82.170]:33898 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865Ab3HLG5z (ORCPT ); Mon, 12 Aug 2013 02:57:55 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: Tomasz Figa , Vikas Sajjan , linux-samsung-soc , devicetree@vger.kernel.org, Jingoo Han , InKi Dae , ajaynumb@gmail.com, patches@linaro.org, linaro-kernel@lists.linaro.org, grant.likely@secretlab.ca, Sylwester Nawrocki , sunil joshi Hi Kukjin, On Mon, Aug 5, 2013 at 3:59 PM, Sachin Kamat wrote: > On 5 August 2013 15:34, Vikas Sajjan wrote: >> Hi All, >> >> On Thu, Aug 1, 2013 at 8:19 PM, Tomasz Figa wrote: >>> Hi Vikas, >>> >>> On Tuesday 30 of July 2013 16:49:32 Vikas Sajjan wrote: >>>> As the display-timing information is parsed by FIMD driver, it makes >>>> sense to move the display-timimg DT node inside FIMD DT node for >>>> exynos5250 >>>> >>>> Signed-off-by: Vikas Sajjan >>>> --- >>>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 29 >>>> ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 >>>> deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts >>>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 49f18c2..d176dbb >>>> 100644 >>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts >>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts >>>> @@ -262,19 +262,22 @@ >>>> pinctrl-0 = <&dp_hpd>; >>>> }; >>>> >>>> - display-timings { >>>> - native-mode = <&timing0>; >>>> - timing0: timing@0 { >>>> - /* 1280x800 */ >>>> - clock-frequency = <50000>; >>>> - hactive = <1280>; >>>> - vactive = <800>; >>>> - hfront-porch = <4>; >>>> - hback-porch = <4>; >>>> - hsync-len = <4>; >>>> - vback-porch = <4>; >>>> - vfront-porch = <4>; >>>> - vsync-len = <4>; >>>> + fimd@14400000 { >>>> + status = "okay"; >>>> + display-timings { >>>> + native-mode = <&timing0>; >>>> + timing0: timing@0 { >>>> + /* 1280x800 */ >>>> + clock-frequency = <50000>; >>>> + hactive = <1280>; >>>> + vactive = <800>; >>>> + hfront-porch = <4>; >>>> + hback-porch = <4>; >>>> + hsync-len = <4>; >>>> + vback-porch = <4>; >>>> + vfront-porch = <4>; >>>> + vsync-len = <4>; >>>> + }; >>>> }; >>>> }; >>> >>> Looks good to me, but I would like some other people from the device tree >>> mailing list to comment on node naming: Do we want to conform to the >>> recommendation of ePAPR about node naming, which states that node names >>> should be generic, not platform specific or we are free to ignore it? >>> >> >> Any more comments on this series. > > One trivial typo in patch subject and commit message: > s/timimg/timing > Can you apply this series (by correcting typo s/timimg/timing) OR you want me to respin V3 with this typo correction. > > > -- > With warm regards, > Sachin