From: Tom Yan <tom.ty89@gmail.com>
To: dgilbert@interlog.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: About BLKSECTGET in sg
Date: Sat, 5 Sep 2020 03:21:22 +0800 [thread overview]
Message-ID: <CAGnHSE=fY2wkzNeZTSHC37Sp-uD4D8YMEb7LesDkPcQWAfiK=w@mail.gmail.com> (raw)
In-Reply-To: <bfd72561-08e9-88fc-8325-a9986d69d2fd@interlog.com>
Hi Doug,
On Sat, 5 Sep 2020 at 00:28, Douglas Gilbert <dgilbert@interlog.com> wrote:
>
> On 2020-09-04 12:42 a.m., Tom Yan wrote:
> > Hi,
> >
> > Is BLKSECTGET in sg intentionally kept "broken" (i.e. it gives out
> > max_sectors in bytes) or is it just a miss? I'm just wondering if I
> > should send a patch to fix it (and implement BLKSSZGET).
> >
> > Also, shouldn't max_sectors_bytes() in both drivers/scsi/sg.c and
> > block/scsi_ioctl.c use queue_logical_block_size() instead?
>
> Tom,
> I have no idea! One of the great things about maintaining a driver in
> Linux is that virtually anyone can send patches and get them accepted
> without and Ack from the maintainer. And when bugs are found in those
> patches, the culprits can't be found or have no inclination to fix them.
>
> 'git blame' will show you that I had nothing to do with the BLK*
> ioctl()s added to the sg driver. That said, if they are broken, they
> should be fixed. I would be interested in getting some test code as
You can test them easily with `blockdev` (--getmaxsect and --getss) in
util-linux.
max_sectors_bytes() are used in sg_add_sfp() and the
SG_{GET,SET}_RESERVED_SIZE ioctls. I am not familiar with those but I
don't see why they shouldn't use the queue_logical_sector_size() (when
they use queue_max_sectors()).
For the BLKSECTGET fix, I think the sg version needs to be bumped (so
that userspace programs like qemu can work as properly as possible
with different versions). Can you point me to some guidance on how
exactly it should be bumped (e.g. which component(s), the "step
size"...)? Or would you do that after the patches are accepted?
> I'm not familiar with using those ioctl()s.
>
> Would you like to send some patches?
They are on the way.
>
> Doug Gilbert
>
>
Regards,
Tom
next prev parent reply other threads:[~2020-09-04 19:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 4:42 About BLKSECTGET in sg Tom Yan
2020-09-04 16:28 ` Douglas Gilbert
2020-09-04 19:21 ` Tom Yan [this message]
2020-09-04 20:05 ` [PATCH 1/4] scsi: sg: fix BLKSECTGET ioctl Tom Yan
2020-09-04 20:05 ` [PATCH 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-05 18:37 ` Douglas Gilbert
2020-09-04 20:05 ` [PATCH 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-05 18:37 ` Douglas Gilbert
2020-09-04 20:05 ` [PATCH 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-05 18:37 ` Douglas Gilbert
2020-09-05 18:37 ` [PATCH 1/4] scsi: sg: fix BLKSECTGET ioctl Douglas Gilbert
2020-09-05 19:32 ` Bart Van Assche
2020-09-05 20:36 ` Douglas Gilbert
2020-09-06 1:19 ` Tom Yan
2020-09-06 1:25 ` [PATCH RESEND " Tom Yan
2020-09-06 1:25 ` [PATCH RESEND 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-06 1:25 ` [PATCH RESEND 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 1:25 ` [PATCH RESEND 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-06 1:27 ` [PATCH RESEND 1/4] scsi: sg: fix BLKSECTGET ioctl Tom Yan
2020-09-06 1:27 ` [PATCH RESEND 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-07 6:09 ` Christoph Hellwig
2020-09-07 9:01 ` Tom Yan
2020-09-08 8:42 ` Christoph Hellwig
2020-09-10 1:59 ` Tom Yan
2020-09-10 5:28 ` Christoph Hellwig
2020-09-11 2:52 ` Tom Yan
2020-09-11 6:48 ` Christoph Hellwig
2020-09-11 17:52 ` Douglas Gilbert
2020-09-11 21:33 ` Alan Stern
2020-09-16 5:47 ` Tom Yan
2020-09-06 1:27 ` [PATCH RESEND 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 6:26 ` Greg KH
2020-09-06 7:01 ` Tom Yan
2020-09-06 7:40 ` [PATCH v2 1/4] scsi: sg: fix BLKSECTGET ioctl Tom Yan
2020-09-06 7:40 ` [PATCH v2 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-06 7:40 ` [PATCH v2 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 7:40 ` [PATCH v2 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-06 7:51 ` [PATCH v3 1/4] scsi: sg: fix BLKSECTGET ioctl Tom Yan
2020-09-06 7:51 ` [PATCH v3 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-06 7:51 ` [PATCH v3 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 7:51 ` [PATCH v3 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-06 1:27 ` [PATCH RESEND " Tom Yan
2020-09-06 5:09 ` [PATCH 1/4] scsi: sg: fix BLKSECTGET ioctl Douglas Gilbert
2020-09-06 7:16 ` Tom Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGnHSE=fY2wkzNeZTSHC37Sp-uD4D8YMEb7LesDkPcQWAfiK=w@mail.gmail.com' \
--to=tom.ty89@gmail.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.