From: Tom Yan <tom.ty89@gmail.com>
To: Shaun Tancheff <shaun.tancheff@seagate.com>
Cc: Shaun Tancheff <shaun@tancheff.com>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Tejun Heo <tj@kernel.org>, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <damien.lemoal@hgst.com>,
Hannes Reinecke <hare@suse.de>,
Josh Bingaman <josh.bingaman@seagate.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v6 3/4] SCT Write Same / DSM Trim
Date: Mon, 22 Aug 2016 20:57:52 +0000 [thread overview]
Message-ID: <CAGnHSEn64mQt=ujSRCN_1pfzHXSDqe=esvZZ1mv-3oPxNZMFLQ@mail.gmail.com> (raw)
In-Reply-To: <CAGnHSEkOm3nmmeHMQ5Jok2v2Up3ygNE5AE0sjkFTY26_4PTKvg@mail.gmail.com>
On 22 August 2016 at 18:52, Tom Yan <tom.ty89@gmail.com> wrote:
>
> For the "payload block size" that is "always" 512-byte as per the same
> spec, I don't think we need to concern about it. I think it only
> matters if we want to enable multi-block TRIM payload according to the
> reported limit in IDENTIFY DEVICE data. Probably it merely means that
> the "each of the blocks" in the reported limit will always mean 64
> TRIM entries, even on 4Kn drives, instead of 512.
>
Actually that's what we assumed in our current code that forms the DSM
command as well. See how (hob_)feature for queued TRIM and how
(hob_)nsect for non-queued TRIM are set in ata_scsi_write_same_xlat in
libata-scsi ('size / 512').
So if you are going to increase the payload block size per logical
sector size (in other word, you assume that the payload block size is
_expected_ to be the logical block size, in spite of what ACS told,
you'll need to adjust how the aforementioned fields in the ATA
taskfile are set as well.
next prev parent reply other threads:[~2016-08-22 20:57 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 4:23 [PATCH v6 0/4] SCT Write Same Shaun Tancheff
2016-08-22 4:23 ` [PATCH v6 1/4] libata: Safely overwrite attached page in WRITE SAME xlat Shaun Tancheff
2016-08-22 6:27 ` Hannes Reinecke
2016-08-22 19:27 ` Tom Yan
2016-08-22 19:51 ` Shaun Tancheff
2016-08-22 20:12 ` Tom Yan
2016-08-22 21:20 ` Tom Yan
2016-08-22 22:00 ` Shaun Tancheff
2016-08-22 23:49 ` Tom Yan
2016-08-23 1:01 ` Shaun Tancheff
2016-08-23 5:26 ` Tom Yan
2016-08-23 6:20 ` Shaun Tancheff
2016-08-23 7:53 ` Tom Yan
2016-08-23 8:42 ` Shaun Tancheff
2016-08-23 9:04 ` Tom Yan
2016-08-24 3:33 ` Martin K. Petersen
2016-08-24 5:31 ` Tom Yan
2016-08-24 21:28 ` Shaun Tancheff
2016-08-25 6:31 ` Tom Yan
2016-08-25 7:18 ` Shaun Tancheff
2016-08-22 4:23 ` [PATCH v6 2/4] Add support for SCT Write Same Shaun Tancheff
2016-08-22 6:27 ` Hannes Reinecke
2016-08-22 19:20 ` Tom Yan
2016-08-22 19:43 ` Shaun Tancheff
2016-08-22 20:14 ` Tom Yan
2016-08-22 22:07 ` Shaun Tancheff
2016-08-22 23:09 ` Tom Yan
2016-08-23 0:36 ` Shaun Tancheff
2016-08-23 5:55 ` Tom Yan
2016-08-23 6:11 ` Shaun Tancheff
2016-08-23 7:57 ` Tom Yan
2016-08-23 10:37 ` Tom Yan
2016-08-23 10:56 ` Shaun Tancheff
2016-08-24 5:57 ` Tom Yan
2016-08-24 6:10 ` Tom Yan
2016-08-24 22:04 ` Shaun Tancheff
2016-08-25 6:23 ` Tom Yan
2016-08-25 7:31 ` Shaun Tancheff
2016-08-22 4:23 ` [PATCH v6 3/4] SCT Write Same / DSM Trim Shaun Tancheff
2016-08-22 6:30 ` Hannes Reinecke
2016-08-24 18:08 ` [PATCH v6 3/4 RESEND] " Shaun Tancheff
2016-08-25 7:01 ` Tom Yan
2016-08-25 8:03 ` Shaun Tancheff
2016-08-25 9:30 ` Tom Yan
2016-08-22 8:31 ` [PATCH v6 3/4] " Tom Yan
2016-08-22 8:33 ` Tom Yan
2016-08-22 15:04 ` Shaun Tancheff
2016-08-22 17:02 ` Tom Yan
2016-08-22 18:00 ` Shaun Tancheff
2016-08-22 18:52 ` Tom Yan
2016-08-22 20:57 ` Tom Yan [this message]
2016-08-22 4:23 ` [PATCH v6 4/4] SCT Write Same handle ATA_DFLAG_PIO Shaun Tancheff
2016-08-22 6:31 ` Hannes Reinecke
2016-08-22 6:32 ` [PATCH v6 0/4] SCT Write Same Hannes Reinecke
2016-08-25 15:28 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGnHSEn64mQt=ujSRCN_1pfzHXSDqe=esvZZ1mv-3oPxNZMFLQ@mail.gmail.com' \
--to=tom.ty89@gmail.com \
--cc=damien.lemoal@hgst.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=josh.bingaman@seagate.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun.tancheff@seagate.com \
--cc=shaun@tancheff.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.