From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145AbbHWOyT (ORCPT ); Sun, 23 Aug 2015 10:54:19 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:36414 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbbHWOyR (ORCPT ); Sun, 23 Aug 2015 10:54:17 -0400 MIME-Version: 1.0 In-Reply-To: <20150823140823.GA13546@localhost> References: <1438831173-8761-1-git-send-email-punnaia@xilinx.com> <1438831173-8761-2-git-send-email-punnaia@xilinx.com> <20150820061312.GA13546@localhost> <20150823140823.GA13546@localhost> Date: Sun, 23 Aug 2015 20:24:16 +0530 X-Google-Sender-Auth: ZLlopqJqJ-OaLKj0S-JE0_1WAx4 Message-ID: Subject: Re: [PATCH v4 2/2] dma: Add Xilinx zynqmp dma engine driver support From: punnaiah choudary kalluri To: Vinod Koul Cc: Punnaiah Choudary Kalluri , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , "michal.simek@xilinx.com" , dan.j.williams@intel.com, dmaengine@vger.kernel.org, "devicetree@vger.kernel.org" , linux-arm-kernel , "linux-kernel@vger.kernel.org" , Punnaiah Choudary Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 23, 2015 at 7:38 PM, Vinod Koul wrote: > On Thu, Aug 20, 2015 at 12:01:27PM +0530, punnaiah choudary kalluri wrote: >> On Thu, Aug 20, 2015 at 11:43 AM, Vinod Koul wrote: >> > On Thu, Aug 06, 2015 at 08:49:33AM +0530, Punnaiah Choudary Kalluri wrote: >> > >> >> + list_for_each_entry_safe(desc, next, &chan->done_list, node) { >> >> + dma_async_tx_callback callback; >> >> + void *callback_param; >> >> + >> >> + list_del(&desc->node); >> >> + >> >> + callback = desc->async_tx.callback; >> >> + callback_param = desc->async_tx.callback_param; >> >> + if (callback) { >> >> + if (in_interrupt()) >> >> + spin_unlock_bh(&chan->lock); >> >> + else >> >> + spin_unlock(&chan->lock); >> > >> > This looks bad! >> > Why would callback be called from different context. It should only be >> > invoked from your tasklet >> >> During the terminate call, driver need to clean up the existing BDs so that time >> this function will be called from the thread or process context in >> addition to the >> tasklet context. >> >> DO you have any suggestion here ? > > Yes you need to terminate but you don't need to invoke user for terminate > flow. It is not expected. > Terminate flow expect youu to clean the channels Ok. Thanks. I will fix this and send v5 soon. Regards, Punnaiah > > -- > ~Vinod > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: punnaia@xilinx.com (punnaiah choudary kalluri) Date: Sun, 23 Aug 2015 20:24:16 +0530 Subject: [PATCH v4 2/2] dma: Add Xilinx zynqmp dma engine driver support In-Reply-To: <20150823140823.GA13546@localhost> References: <1438831173-8761-1-git-send-email-punnaia@xilinx.com> <1438831173-8761-2-git-send-email-punnaia@xilinx.com> <20150820061312.GA13546@localhost> <20150823140823.GA13546@localhost> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Aug 23, 2015 at 7:38 PM, Vinod Koul wrote: > On Thu, Aug 20, 2015 at 12:01:27PM +0530, punnaiah choudary kalluri wrote: >> On Thu, Aug 20, 2015 at 11:43 AM, Vinod Koul wrote: >> > On Thu, Aug 06, 2015 at 08:49:33AM +0530, Punnaiah Choudary Kalluri wrote: >> > >> >> + list_for_each_entry_safe(desc, next, &chan->done_list, node) { >> >> + dma_async_tx_callback callback; >> >> + void *callback_param; >> >> + >> >> + list_del(&desc->node); >> >> + >> >> + callback = desc->async_tx.callback; >> >> + callback_param = desc->async_tx.callback_param; >> >> + if (callback) { >> >> + if (in_interrupt()) >> >> + spin_unlock_bh(&chan->lock); >> >> + else >> >> + spin_unlock(&chan->lock); >> > >> > This looks bad! >> > Why would callback be called from different context. It should only be >> > invoked from your tasklet >> >> During the terminate call, driver need to clean up the existing BDs so that time >> this function will be called from the thread or process context in >> addition to the >> tasklet context. >> >> DO you have any suggestion here ? > > Yes you need to terminate but you don't need to invoke user for terminate > flow. It is not expected. > Terminate flow expect youu to clean the channels Ok. Thanks. I will fix this and send v5 soon. Regards, Punnaiah > > -- > ~Vinod > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/