All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Van Asbroeck <thesven73@gmail.com>
To: Oscar Gomez Fuente <oscargomezf@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
Date: Mon, 20 May 2019 15:39:46 -0400	[thread overview]
Message-ID: <CAGngYiUCedv6oqTPOS+eFwnQJajor3hwKjxeNRcKq031giZeXg@mail.gmail.com> (raw)
In-Reply-To: <CAGngYiUZmfnuj5WUnwk18szijmsQjF27j=OxQfJtp5bNORppRQ@mail.gmail.com>

On Mon, May 20, 2019 at 2:35 PM Sven Van Asbroeck <thesven73@gmail.com> wrote:
>
> Hi Oscar, thank you for your contribution! I have a question, see inline.
>
> On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
> <oscargomezf@gmail.com> wrote:
> >
> > These changes solve a warning realated to an incorrect type inilizer in the function
> > fieldbus_poll.
> >

This warning was generated by sparse, right?

$ make C=2 drivers/staging/fieldbus/
<snip>
  CHECK   drivers/staging/fieldbus/dev_core.c
drivers/staging/fieldbus/dev_core.c:232:27: warning: incorrect type in
initializer (different base types)
drivers/staging/fieldbus/dev_core.c:232:27:    expected restricted
__poll_t ( *poll )( ... )
drivers/staging/fieldbus/dev_core.c:232:27:    got unsigned int (
*<noident> )( ... )
<snip>

I will test your patch on actual h/w, probably tomorrow.
I don't expect to see any problems.

Sven

  reply	other threads:[~2019-05-20 19:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 17:49 [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c Oscar Gomez Fuente
2019-05-20 18:35 ` Sven Van Asbroeck
2019-05-20 19:39   ` Sven Van Asbroeck [this message]
2019-05-20 19:59     ` Oscar Gomez Fuente
2019-05-21 14:13 ` Sven Van Asbroeck
2019-05-21 14:17   ` Greg KH
2019-05-21 14:24     ` Sven Van Asbroeck
2019-05-21 14:51       ` Oscar Gomez Fuente
  -- strict thread matches above, loose matches on Subject: below --
2019-05-17 16:53 Oscar Gomez Fuente
2019-05-17 17:08 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGngYiUCedv6oqTPOS+eFwnQJajor3hwKjxeNRcKq031giZeXg@mail.gmail.com \
    --to=thesven73@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oscargomezf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.