All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Van Asbroeck <thesven73@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: George McCollister <george.mccollister@gmail.com>,
	Bryan Whitehead <bryan.whitehead@microchip.com>,
	David S Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	netdev <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not just 2"
Date: Thu, 8 Apr 2021 18:27:07 -0400	[thread overview]
Message-ID: <CAGngYiVuvm4Z9zFUQTWVyZgAHVC0uap1+-XE_vLoXAmrpXKEyw@mail.gmail.com> (raw)
In-Reply-To: <da81fa46-fbbd-7694-6212-d7eb2c03ac94@gmail.com>

Hi Heiner,

On Thu, Apr 8, 2021 at 3:06 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> A completely unrelated question:
> How about VLAN packets with a 802.1Q tag? Should VLAN_ETH_HLEN be used?

That's a good question. My use-case does not involve 802.1Q though, so
I'm unable to test.

Thank you so much for your suggestion earlier, I'll put a proper
attribution to you in the new patch's commit message.

  reply	other threads:[~2021-04-08 22:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 17:23 [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not just 2" Sven Van Asbroeck
2021-04-08 17:36 ` George McCollister
2021-04-08 17:45   ` Sven Van Asbroeck
2021-04-08 18:00     ` George McCollister
2021-04-08 18:22       ` Heiner Kallweit
2021-04-08 18:26         ` Sven Van Asbroeck
2021-04-08 18:35           ` Sven Van Asbroeck
2021-04-08 19:06             ` Heiner Kallweit
2021-04-08 22:27               ` Sven Van Asbroeck [this message]
2021-04-08 19:55             ` George McCollister
2021-04-08 22:24               ` Sven Van Asbroeck
2021-04-09 17:24             ` David Laight
2021-04-08 17:49 ` Heiner Kallweit
2021-04-08 17:56   ` Sven Van Asbroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGngYiVuvm4Z9zFUQTWVyZgAHVC0uap1+-XE_vLoXAmrpXKEyw@mail.gmail.com \
    --to=thesven73@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=bryan.whitehead@microchip.com \
    --cc=davem@davemloft.net \
    --cc=george.mccollister@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.