From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A024EC433E0 for ; Wed, 24 Jun 2020 02:56:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BC9B20874 for ; Wed, 24 Jun 2020 02:56:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AN/2WJZs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388466AbgFXC4e (ORCPT ); Tue, 23 Jun 2020 22:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387985AbgFXC4d (ORCPT ); Tue, 23 Jun 2020 22:56:33 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 725BFC061573 for ; Tue, 23 Jun 2020 19:56:33 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id n5so570570otj.1 for ; Tue, 23 Jun 2020 19:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wDL9pKZ/aY/6GF+LYS6OgXAXDW+bnN8p+ujXzgAstfY=; b=AN/2WJZsaL5zQ4JKy5XIeRuc7Er5Q9ZQRulkYR3C1CL9h7aV2IL7/S68jA5RSjZV93 9sVJuGr0Bor4RgUpuJQjeqbMoeFTpYLeTcqB5Iy/ZRAsTCwFjXcjWerTV6nC6FOKs4hM YiLlfz+XAYPVoOUgVn/Y/RfKNfOJU5GkWZAcyHblX50sKA9PujJse7a21PgIJuoYsQa5 klWW6SWYiFR4tia+zULRWPmCtoPdPt2ieTW7En0Na7eyrvniLnlZhMzgR1myFzt4irQ8 /WUqAxjP9sZxroqlgEWj7H6MsVS4lwYz2ESzKb/xSmnpjFkhscjpO1/S3FqxdVIhMGek g73g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wDL9pKZ/aY/6GF+LYS6OgXAXDW+bnN8p+ujXzgAstfY=; b=Jv2zXgZmyjj0q9XMva+uCfDtKf8ppJOu2WVFQ5owyfMbLIWEKhM989SMUaDy+crqD9 u7DKXUI+7FzbhtwdButLY27i+zdHigUZLPPazSzINamM+6Zu3OqYBtPM5meyO29NWHTi 4I/jeGx7Usij4WX+c9our/WfB+QhPAHmU3QPVvAUJaGvvID5wf5JAFDCY5yWn4aGLCGD /zRzEwrLztp8m0EjDD5aH8qQvexjl9SYhvf5gNTxSOASqK4Yzk+LIhlL0txa10kMWdy+ Lj0/BoBKAAqNlBYXwhUSxC/81g+9fv5gLW8TQIIi+gdaFldYBhj9pSxh4Z6ttjy+3KUO K4KQ== X-Gm-Message-State: AOAM532p142aUO8t8Pm3juysooOz3+PNJaFMIUT4LDkxWrG/euoYUKCw YRnR/91ak7IiTO12mXlrG+UYmmmxnKlL7jcOup8= X-Google-Smtp-Source: ABdhPJzB7NNJejyE2ko2eEIDNx3flC26avxHIwjWADj6wLS2giyp8JGF4cYsFt8PQgCjehinqymfHHm4ZoR2Wa2k6uI= X-Received: by 2002:a9d:629a:: with SMTP id x26mr21604188otk.116.1592967392687; Tue, 23 Jun 2020 19:56:32 -0700 (PDT) MIME-Version: 1.0 References: <20200613201703.16788-1-TheSven73@gmail.com> <20200623115335.GC30139@dragon> In-Reply-To: From: Sven Van Asbroeck Date: Tue, 23 Jun 2020 22:56:21 -0400 Message-ID: Subject: Re: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible To: Andy Duan Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Tue, Jun 23, 2020 at 9:40 PM Andy Duan wrote: > > The patch looks good. > Reviewed-by: Fugang Duan Thank you ! To check we're on a plus, the patch uses: cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0 Fabio Estevam suggested that perhaps checking of_machine_is_compatible("fsl,imx6qp") might be preferable. What is your opinion on this? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92AFEC433E0 for ; Wed, 24 Jun 2020 02:58:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CAAE20874 for ; Wed, 24 Jun 2020 02:58:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HnGouS87"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AN/2WJZs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CAAE20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bjGOR/aBMP2cL9B/oGpitebczv2EPbIhPvi5Wnj+H+I=; b=HnGouS87NovVo/quI8K2D7dR3 3ga5JWbKeMMZ6wjdLnr56C3rVtvjcULZT1wWLR43VZJfgY2JYjFI2smYNszviAgE5rbupgVrOALA8 GeZfLJfwLB67IqzWV2Z02a4p1B9+7x/oKFgWgqSf1Ms9elfamiycxLhtC7OyyLXInRJPZJn+W6nDG uUvW17AD/2u0M43ehNfQQvO5k2eGA2LaQB8xqyQkIO0HNOG4f30YccgQ3U3NCcHU+DtO+OOvNikwI V52HRhWd0ycuDB8KDsFD1kACFQH3Yoy036dtVp3vwJ5s+ZRsK1X7E6wtnn9BY+LoEdbo5YGLw5/NK a6eVZZL9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnvab-0003wA-VX; Wed, 24 Jun 2020 02:56:42 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnvaY-0003rc-Sm for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 02:56:39 +0000 Received: by mail-ot1-x342.google.com with SMTP id d4so559759otk.2 for ; Tue, 23 Jun 2020 19:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wDL9pKZ/aY/6GF+LYS6OgXAXDW+bnN8p+ujXzgAstfY=; b=AN/2WJZsaL5zQ4JKy5XIeRuc7Er5Q9ZQRulkYR3C1CL9h7aV2IL7/S68jA5RSjZV93 9sVJuGr0Bor4RgUpuJQjeqbMoeFTpYLeTcqB5Iy/ZRAsTCwFjXcjWerTV6nC6FOKs4hM YiLlfz+XAYPVoOUgVn/Y/RfKNfOJU5GkWZAcyHblX50sKA9PujJse7a21PgIJuoYsQa5 klWW6SWYiFR4tia+zULRWPmCtoPdPt2ieTW7En0Na7eyrvniLnlZhMzgR1myFzt4irQ8 /WUqAxjP9sZxroqlgEWj7H6MsVS4lwYz2ESzKb/xSmnpjFkhscjpO1/S3FqxdVIhMGek g73g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wDL9pKZ/aY/6GF+LYS6OgXAXDW+bnN8p+ujXzgAstfY=; b=I+eZMUxdmU5YYplGmgAzI0YVqgHQ9L2C2j4S/DZ+K0jISBd7eFg55Yos67MDkLEwlA BFRs+SU9OXCEHJdBj037U2JQDZ4pgSq2EYjbTPIIAmD7aBUUzCIEirLiqUnoxwtBhQem 7yFRsNOHMCyAGyONnrLVwzmpM0B+woGa1nmwwehJ7GRusvvhRxN3f5A95xPjlux9fS+m 8EW5ZP9ULrPMMzNoVwwYTENo/73FyWLDg1ydg5e4SLCVLSKt19EtlkLlCdbmMhWBf37+ 5PNFdVt/JpEQkRzK3wU6RvX58obfFp4YBPg/2Wi/UmYjToZHpx0uIkg0FXzDJrA/+d27 x/og== X-Gm-Message-State: AOAM530TIWpgv8HYSwsyiPLBaQe5g1CzaAswFtV6SgB1qr5PKUO/zZhd iymoEcfZH3eLOslqSEGVpIvxQNruqHtjb0HOKqo= X-Google-Smtp-Source: ABdhPJzB7NNJejyE2ko2eEIDNx3flC26avxHIwjWADj6wLS2giyp8JGF4cYsFt8PQgCjehinqymfHHm4ZoR2Wa2k6uI= X-Received: by 2002:a9d:629a:: with SMTP id x26mr21604188otk.116.1592967392687; Tue, 23 Jun 2020 19:56:32 -0700 (PDT) MIME-Version: 1.0 References: <20200613201703.16788-1-TheSven73@gmail.com> <20200623115335.GC30139@dragon> In-Reply-To: From: Sven Van Asbroeck Date: Tue, 23 Jun 2020 22:56:21 -0400 Message-ID: Subject: Re: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible To: Andy Duan X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , "linux-kernel@vger.kernel.org" , dl-linux-imx , Pengutronix Kernel Team , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Tue, Jun 23, 2020 at 9:40 PM Andy Duan wrote: > > The patch looks good. > Reviewed-by: Fugang Duan Thank you ! To check we're on a plus, the patch uses: cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0 Fabio Estevam suggested that perhaps checking of_machine_is_compatible("fsl,imx6qp") might be preferable. What is your opinion on this? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel