From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E59C433DB for ; Sun, 31 Jan 2021 00:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 912CC64E0F for ; Sun, 31 Jan 2021 00:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232465AbhAaAPR (ORCPT ); Sat, 30 Jan 2021 19:15:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231792AbhAaAPL (ORCPT ); Sat, 30 Jan 2021 19:15:11 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85CC2C061574; Sat, 30 Jan 2021 16:14:31 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id u14so9614943wml.4; Sat, 30 Jan 2021 16:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TlZACLBYSiWOJ+PR1UkJhkGCoBOMzhgTmOJYTxZL9PA=; b=eHf3+tbIJp2pu2zKGA6AWA/ybCWQXCVKwZNb8zBWbbVK811Tvts9quv+vae59pNXXu jyl9rIZ56ADmLYwnju9FXzVXU/P1y2aB4XKbt1rMWPiFWT5p0IJnVEFXjAA7fbdzXX/a RG9O4GpkfeblUAGFdc3eKYMcInen+UQszFn7sKlSGqWpiHG68wZk3DGZzS/tZbfuLKCm reJOilZQwXCNzJW6Z/c8VidoHSUNZrPSyzPyJP2ywA/dSvPikVODe+a7Ufa45/2K+W6L rbZ4OvR7b6+SwJcUWVi93P2fRgXxT8Dvp6V5AItTdel+5C6nwhylgAO8ZHDoOe+hBmTF X0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TlZACLBYSiWOJ+PR1UkJhkGCoBOMzhgTmOJYTxZL9PA=; b=WVusL7WpljUpffXokOINqbYh6wF73TmDl5tdIJ/kGI7RmuNg5nrmXJRzxV5hcKnzWu DEo2hXioRpUQyJqgxYxBQ3edTElUqbSDynW4L6+GiXHpo8mKAAXWD7so9oBUL2BTwkGm r+cg8wRisFluQTcj9a2lM6jYktoyrJ4y0qOarYel92Ofx6vw+8c1xDXYvMK/M3C866wm atbLUKOsorbuU0vWqhf6tlq4cNrrFvpG+Sacm71dy6EltB57tMO0TMeTc3vzpyWebERw pj9pmSmBH1XSTmz+1lRr75usoIFplbjr6oGt+gmkYqy7emjIrdywrgphb/dZmT4B6DSl NC2w== X-Gm-Message-State: AOAM532zRiLxuCh4DC64juWZEtEPIr1eHktJvtcIoyI2bwujvrjQHnpV gl+GosgvikoyELFVTpXFNePHpdFMiLE3npAKUIM= X-Google-Smtp-Source: ABdhPJwYLU28vfMkVC34u5/L2TH5Z7WULGaf2+EJFPJsenVQwQz2erOC726lGl9LBNij4OxVJ2cXUgl1kc20bpxJu6U= X-Received: by 2002:a1c:4e:: with SMTP id 75mr9367154wma.150.1612052070192; Sat, 30 Jan 2021 16:14:30 -0800 (PST) MIME-Version: 1.0 References: <20210129195240.31871-1-TheSven73@gmail.com> <20210129195240.31871-2-TheSven73@gmail.com> In-Reply-To: From: Sven Van Asbroeck Date: Sat, 30 Jan 2021 19:14:16 -0500 Message-ID: Subject: Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping To: Bryan Whitehead Cc: Microchip Linux Driver Support , David Miller , Jakub Kicinski , Andrew Lunn , Alexey Denisov , Sergej Bauer , Tim Harvey , =?UTF-8?Q?Anders_R=C3=B8nningen?= , netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 30, 2021 at 5:11 PM wrote: > > It appears you moved this packet_length assignment from just below the following if block, however you left out the le32_to_cpu.See next comment PS this merge snafu is removed completely by the next patch in the set. So this will not prevent you from reviewing/testing the multi-buffer support, should you want to.