From: Matteo Croce <mcroce@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
vlomovtsev@marvell.com
Subject: Re: [PATCH net] net: thunderx: fix NULL pointer dereference in nicvf_open/nicvf_stop
Date: Thu, 4 Apr 2019 14:42:15 +0200 [thread overview]
Message-ID: <CAGnkfhy7zgi9mZTNBe1eekJDSe9EKjYrAsnDqUAfK16ANcL3Mw@mail.gmail.com> (raw)
In-Reply-To: <d13abbf06d7aa74e15fe7eedb93bfab36afe7fde.1554372556.git.lorenzo.bianconi@redhat.com>
On Thu, Apr 4, 2019 at 12:16 PM Lorenzo Bianconi
<lorenzo.bianconi@redhat.com> wrote:
>
> When a bpf program is uploaded, the driver computes the number of
> xdp tx queues resulting in the allocation of additional qsets.
> Starting from commit '2ecbe4f4a027 ("net: thunderx: replace global
> nicvf_rx_mode_wq work queue for all VFs to private for each of them")'
> the driver runs link state polling for each VF resulting in the
> following NULL pointer dereference:
>
> Fixes: 2ecbe4f4a027 ("net: thunderx: replace global nicvf_rx_mode_wq work queue for all VFs to private for each of them")
> Fixes: 2c632ad8bc74 ("net: thunderx: move link state polling function to VF")
> Reported-by: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>
root@thunderx:~# uname -r
5.1.0-rc3+
root@thunderx:~# ip -d link show dev enP2p1s0v0
2: enP2p1s0v0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 xdp qdisc mq
state UP mode DEFAULT group default qlen 1000
link/ether 1c:1b:0d:0d:52:a4 brd ff:ff:ff:ff:ff:ff promiscuity 0
addrgenmode none numtxqueues 48 numrxqueues 48 gso_max_size 65536
gso_max_segs 65535
prog/xdp id 2 tag 444c1e2fd143efc0 jited
Tested-by: Matteo Croce <mcroce@redhat.com>
--
Matteo Croce
per aspera ad upstream
next prev parent reply other threads:[~2019-04-04 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1554372556.git.lorenzo.bianconi@redhat.com>
2019-04-04 10:16 ` [PATCH net] net: thunderx: fix NULL pointer dereference in nicvf_open/nicvf_stop Lorenzo Bianconi
2019-04-04 12:42 ` Matteo Croce [this message]
2019-04-04 17:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGnkfhy7zgi9mZTNBe1eekJDSe9EKjYrAsnDqUAfK16ANcL3Mw@mail.gmail.com \
--to=mcroce@redhat.com \
--cc=davem@davemloft.net \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vlomovtsev@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.