From: Devin Heitmueller <dheitmueller@kernellabs.com>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Prabhakar Lad <prabhakar.csengg@gmail.com>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Tim Mester <ttmesterr@gmail.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] media: au0828 remove video and vbi buffer timeout work-around
Date: Tue, 13 Jan 2015 09:19:50 -0500 [thread overview]
Message-ID: <CAGoCfix=fEj5SMqBh_bwzRTfqSkM03jiKbp6-jW9u4CLf6ffSg@mail.gmail.com> (raw)
In-Reply-To: <54B527E8.3080004@osg.samsung.com>
> I couldn't reproduce what I was seeing when I did patch v2 series
> work. What I noticed was that I was seeing a few too many green screens
> and I had to re-tune xawtv when the timeout code is in place. My
> thinking was that this timeout handling could be introducing blank
> green frames when there is no need. However, I can't reproduce the
> problem on 3.19-rc4 base which is what I am using to test the changes
> to the patch series. Hence, I am not positive if the timeout code
> indeed was doing anything bad.
IIRC, the timer was set for 40ms, so if a complete video frame doesn't
arrive within that interval we generate a green frame. It was never
really intended to have perfect clocking (i.e. 29.97 FPS), but is
really just there to prevent the tvtime user interface from blocking
indefinitely.
If you weren't seeing it in the V2 series, then I guess you fixed
whatever bug was present in V1.
> I am seeing tvtime hangs without the timeout. I am fine with this
> patch not going. It does make the code cleaner and also reduces
> buffer handling during streaming. However, there is a clear regression
> to tvtime.
Correct. I think everybody agrees that the timer code is ugly and it
would be cleaner if it wasn't needed - except it clearly is needed to
prevent regressions in tvtime.
All that said, I'm quite excited to see the driver converted to VB2. Nice job!
Devin
--
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
prev parent reply other threads:[~2015-01-13 14:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 2:56 [PATCH v3 0/3] au0828 vb2 conversion Shuah Khan
2015-01-13 2:56 ` [PATCH v3 1/3] media: fix au0828 compile error from au0828_boards initialization Shuah Khan
2015-01-22 12:44 ` Lad, Prabhakar
2015-01-13 2:56 ` [PATCH v3 2/3] media: au0828 - convert to use videobuf2 Shuah Khan
2015-01-22 12:41 ` Lad, Prabhakar
2015-01-22 15:00 ` Devin Heitmueller
2015-01-22 15:05 ` Shuah Khan
2015-01-22 16:16 ` Shuah Khan
2015-01-22 20:47 ` Lad, Prabhakar
2015-01-22 22:27 ` Shuah Khan
2015-01-13 2:56 ` [PATCH v3 3/3] media: au0828 remove video and vbi buffer timeout work-around Shuah Khan
2015-01-13 4:44 ` Devin Heitmueller
2015-01-13 14:12 ` Shuah Khan
2015-01-13 14:19 ` Devin Heitmueller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGoCfix=fEj5SMqBh_bwzRTfqSkM03jiKbp6-jW9u4CLf6ffSg@mail.gmail.com' \
--to=dheitmueller@kernellabs.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkh@osg.samsung.com \
--cc=ttmesterr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.