From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934302Ab3CTMun (ORCPT ); Wed, 20 Mar 2013 08:50:43 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:50677 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384Ab3CTMul (ORCPT ); Wed, 20 Mar 2013 08:50:41 -0400 MIME-Version: 1.0 In-Reply-To: <5149A3E2.2030505@ti.com> References: <1363704868-11843-1-git-send-email-eduardo.valentin@ti.com> <1363704868-11843-10-git-send-email-eduardo.valentin@ti.com> <20130319192212.GA5610@kahuna> <5149A3E2.2030505@ti.com> Date: Wed, 20 Mar 2013 07:50:39 -0500 X-Google-Sender-Auth: vvFJ_5KiN4WDXaOb3NgrIJh1HOE Message-ID: Subject: Re: [PATCHv2 09/12] staging: ti-soc-thermal: fix several kernel-doc warnings and error From: Nishanth Menon To: Eduardo Valentin Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 20, 2013 at 6:56 AM, Eduardo Valentin wrote: > On 19-03-2013 15:22, Nishanth Menon wrote: >> >> On 10:54-20130319, Eduardo Valentin wrote: [..] >> You may still want to fix warnings generated by: >> ./scripts/kernel-doc -v >> drivers/staging/ti-soc-thermal/ti-bandgap.c>/dev/null >> For example - the following changes are required for proper error return >> documentation (following diff is just an hint): > > > Although I think the above is a good thing to be done, I don't think it is > considered mandatory, and for this reason, I don't believe the above should > block this patch. Basically because, after this patch, at least kernel-doc > runs successfully. > > Besides, there is very few evidence that ppl out there care much about "-v". > A quick grep+awk would inform you this. If you consider the population of C > files (around 35.4K files) inside the tree (simple find * | grep .*\\.[c,h]$ > in your tree), only around 12.0% has structured comments. Out of the files > that have structured comments, only about 11.0% has 0 warnings (including 0 > warnings with -v), that's something like ~500 files. A considerable amount > don't care about "-v" (34% out of the files with structured comments). > Actually most of them don't care about warnings (89% out of the files with > structured comments) at all. :-) Yep, commit 4092bac7 > > That said, I am going to send a separate patch to fix the "-v" later on. > Including your chunks below. Thanks. Regards, Nishanth Menon