From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755417AbaHUNtw (ORCPT ); Thu, 21 Aug 2014 09:49:52 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:36538 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551AbaHUNtt (ORCPT ); Thu, 21 Aug 2014 09:49:49 -0400 MIME-Version: 1.0 In-Reply-To: <53F5F7BF.6040809@ti.com> References: <1408381015-16042-1-git-send-email-nm@ti.com> <53F5F7BF.6040809@ti.com> Date: Thu, 21 Aug 2014 08:49:49 -0500 X-Google-Sender-Auth: hYUnwcBvNQZI039TwnAVOORHGtE Message-ID: Subject: Re: [PATCH 0/2] clk: ti: Fix up error checks in set_rate (and div 0 error) From: Nishanth Menon To: Tero Kristo Cc: Mike Turquette , linux-omap , lkml , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 21, 2014 at 8:44 AM, Tero Kristo wrote: > On 08/18/2014 07:56 PM, Nishanth Menon wrote: >> >> Hi, >> The following patches are based on v3.17-rc1 >> Prior to this series: http://slexy.org/view/s20QH6PW4x (notice the /0 div >> error spam at initial boot log) >> After this series: http://slexy.org/view/s20tPNXPf4 > > > Yeah, valid findings. However, you did not root-cause the problem, just > added a bandaid for the most obvious errors. Yep, it does seem that omap3_noncore_dpll_set_rate had the same bandaid as well :).. but checks did make sense.. > I will queue these patches for 3.17-rc fixes anyway, but will post an actual fix in a bit. Thanks for rootcausing. --- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 0/2] clk: ti: Fix up error checks in set_rate (and div 0 error) Date: Thu, 21 Aug 2014 08:49:49 -0500 Message-ID: References: <1408381015-16042-1-git-send-email-nm@ti.com> <53F5F7BF.6040809@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <53F5F7BF.6040809@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Tero Kristo Cc: Mike Turquette , linux-omap , lkml , "linux-arm-kernel@lists.infradead.org" List-Id: linux-omap@vger.kernel.org On Thu, Aug 21, 2014 at 8:44 AM, Tero Kristo wrote: > On 08/18/2014 07:56 PM, Nishanth Menon wrote: >> >> Hi, >> The following patches are based on v3.17-rc1 >> Prior to this series: http://slexy.org/view/s20QH6PW4x (notice the /0 div >> error spam at initial boot log) >> After this series: http://slexy.org/view/s20tPNXPf4 > > > Yeah, valid findings. However, you did not root-cause the problem, just > added a bandaid for the most obvious errors. Yep, it does seem that omap3_noncore_dpll_set_rate had the same bandaid as well :).. but checks did make sense.. > I will queue these patches for 3.17-rc fixes anyway, but will post an actual fix in a bit. Thanks for rootcausing. --- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Thu, 21 Aug 2014 08:49:49 -0500 Subject: [PATCH 0/2] clk: ti: Fix up error checks in set_rate (and div 0 error) In-Reply-To: <53F5F7BF.6040809@ti.com> References: <1408381015-16042-1-git-send-email-nm@ti.com> <53F5F7BF.6040809@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 21, 2014 at 8:44 AM, Tero Kristo wrote: > On 08/18/2014 07:56 PM, Nishanth Menon wrote: >> >> Hi, >> The following patches are based on v3.17-rc1 >> Prior to this series: http://slexy.org/view/s20QH6PW4x (notice the /0 div >> error spam at initial boot log) >> After this series: http://slexy.org/view/s20tPNXPf4 > > > Yeah, valid findings. However, you did not root-cause the problem, just > added a bandaid for the most obvious errors. Yep, it does seem that omap3_noncore_dpll_set_rate had the same bandaid as well :).. but checks did make sense.. > I will queue these patches for 3.17-rc fixes anyway, but will post an actual fix in a bit. Thanks for rootcausing. --- Regards, Nishanth Menon