From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH v2 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency Date: Fri, 7 Feb 2014 11:40:37 -0600 Message-ID: References: <1391786342-11812-1-git-send-email-thomas.ab@samsung.com> <1391786342-11812-3-git-send-email-thomas.ab@samsung.com> <52F50698.4060305@arm.com> <52F509BD.70903@arm.com> <52F51888.5010608@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Sudeep Holla Cc: Thomas Abraham , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "rjw@rjwysocki.net" , "linux-samsung-soc@vger.kernel.org" , "kgene.kim@samsung.com" , "t.figa@samsung.com" , "l.majewski@samsung.com" , "viresh.kumar@linaro.org" , "thomas.ab@samsung.com" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org On Fri, Feb 7, 2014 at 11:37 AM, Nishanth Menon wrote: > On Fri, Feb 7, 2014 at 11:31 AM, Sudeep Holla wrote: >> >> Yes I thought of exactly similar clock setup, but was not convinced that it >> should be part of OPP. In that case it looks like we are trying to represent >> clock internals through some OPP bindings. > > And this series (rightly) does not make it an OPP behavior. instead > all it does is to list the boost-frequencies and mark those in cpufreq > table. the description is left to the dts and implementation to the > clock drivers involved. One more thing, before I forget -> currently dev_pm_opp_[init|free]_cpufreq_table is in drivers/base/power/opp.c -> this probably should go away to drivers/cpufreq to keep opp.c independent of frameworks using it. i dont see any code that is introduced in the mentioned functions as being OPP behavior specific, instead, I consider them as cpufreq+opp behaviors, which this change fits into. Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Fri, 7 Feb 2014 11:40:37 -0600 Subject: [PATCH v2 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency In-Reply-To: References: <1391786342-11812-1-git-send-email-thomas.ab@samsung.com> <1391786342-11812-3-git-send-email-thomas.ab@samsung.com> <52F50698.4060305@arm.com> <52F509BD.70903@arm.com> <52F51888.5010608@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 7, 2014 at 11:37 AM, Nishanth Menon wrote: > On Fri, Feb 7, 2014 at 11:31 AM, Sudeep Holla wrote: >> >> Yes I thought of exactly similar clock setup, but was not convinced that it >> should be part of OPP. In that case it looks like we are trying to represent >> clock internals through some OPP bindings. > > And this series (rightly) does not make it an OPP behavior. instead > all it does is to list the boost-frequencies and mark those in cpufreq > table. the description is left to the dts and implementation to the > clock drivers involved. One more thing, before I forget -> currently dev_pm_opp_[init|free]_cpufreq_table is in drivers/base/power/opp.c -> this probably should go away to drivers/cpufreq to keep opp.c independent of frameworks using it. i dont see any code that is introduced in the mentioned functions as being OPP behavior specific, instead, I consider them as cpufreq+opp behaviors, which this change fits into. Regards, Nishanth Menon