From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 07/14] cpufreq: cpu0: OPPs can be populated at runtime Date: Thu, 10 Jul 2014 07:39:08 -0500 Message-ID: References: <1ba7771e910084cd0820c19ca5994fe1b3d6451d.1404231535.git.viresh.kumar@linaro.org> <53BD5564.2060704@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Viresh Kumar , Tony Lindgren Cc: Santosh Shilimkar , "Rafael J. Wysocki" , Shawn Guo , Lists linaro-kernel , "linux-pm@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Tomasz Figa , Stephen Boyd , Linux Kernel Mailing List , Thomas P Abraham , Arvind Chauhan , Sachin Kamat , Dave Gerlach , linux-omap List-Id: linux-arm-msm@vger.kernel.org On Thu, Jul 10, 2014 at 6:19 AM, Viresh Kumar wrote: > On 9 July 2014 20:14, Santosh Shilimkar wrote: >> Assuming you are updating bidnings as suggested by Stephen, >> patch looks good to me. >> Acked-by: Santosh Shilimkar > > Why do you still have a separate cpufreq driver for omap? > Would this patch help getting that out? > > I see this for omap: > > static inline void omap_init_cpufreq(void) > { > struct platform_device_info devinfo = { }; > > if (!of_have_populated_dt()) > devinfo.name = "omap-cpufreq"; > else > devinfo.name = "cpufreq-generic"; > platform_device_register_full(&devinfo); > } > > and it makes me believe that you were just waiting for this patch? Sorry, am away on vacation and slow on emails. The plan was to kill omap cpufreq once all platforms convert to device tree only boot. Only platform left is OMAP3 based platforms - though the date for removing non-dt support has changed a couple of kernel revisions - but we should be able to remove that entire file with this change. We will need this support to go with the solution recommended for opp modifier series[1] - where platform code will populate or add OPPs based on "speed grade" sample detection. [1]http://comments.gmane.org/gmane.linux.ports.arm.kernel/309466 --- Regards, Nishanth Menon