From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nishanth Menon <nm@ti.com>
Date: Fri, 26 Feb 2016 18:11:07 -0600
Subject: [U-Boot] [PATCH 5/6] ARM: keystone2: use SPD info to configure
 K2HK and K2E DDR3
In-Reply-To: <20160226181648.GN23166@bill-the-cat>
References: <1456415535-22689-1-git-send-email-nm@ti.com>
 <1456415535-22689-6-git-send-email-nm@ti.com>
 <20160226181648.GN23166@bill-the-cat>
Message-ID: <CAGo_u6rkgPXwvNo9ivGWLfruVwq6w655KqKh9cUxDU4VZ7h1_g@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Feb 26, 2016 at 12:16 PM, Tom Rini <trini@konsulko.com> wrote:
> On Thu, Feb 25, 2016 at 09:52:14AM -0600, Nishanth Menon wrote:
>
>> From: Vitaly Andrianov <vitalya@ti.com>
>>
>> This commit replaces hard-coded EMIF and PHY DDR3 configurations for
>> predefined SODIMMs to a calculated configuration. The SODIMM parameters
>> are read from SODIMM's SPD and used to calculated the configuration.
>>
>> The current commit supports calculation for DDR3 with 1600MHz and 1333MHz
>> only.
>>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
> [snip]
>> +#ifdef DUMP_DDR_CONFIG
>> +static void dump_phy_config(struct ddr3_phy_config *ptr)
>
> Please figure out how to do this with debug() instead.
>
> [snip]
>> +             puts("DDR3A Speed will be configured for 1333 Operation.\n");
>
> Just printf, always, it's fine, really.
>
Thank you for the review. Will try to do that and repost.


-- 
---
Regards,
Nishanth Menon