From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: update bindings for MT7629 SoC Date: Wed, 7 Nov 2018 02:07:46 -0800 Message-ID: References: <6fe4c5fbed14391b6b7fb7d44e42e133e718d6f9.1541143226.git.ryder.lee@mediatek.com> <85278445c65854dca6d4f9993a0ca2d048b9e5d8.1541143226.git.ryder.lee@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <85278445c65854dca6d4f9993a0ca2d048b9e5d8.1541143226.git.ryder.lee@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: ryder.lee@mediatek.com Cc: Linus Walleij , robh+dt@kernel.org, Matthias Brugger , linux-gpio@vger.kernel.org, weijie.gao@mediatek.com, cheng-hao.luo@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-gpio@vger.kernel.org On Mon, Nov 5, 2018 at 12:43 AM Ryder Lee wrote: > > This updates bindings for MT7629 pinctrl driver. > > Cc: Sean Wang > Signed-off-by: Ryder Lee > --- > .../devicetree/bindings/pinctrl/pinctrl-mt7622.txt | 128 +++++++++++++++++++++ > 1 file changed, 128 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > index 3b69513..4dedce4 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > @@ -3,6 +3,7 @@ > Required properties for the root node: > - compatible: Should be one of the following > "mediatek,mt7622-pinctrl" for MT7622 SoC > + "mediatek,mt7629-pinctrl" for MT7629 SoC > - reg: offset and length of the pinctrl space > > - gpio-controller: Marks the device node as a GPIO controller. > @@ -324,6 +325,133 @@ group. > "uart4_2_rts_cts" "uart" 95, 96 > "watchdog" "watchdog" 78 > > + > +== Valid values for pins, function and groups on MT7629 == > + > + Pin #: Valid values for pins > + ----------------------------- > + PIN 0: "TOP_5G_CLK" > + PIN 1: "TOP_5G_DATA" > + PIN 2: "WF0_5G_HB0" > + PIN 3: "WF0_5G_HB1" > + PIN 4: "WF0_5G_HB2" > + PIN 5: "WF0_5G_HB3" > + PIN 6: "WF0_5G_HB4" > + PIN 7: "WF0_5G_HB5" > + PIN 8: "WF0_5G_HB6" > + PIN 9: "XO_REQ" > + PIN 10: "TOP_RST_N" > + PIN 11: "SYS_WATCHDOG" > + PIN 12: "EPHY_LED0_N_JTDO" > + PIN 13: "EPHY_LED1_N_JTDI" > + PIN 14: "EPHY_LED2_N_JTMS" > + PIN 15: "EPHY_LED3_N_JTCLK" > + PIN 16: "EPHY_LED4_N_JTRST_N" > + PIN 17: "WF2G_LED_N" > + PIN 18: "WF5G_LED_N" > + PIN 19: "I2C_SDA" > + PIN 20: "I2C_SCL" > + PIN 21: "GPIO_9" > + PIN 22: "GPIO_10" > + PIN 23: "GPIO_11" > + PIN 24: "GPIO_12" > + PIN 25: "UART1_TXD" > + PIN 26: "UART1_RXD" > + PIN 27: "UART1_CTS" > + PIN 28: "UART1_RTS" > + PIN 29: "UART2_TXD" > + PIN 30: "UART2_RXD" > + PIN 31: "UART2_CTS" > + PIN 32: "UART2_RTS" > + PIN 33: "MDI_TP_P1" > + PIN 34: "MDI_TN_P1" > + PIN 35: "MDI_RP_P1" > + PIN 36: "MDI_RN_P1" > + PIN 37: "MDI_RP_P2" > + PIN 38: "MDI_RN_P2" > + PIN 39: "MDI_TP_P2" > + PIN 40: "MDI_TN_P2" > + PIN 41: "MDI_TP_P3" > + PIN 42: "MDI_TN_P3" > + PIN 43: "MDI_RP_P3" > + PIN 44: "MDI_RN_P3" > + PIN 45: "MDI_RP_P4" > + PIN 46: "MDI_RN_P4" > + PIN 47: "MDI_TP_P4" > + PIN 48: "MDI_TN_P4" > + PIN 49: "SMI_MDC" > + PIN 50: "SMI_MDIO" > + PIN 51: "PCIE_PERESET_N" > + PIN 52: "PWM_0" > + PIN 53: "GPIO_0" > + PIN 54: "GPIO_1" > + PIN 55: "GPIO_2" > + PIN 56: "GPIO_3" > + PIN 57: "GPIO_4" > + PIN 58: "GPIO_5" > + PIN 59: "GPIO_6" > + PIN 60: "GPIO_7" > + PIN 61: "GPIO_8" > + PIN 62: "SPI_CLK" > + PIN 63: "SPI_CS" > + PIN 64: "SPI_MOSI" > + PIN 65: "SPI_MISO" > + PIN 66: "SPI_WP" > + PIN 67: "SPI_HOLD" > + PIN 68: "UART0_TXD" > + PIN 69: "UART0_RXD" > + PIN 70: "TOP_2G_CLK" > + PIN 71: "TOP_2G_DATA" > + PIN 72: "WF0_2G_HB0" > + PIN 73: "WF0_2G_HB1" > + PIN 74: "WF0_2G_HB2" > + PIN 75: "WF0_2G_HB3" > + PIN 76: "WF0_2G_HB4" > + PIN 77: "WF0_2G_HB5" > + PIN 78: "WF0_2G_HB6" > + > +Valid values for function are: > + "eth", "i2c", "led", "flash", "pcie", "pwm", "spi", "uart", "watchdog" Should we add "ext" as the function and its related groups explaining in the below? It seems a missing line happens here, that is Valid values for groups are: > + > + Valid value function pins (in pin#) > + ------------------------------------------------------------------------- > + "wf0_2g" "eth" 70, 71, 72, 73, 74, 75, > + 76, 77, 78 > + "wf0_5g" "eth" 0, 1, 2, 3, 4, 5, 6, 7 > + 8, 9, 10 > + "mdc_mdio" "eth" 23, 24 > + "i2c_0" "i2c" 19, 20 > + "i2c_1" "i2c" 53, 54 > + "ephy_leds" "led" 12, 13, 14, 15, 16, 17, 18 > + "ephy0_led" "led" 12 > + "ephy1_led" "led" 13 > + "ephy2_led" "led" 14 > + "ephy3_led" "led" 15 > + "ephy4_led" "led" 16 > + "wf2g_led" "led" 17 > + "wf5g_led" "led" 18 > + "snfi" "flash" 62, 63, 64, 65, 66, 67 > + "spi_nor" "flash" 62, 63, 64, 65, 66, 67 > + "pcie_pereset" "pcie" 51 > + "pcie_wake" "pcie" 55 > + "pcie_clkreq" "pcie" 56 > + "pwm_0" "pwm" 52 > + "pwm_1" "pwm" 61 > + "spi_0" "spi" 21, 22, 23, 24 > + "spi_1" "spi" 62, 63, 64, 65 > + "spi_wp" "spi" 66 > + "spi_hold" "spi" 67 > + "uart0_txd_rxd" "uart" 68, 69 > + "uart1_0_txd_rxd" "uart" 25, 26 > + "uart1_0_cts_rts" "uart" 27, 28 > + "uart1_1_txd_rxd" "uart" 53, 54 > + "uart1_1_cts_rts" "uart" 55, 56 > + "uart2_0_txd_rxd" "uart" 29, 30 > + "uart2_0_cts_rts" "uart" 31, 32 > + "uart2_1_txd_rxd" "uart" 57, 58 > + "uart2_1_cts_rts" "uart" 59, 60 > + "watchdog" "watchdog" 11 > + > Example: > > pio: pinctrl@10211000 { > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: sean.wang@kernel.org (Sean Wang) Date: Wed, 7 Nov 2018 02:07:46 -0800 Subject: [PATCH 2/2] dt-bindings: pinctrl: update bindings for MT7629 SoC In-Reply-To: <85278445c65854dca6d4f9993a0ca2d048b9e5d8.1541143226.git.ryder.lee@mediatek.com> References: <6fe4c5fbed14391b6b7fb7d44e42e133e718d6f9.1541143226.git.ryder.lee@mediatek.com> <85278445c65854dca6d4f9993a0ca2d048b9e5d8.1541143226.git.ryder.lee@mediatek.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 5, 2018 at 12:43 AM Ryder Lee wrote: > > This updates bindings for MT7629 pinctrl driver. > > Cc: Sean Wang > Signed-off-by: Ryder Lee > --- > .../devicetree/bindings/pinctrl/pinctrl-mt7622.txt | 128 +++++++++++++++++++++ > 1 file changed, 128 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > index 3b69513..4dedce4 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt7622.txt > @@ -3,6 +3,7 @@ > Required properties for the root node: > - compatible: Should be one of the following > "mediatek,mt7622-pinctrl" for MT7622 SoC > + "mediatek,mt7629-pinctrl" for MT7629 SoC > - reg: offset and length of the pinctrl space > > - gpio-controller: Marks the device node as a GPIO controller. > @@ -324,6 +325,133 @@ group. > "uart4_2_rts_cts" "uart" 95, 96 > "watchdog" "watchdog" 78 > > + > +== Valid values for pins, function and groups on MT7629 == > + > + Pin #: Valid values for pins > + ----------------------------- > + PIN 0: "TOP_5G_CLK" > + PIN 1: "TOP_5G_DATA" > + PIN 2: "WF0_5G_HB0" > + PIN 3: "WF0_5G_HB1" > + PIN 4: "WF0_5G_HB2" > + PIN 5: "WF0_5G_HB3" > + PIN 6: "WF0_5G_HB4" > + PIN 7: "WF0_5G_HB5" > + PIN 8: "WF0_5G_HB6" > + PIN 9: "XO_REQ" > + PIN 10: "TOP_RST_N" > + PIN 11: "SYS_WATCHDOG" > + PIN 12: "EPHY_LED0_N_JTDO" > + PIN 13: "EPHY_LED1_N_JTDI" > + PIN 14: "EPHY_LED2_N_JTMS" > + PIN 15: "EPHY_LED3_N_JTCLK" > + PIN 16: "EPHY_LED4_N_JTRST_N" > + PIN 17: "WF2G_LED_N" > + PIN 18: "WF5G_LED_N" > + PIN 19: "I2C_SDA" > + PIN 20: "I2C_SCL" > + PIN 21: "GPIO_9" > + PIN 22: "GPIO_10" > + PIN 23: "GPIO_11" > + PIN 24: "GPIO_12" > + PIN 25: "UART1_TXD" > + PIN 26: "UART1_RXD" > + PIN 27: "UART1_CTS" > + PIN 28: "UART1_RTS" > + PIN 29: "UART2_TXD" > + PIN 30: "UART2_RXD" > + PIN 31: "UART2_CTS" > + PIN 32: "UART2_RTS" > + PIN 33: "MDI_TP_P1" > + PIN 34: "MDI_TN_P1" > + PIN 35: "MDI_RP_P1" > + PIN 36: "MDI_RN_P1" > + PIN 37: "MDI_RP_P2" > + PIN 38: "MDI_RN_P2" > + PIN 39: "MDI_TP_P2" > + PIN 40: "MDI_TN_P2" > + PIN 41: "MDI_TP_P3" > + PIN 42: "MDI_TN_P3" > + PIN 43: "MDI_RP_P3" > + PIN 44: "MDI_RN_P3" > + PIN 45: "MDI_RP_P4" > + PIN 46: "MDI_RN_P4" > + PIN 47: "MDI_TP_P4" > + PIN 48: "MDI_TN_P4" > + PIN 49: "SMI_MDC" > + PIN 50: "SMI_MDIO" > + PIN 51: "PCIE_PERESET_N" > + PIN 52: "PWM_0" > + PIN 53: "GPIO_0" > + PIN 54: "GPIO_1" > + PIN 55: "GPIO_2" > + PIN 56: "GPIO_3" > + PIN 57: "GPIO_4" > + PIN 58: "GPIO_5" > + PIN 59: "GPIO_6" > + PIN 60: "GPIO_7" > + PIN 61: "GPIO_8" > + PIN 62: "SPI_CLK" > + PIN 63: "SPI_CS" > + PIN 64: "SPI_MOSI" > + PIN 65: "SPI_MISO" > + PIN 66: "SPI_WP" > + PIN 67: "SPI_HOLD" > + PIN 68: "UART0_TXD" > + PIN 69: "UART0_RXD" > + PIN 70: "TOP_2G_CLK" > + PIN 71: "TOP_2G_DATA" > + PIN 72: "WF0_2G_HB0" > + PIN 73: "WF0_2G_HB1" > + PIN 74: "WF0_2G_HB2" > + PIN 75: "WF0_2G_HB3" > + PIN 76: "WF0_2G_HB4" > + PIN 77: "WF0_2G_HB5" > + PIN 78: "WF0_2G_HB6" > + > +Valid values for function are: > + "eth", "i2c", "led", "flash", "pcie", "pwm", "spi", "uart", "watchdog" Should we add "ext" as the function and its related groups explaining in the below? It seems a missing line happens here, that is Valid values for groups are: > + > + Valid value function pins (in pin#) > + ------------------------------------------------------------------------- > + "wf0_2g" "eth" 70, 71, 72, 73, 74, 75, > + 76, 77, 78 > + "wf0_5g" "eth" 0, 1, 2, 3, 4, 5, 6, 7 > + 8, 9, 10 > + "mdc_mdio" "eth" 23, 24 > + "i2c_0" "i2c" 19, 20 > + "i2c_1" "i2c" 53, 54 > + "ephy_leds" "led" 12, 13, 14, 15, 16, 17, 18 > + "ephy0_led" "led" 12 > + "ephy1_led" "led" 13 > + "ephy2_led" "led" 14 > + "ephy3_led" "led" 15 > + "ephy4_led" "led" 16 > + "wf2g_led" "led" 17 > + "wf5g_led" "led" 18 > + "snfi" "flash" 62, 63, 64, 65, 66, 67 > + "spi_nor" "flash" 62, 63, 64, 65, 66, 67 > + "pcie_pereset" "pcie" 51 > + "pcie_wake" "pcie" 55 > + "pcie_clkreq" "pcie" 56 > + "pwm_0" "pwm" 52 > + "pwm_1" "pwm" 61 > + "spi_0" "spi" 21, 22, 23, 24 > + "spi_1" "spi" 62, 63, 64, 65 > + "spi_wp" "spi" 66 > + "spi_hold" "spi" 67 > + "uart0_txd_rxd" "uart" 68, 69 > + "uart1_0_txd_rxd" "uart" 25, 26 > + "uart1_0_cts_rts" "uart" 27, 28 > + "uart1_1_txd_rxd" "uart" 53, 54 > + "uart1_1_cts_rts" "uart" 55, 56 > + "uart2_0_txd_rxd" "uart" 29, 30 > + "uart2_0_cts_rts" "uart" 31, 32 > + "uart2_1_txd_rxd" "uart" 57, 58 > + "uart2_1_cts_rts" "uart" 59, 60 > + "watchdog" "watchdog" 11 > + > Example: > > pio: pinctrl at 10211000 { > -- > 1.9.1 >