From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46605)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donald.open@gmail.com>) id 1Swpix-0002M0-PA
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 03:21:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <donald.open@gmail.com>) id 1Swpiw-0001Od-TC
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 03:21:35 -0400
Received: from mail-wg0-f53.google.com ([74.125.82.53]:58157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donald.open@gmail.com>) id 1Swpiw-0001OR-JI
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 03:21:34 -0400
Received: by wgbfm10 with SMTP id fm10so6122205wgb.10
	for <qemu-devel@nongnu.org>; Thu, 02 Aug 2012 00:21:33 -0700 (PDT)
MIME-Version: 1.0
Sender: donald.open@gmail.com
In-Reply-To: <CAJSP0QUfTo3miYKEEo8P0y9+zjSsxTBTU+9tOQjYveuwC5=6uA@mail.gmail.com>
References: <1343753510-24661-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<1343753510-24661-3-git-send-email-wdongxu@linux.vnet.ibm.com>
	<CAJSP0QUfTo3miYKEEo8P0y9+zjSsxTBTU+9tOQjYveuwC5=6uA@mail.gmail.com>
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Date: Thu, 2 Aug 2012 15:20:53 +0800
Message-ID: <CAGrFBshK7znDQ=uRsZLwmhQn0zji2QjsEMD0+zm-7hD9UZnYhw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 3/6] add-cow file format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Wed, Aug 1, 2012 at 11:31 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang
> <wdongxu@linux.vnet.ibm.com> wrote:
>> +    if (backing_filename) {
>> +        header.features |= ADD_COW_F_BACKING_FILE;
>> +        header.backing_filename_offset = sizeof(header) + 16 * 2;
>
> It's not obvious what 16 * 2 is.

Okay we give meaningful constant later.

>
>> +    ret = bdrv_pwrite(bs, sizeof(le_header) + 16,
>> +        image_format ? image_format : "raw",
>> +        image_format ? sizeof(image_format) : sizeof("raw"));
>
> sizeof(image_format)?  I think this should be strlen(image_format).

Okay. thanks.

>
> Stefan
>