All of lore.kernel.org
 help / color / mirror / Atom feed
From: cknvme@gmail.com (royy walls)
Subject: [PATCH] nvme-cli: Fix to the logic of the nvme list-ns <device> -a command.
Date: Mon, 10 Jul 2017 01:40:02 -0700	[thread overview]
Message-ID: <CAGrovxXZSQVN3Rtmii4PPfQxjnaVp3=QyABzejPN0NALXoFz1Q@mail.gmail.com> (raw)
In-Reply-To: <11488ccc-3243-5191-08c6-0faa184620a8@huawei.com>

With this approach
(http://lists.infradead.org/pipermail/linux-nvme/2017-April/009805.html)
all the future caller's including any plug-ins will require writing a
code with "!!".

I wanted to get rid of "!!" approach which makes the code simpler for
everyone at first glance, only if everyone agrees with that change.

On Mon, Jul 10, 2017@1:07 AM, Guan Junxiong <guanjunxiong@huawei.com> wrote:
> Hi,Chaitanya
> Thanks for your effort.
>
> On 2017/7/9 8:36, Chaitanya Kulkarni wrote:
>> This fix will reverse the logic of the -a parm in the nvme list-ns
>> command. Currently, the -a option only shows the attached namespaces
>> and not all the namespaces. By removing the extra ! it will show attached
>> inactive namespaces with -a option as mentioned in the help text.
>>
> Actually, the approach of reversing the logic of the -a option doesn't
> keep the consistence of literal input parameter __bool__ __all__ of the
> nvme_identify_ns_list function.
>
> By the way ,I had sent a patch to fix this two month ago but Keith missed it.
> A new updated patch of this was sent a minute ago. Hope Keith would catch it.
> (The origin link is: http://lists.infradead.org/pipermail/linux-nvme/2017-April/009805.html
> )
>
> Thanks
> .
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2017-07-10  8:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09  0:36 [PATCH] nvme-cli: Fix to the logic of the nvme list-ns <device> -a command Chaitanya Kulkarni
2017-07-10  5:44 ` Sagi Grimberg
2017-07-10  8:07 ` Guan Junxiong
2017-07-10  8:40   ` royy walls [this message]
2017-07-10 16:44     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGrovxXZSQVN3Rtmii4PPfQxjnaVp3=QyABzejPN0NALXoFz1Q@mail.gmail.com' \
    --to=cknvme@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.