Re: [PATCH 7/8] mm: drop page_index/page_file_offset and convert swap helpers to use folio

From: Barry Song <21cnbao@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Kairui Song <kasong@tencent.com>,
	linux-mm@kvack.org,  Andrew Morton <akpm@linux-foundation.org>,
	"Huang, Ying" <ying.huang@intel.com>,
	 Chris Li <chrisl@kernel.org>, Barry Song <v-songbaohua@oppo.com>,
	 Ryan Roberts <ryan.roberts@arm.com>, Neil Brown <neilb@suse.de>,
	Minchan Kim <minchan@kernel.org>,
	 Hugh Dickins <hughd@google.com>,
	David Hildenbrand <david@redhat.com>,
	Yosry Ahmed <yosryahmed@google.com>,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] mm: drop page_index/page_file_offset and convert swap helpers to use folio
Date: Thu, 18 Apr 2024 15:55:17 +1200	[thread overview]
Message-ID: <CAGsJ_4z5R++Fp+rOj08ZJvGpnqbhBDgQ0J6YvctNDvtND2oyEg@mail.gmail.com> (raw)
In-Reply-To: <ZiCT5rNr5oxdFsce@casper.infradead.org>

On Thu, Apr 18, 2024 at 3:31 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Thu, Apr 18, 2024 at 01:55:28PM +1200, Barry Song wrote:
> > I also find it rather odd that folio_file_page() is utilized for both
> > swp and file.
> >
> > mm/memory.c <<do_swap_page>>
> >              page = folio_file_page(folio, swp_offset(entry));
> > mm/swap_state.c <<swapin_readahead>>
> >              return folio_file_page(folio, swp_offset(entry));
> > mm/swapfile.c <<unuse_pte>>
> >              page = folio_file_page(folio, swp_offset(entry));
> >
> > Do you believe it's worthwhile to tidy up?
>
> Why do you find it odd?  What would you propose instead?

i'd prefer something like folio_swap_page(folio, entry);