All of lore.kernel.org
 help / color / mirror / Atom feed
From: 21cnbao@gmail.com (Barry Song)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 RESEND] ARM: prima2: move to use REGMAP APIs for rtciobrg
Date: Thu, 16 Apr 2015 10:29:19 +0800	[thread overview]
Message-ID: <CAGsJ_4zohW8m+2OLoye1G3aHxZUPHkynaY2vDf7z+o03QoSiuQ@mail.gmail.com> (raw)
In-Reply-To: <2891950.ACQLuhXHau@wuerfel>

2015-04-15 23:37 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
> On Tuesday 14 April 2015 11:55:55 Barry Song wrote:
>> From: Guo Zeng <Guo.Zeng@csr.com>
>>
>> all devices behind rtciobrg needs a special way to access. currently they
>> are using a platform-specific API.
>> this patch moves to REGMAP, then clients can use regmap APIs to read/write.
>> for the moment, old APIs are still kept, once all clients move to regmap,
>> old APIs will be dropped.
>>
>> this patch also does minor clean for comments, authors statement.
>>
>> Signed-off-by: Guo Zeng <Guo.Zeng@csr.com>
>> Signed-off-by: Barry Song <Baohua.Song@csr.com>
>>
>
> I've finally managed to take a look at the two patches.
>
> For this one, the implementation looks ok in principle, though I wonder
> if you would be able to move the code to a more appropriate location,
> possibly drivers/bus, drivers/soc or into the rtc-sirfsoc driver.
>
> What devices specifically are abstracted by the rtciobrg?

devices behind rtc io bridge are abstracted by it. currently, the
users include rtc drivers, system power management and reset logic.
machine-level pm codes like sleep.S and pm.c are using it too.

for the moment, i feel it is better to be in mach-prima2 since it is
still involved in several machine modules.

>
>         Arnd

-barry

      reply	other threads:[~2015-04-16  2:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 11:55 [PATCH 1/2 RESEND] ARM: prima2: move to use REGMAP APIs for rtciobrg Barry Song
2015-04-14 11:55 ` [PATCH 2/2 RESEND] ARM: prima2: add NetWork on Chip driver for atlas7 Barry Song
2015-04-15 15:53   ` Arnd Bergmann
2015-04-16  2:48     ` Barry Song
2015-04-21  3:06       ` Barry Song
2015-04-15 15:37 ` [PATCH 1/2 RESEND] ARM: prima2: move to use REGMAP APIs for rtciobrg Arnd Bergmann
2015-04-16  2:29   ` Barry Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGsJ_4zohW8m+2OLoye1G3aHxZUPHkynaY2vDf7z+o03QoSiuQ@mail.gmail.com \
    --to=21cnbao@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.