From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com ([209.85.128.179]:35034 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S947031AbdDYT3m (ORCPT ); Tue, 25 Apr 2017 15:29:42 -0400 Received: by mail-wr0-f179.google.com with SMTP id z52so73003127wrc.2 for ; Tue, 25 Apr 2017 12:29:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170418201702.57019-2-code@mmayer.net> References: <20170418201702.57019-1-code@mmayer.net> <20170418201702.57019-2-code@mmayer.net> From: Markus Mayer Date: Tue, 25 Apr 2017 12:29:40 -0700 Message-ID: Subject: Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors To: Rob Herring Cc: Jean Delvare , Guenter Roeck , Mark Rutland , Florian Fainelli , Broadcom Kernel List , Linux HWMON List , Device Tree List , ARM Kernel List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org Hi Rob, On 18 April 2017 at 13:17, Markus Mayer wrote: > From: Markus Mayer > > Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). Would you be able to have a look at this binding? The driver won't be upstreamed as hwmon driver (as per Guenter's comments). I am currently converting the driver to a "soc" driver instead, but the proposed binding remains unchanged. If you have comments or suggestions, I would like to incorporate them with the new series I will be sending out. Thanks, -Markus > Signed-off-by: Markus Mayer > --- > .../devicetree/bindings/hwmon/brcmstb-dpfe.txt | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt b/Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt > new file mode 100644 > index 0000000..3519197 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt > @@ -0,0 +1,68 @@ > +DDR PHY Front End (DPFE) for Broadcom STB > +========================================= > + > +DPFE and the DPFE firmware provide an interface for the host CPU to > +communicate with the DCPU, which resides inside the DDR PHY. > + > +There are three memory regions for interacting with the DCPU. > + > +The DCPU Register Space > +----------------------- > + > +Required properties: > + - compatible: must be one of brcm,bcm7271-dpfe-cpu, brcm,dpfe-cpu-v12.0.0.0 > + or brcm,dpfe-cpu > + - reg: must reference the start address and length of the DCPU register > + space > + > +Optional properties: > + - cell-index: the index of the DPFE instance; will default to 0 if not set > + > +Example: > + dpfe_cpu0: dpfe-cpu@f1132000 { > + compatible = "brcm,bcm7271-dpfe-cpu", > + "brcm,dpfe-cpu-v12.0.0.0", > + "brcm,dpfe-cpu"; > + reg = <0xf1132000 0x180>; > + cell-index = <0>; > + }; > + > +The DCPU Data Memory Space > +-------------------------- > + > +Required properties: > + - compatible: must be one of brcm,bcm7271-dpfe-dmem, brcm,dpfe-dmem-v12.0.0.0 > + or brcm,dpfe-dmem > + - reg: must reference the start address and length of the DCPU DMEM space > + > +Optional properties: > + - cell-index: the index of the DPFE instance; will default to 0 if not set > + > +Example: > + dpfe_dmem0: dpfe-dmem@f1134000 { > + compatible = "brcm,bcm7271-dpfe-dmem", > + "brcm,dpfe-dmem-v12.0.0.0", > + "brcm,dpfe-dmem"; > + reg = <0xf1134000 0x1000>; > + cell-index = <0>; > + }; > + > +The DCPU Instruction Memory Space > +--------------------------------- > + > +Required properties: > + - compatible: must be one of brcm,bcm7271-dpfe-imem, brcm,dpfe-imem-v12.0.0.0 > + or brcm,dpfe-imem > + - reg: must reference the start address and length of the DCPU IMEM space > + > +Optional properties: > + - cell-index: the index of the DPFE instance; will default to 0 if not set > + > +Example: > + dpfe_imem0: dpfe-imem@f1138000 { > + compatible = "brcm,bcm7271-dpfe-imem", > + "brcm,dpfe-imem-v12.0.0.0", > + "brcm,dpfe-imem"; > + reg = <0xf1138000 0x4000>; > + cell-index = <0>; > + }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: markus.mayer@broadcom.com (Markus Mayer) Date: Tue, 25 Apr 2017 12:29:40 -0700 Subject: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors In-Reply-To: <20170418201702.57019-2-code@mmayer.net> References: <20170418201702.57019-1-code@mmayer.net> <20170418201702.57019-2-code@mmayer.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, On 18 April 2017 at 13:17, Markus Mayer wrote: > From: Markus Mayer > > Provide bindings for the Broadcom STB DDR PHY Front End (DPFE). Would you be able to have a look at this binding? The driver won't be upstreamed as hwmon driver (as per Guenter's comments). I am currently converting the driver to a "soc" driver instead, but the proposed binding remains unchanged. If you have comments or suggestions, I would like to incorporate them with the new series I will be sending out. Thanks, -Markus > Signed-off-by: Markus Mayer > --- > .../devicetree/bindings/hwmon/brcmstb-dpfe.txt | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt b/Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt > new file mode 100644 > index 0000000..3519197 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/brcmstb-dpfe.txt > @@ -0,0 +1,68 @@ > +DDR PHY Front End (DPFE) for Broadcom STB > +========================================= > + > +DPFE and the DPFE firmware provide an interface for the host CPU to > +communicate with the DCPU, which resides inside the DDR PHY. > + > +There are three memory regions for interacting with the DCPU. > + > +The DCPU Register Space > +----------------------- > + > +Required properties: > + - compatible: must be one of brcm,bcm7271-dpfe-cpu, brcm,dpfe-cpu-v12.0.0.0 > + or brcm,dpfe-cpu > + - reg: must reference the start address and length of the DCPU register > + space > + > +Optional properties: > + - cell-index: the index of the DPFE instance; will default to 0 if not set > + > +Example: > + dpfe_cpu0: dpfe-cpu at f1132000 { > + compatible = "brcm,bcm7271-dpfe-cpu", > + "brcm,dpfe-cpu-v12.0.0.0", > + "brcm,dpfe-cpu"; > + reg = <0xf1132000 0x180>; > + cell-index = <0>; > + }; > + > +The DCPU Data Memory Space > +-------------------------- > + > +Required properties: > + - compatible: must be one of brcm,bcm7271-dpfe-dmem, brcm,dpfe-dmem-v12.0.0.0 > + or brcm,dpfe-dmem > + - reg: must reference the start address and length of the DCPU DMEM space > + > +Optional properties: > + - cell-index: the index of the DPFE instance; will default to 0 if not set > + > +Example: > + dpfe_dmem0: dpfe-dmem at f1134000 { > + compatible = "brcm,bcm7271-dpfe-dmem", > + "brcm,dpfe-dmem-v12.0.0.0", > + "brcm,dpfe-dmem"; > + reg = <0xf1134000 0x1000>; > + cell-index = <0>; > + }; > + > +The DCPU Instruction Memory Space > +--------------------------------- > + > +Required properties: > + - compatible: must be one of brcm,bcm7271-dpfe-imem, brcm,dpfe-imem-v12.0.0.0 > + or brcm,dpfe-imem > + - reg: must reference the start address and length of the DCPU IMEM space > + > +Optional properties: > + - cell-index: the index of the DPFE instance; will default to 0 if not set > + > +Example: > + dpfe_imem0: dpfe-imem at f1138000 { > + compatible = "brcm,bcm7271-dpfe-imem", > + "brcm,dpfe-imem-v12.0.0.0", > + "brcm,dpfe-imem"; > + reg = <0xf1138000 0x4000>; > + cell-index = <0>; > + }; > -- > 2.7.4 >