From mboxrd@z Thu Jan  1 00:00:00 1970
From: Siva Chandra <sivachandra@google.com>
Subject: Re: [PATCH] drm/i915: Add a DRM property "psr"
Date: Wed, 19 Mar 2014 10:04:12 -0700
Message-ID: <CAGyQ6gyeBXtrM88tBFZm00UMP+8yH2SRdUA4yWDhGYUGZy6mhw@mail.gmail.com>
References: <1395172267-9203-1-git-send-email-sivachandra@chromium.org>
 <20140318130620.07fa8680@jbarnes-desktop>
 <CAGyQ6gzRPNRpCDHWLL3P6_+E52v2XjZuOfNOqrQ-=Zvc5aOPCA@mail.gmail.com>
 <20140319084438.GM30571@phenom.ffwll.local>
 <20140319150338.GA27717@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7C872909D2
 for <intel-gfx@lists.freedesktop.org>; Wed, 19 Mar 2014 10:04:15 -0700 (PDT)
Received: by mail-ee0-f49.google.com with SMTP id c41so6766052eek.22
 for <intel-gfx@lists.freedesktop.org>; Wed, 19 Mar 2014 10:04:13 -0700 (PDT)
In-Reply-To: <20140319150338.GA27717@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 19, 2014 at 8:03 AM, Damien Lespiau
<damien.lespiau@intel.com> wrote:
> On Wed, Mar 19, 2014 at 09:44:38AM +0100, Daniel Vetter wrote:
>> On Tue, Mar 18, 2014 at 01:53:56PM -0700, Siva Chandra wrote:
>> > We are testing a few PSR panels; Having a knob to turn PSR on and off
>> > would be of great convenience for manual testing and for test scripts.
>>
>> Is the module param not good enough for that? Iirc we recheck that every
>> time ...
>
> (the module parameter is accessible through a file in sysfs:
>   /sys/module/i915/parameters/enable_psr)

As I mentioned in the other mail, this param is not active and I
couldn't think of any neat solution to make it active.

> Alternatively, doesn't it look like something that belongs to debugfs?
> ie not an API with a stability guarantee?

PSR is part of the eDP standard now. Also, we are only bringing in an
on/off knob. Is really going to cause us stability issues?

Thanks,
Siva Chandra