From mboxrd@z Thu Jan 1 00:00:00 1970 From: Siva Chandra Subject: Re: [PATCH] drm/i915: Add a DRM property "psr" Date: Thu, 20 Mar 2014 06:31:42 -0700 Message-ID: References: <1395172267-9203-1-git-send-email-sivachandra@chromium.org> <20140318130620.07fa8680@jbarnes-desktop> <20140319084438.GM30571@phenom.ffwll.local> <20140319150338.GA27717@strange.amr.corp.intel.com> <87r45xw3a0.fsf@intel.com> <87a9cl2e8w.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id B52216E074 for ; Thu, 20 Mar 2014 06:31:44 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id e49so673886eek.3 for ; Thu, 20 Mar 2014 06:31:42 -0700 (PDT) In-Reply-To: <87a9cl2e8w.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 20, 2014 at 6:25 AM, Jani Nikula wrote: > On Thu, 20 Mar 2014, Siva Chandra wrote: >> On Thu, Mar 20, 2014 at 3:52 AM, Jani Nikula >> wrote: >>> If this is for testing only, and the module parameter does not quite cut >>> it, please add it to debugfs. That we can pretty much change at will. >> >> If I understand correctly, you are suggesting that the on/off knob >> live in debugfs. So, should the module param in sysfs mirror this >> debugfs knob? > > I guess the simplest thing to move forward would be something to update > psr state after the module parameter has been changed, although it's > perhaps a bit clumsy to use. Couldn't understand. May be an example to illustrate what you are saying? Thanks, Siva Chandra