From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Gora <dg@adax.com>
Subject: Re: [PATCH 1/2] kni: add API to set link status on
	kernel interface
Date: Tue, 18 Sep 2018 14:41:38 -0300
Message-ID: <CAGyogRY1AxbF0y8fn6m2MfwvEFx=SA1V61x+VRwqhoFXdx2ZhA@mail.gmail.com>
References: <20180911232906.18352-1-dg@adax.com>
 <20180911232906.18352-2-dg@adax.com>
 <0e366549-2ae6-2e70-6e60-7e5970b1a98e@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev@dpdk.org, Igor Ryzhov <iryzhov@nfware.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
 [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id A5D935B16
 for <dev@dpdk.org>; Tue, 18 Sep 2018 19:42:19 +0200 (CEST)
Received: by mail-wm1-f67.google.com with SMTP id n11-v6so3816355wmc.2
 for <dev@dpdk.org>; Tue, 18 Sep 2018 10:42:19 -0700 (PDT)
In-Reply-To: <0e366549-2ae6-2e70-6e60-7e5970b1a98e@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Sep 18, 2018 at 1:54 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 9/12/2018 12:29 AM, Dan Gora wrote:
>> Add a new API function to KNI, rte_kni_update_link() to allow DPDK
>> applications to update the link status for KNI network interfaces in
>> the linux kernel.
>>
>> Signed-off-by: Dan Gora <dg@adax.com>
>
> +1 to sysfs implementation.
>
> But right now this API is not used at all which makes it hard to test and catch
> when API broken.
> Can you please implement the API either on kni sample app or kni unit test?
>
> Also you need to add new API to .map file for shared library build. (you would
> catch this if API implemented somewhere...)

Understood.. I'll work on this ASAP.

-dan