* [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
@ 2021-08-22 20:05 José Luis Salvador Rufo
2021-08-22 20:27 ` Romain Naour
2021-08-24 21:53 ` Thomas Petazzoni
0 siblings, 2 replies; 11+ messages in thread
From: José Luis Salvador Rufo @ 2021-08-22 20:05 UTC (permalink / raw)
To: buildroot, Romain Naour, Philippe Serbruyns
Cc: José Luis Salvador Rufo, Yann E . MORIN, Thomas Petazzoni
This patch fixes the `make` executed from the `kernel.m4` in
cross-platform-compilations environments:
https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
---
Hello all.
@Romain Naour, this patch will fix the buildroot gitlab CI.
@Philippe Serbruyns, this patch will fix your issue with your rpi4.
package/zfs/zfs.mk | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
index 3b1afb419a..24064cba82 100644
--- a/package/zfs/zfs.mk
+++ b/package/zfs/zfs.mk
@@ -13,6 +13,19 @@ ZFS_CPE_ID_PRODUCT = openzfs
ZFS_AUTORECONF = YES
+# cross compile environment for linux kernel module
+ZFS_MAKE_ENV = \
+ HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
+ ARCH=$(KERNEL_ARCH) \
+ CROSS_COMPILE="$(TARGET_CROSS)" \
+ DEPMOD=$(HOST_DIR)/sbin/depmod
+# `./configure` will execute a `make modules` test case
+ZFS_CONF_ENV = \
+ HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
+ ARCH=$(KERNEL_ARCH) \
+ CROSS_COMPILE="$(TARGET_CROSS)" \
+ DEPMOD=$(HOST_DIR)/sbin/depmod
+
ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
# sysvinit installs only a commented-out modules-load.d/ config file
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-22 20:05 [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations José Luis Salvador Rufo
@ 2021-08-22 20:27 ` Romain Naour
2021-08-22 20:38 ` José Luis Salvador Rufo
2021-08-24 21:53 ` Thomas Petazzoni
1 sibling, 1 reply; 11+ messages in thread
From: Romain Naour @ 2021-08-22 20:27 UTC (permalink / raw)
To: José Luis Salvador Rufo, buildroot, Philippe Serbruyns
Cc: Yann E . MORIN, Thomas Petazzoni
Hello José Luis,
Le 22/08/2021 à 22:05, José Luis Salvador Rufo a écrit :
> This patch fixes the `make` executed from the `kernel.m4` in
> cross-platform-compilations environments:
> https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
>
> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> ---
> Hello all.
>
> @Romain Naour, this patch will fix the buildroot gitlab CI.
Indeed it fix the issue!
Tested-by: Romain Naour <romain.naour@gmail.com>
>
> @Philippe Serbruyns, this patch will fix your issue with your rpi4.
>
> package/zfs/zfs.mk | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
> index 3b1afb419a..24064cba82 100644
> --- a/package/zfs/zfs.mk
> +++ b/package/zfs/zfs.mk
> @@ -13,6 +13,19 @@ ZFS_CPE_ID_PRODUCT = openzfs
>
> ZFS_AUTORECONF = YES
>
> +# cross compile environment for linux kernel module
> +ZFS_MAKE_ENV = \
> + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> + ARCH=$(KERNEL_ARCH) \
> + CROSS_COMPILE="$(TARGET_CROSS)" \
> + DEPMOD=$(HOST_DIR)/sbin/depmod
You can replace all 4 lines with $(LINUX_MAKE_FLAGS) here instead.
> +# `./configure` will execute a `make modules` test case
> +ZFS_CONF_ENV = \
> + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> + ARCH=$(KERNEL_ARCH) \
> + CROSS_COMPILE="$(TARGET_CROSS)" \
> + DEPMOD=$(HOST_DIR)/sbin/depmod
Same here.
> +
> ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
>
> # sysvinit installs only a commented-out modules-load.d/ config file
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-22 20:27 ` Romain Naour
@ 2021-08-22 20:38 ` José Luis Salvador Rufo
2021-08-22 20:52 ` Romain Naour
0 siblings, 1 reply; 11+ messages in thread
From: José Luis Salvador Rufo @ 2021-08-22 20:38 UTC (permalink / raw)
To: Romain Naour
Cc: Thomas Petazzoni, Philippe Serbruyns, Yann E . MORIN, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 2320 bytes --]
Hello Romain,
El dom, 22 ago 2021 a las 22:27, Romain Naour (<romain.naour@gmail.com>)
escribió:
> Hello José Luis,
>
> Le 22/08/2021 à 22:05, José Luis Salvador Rufo a écrit :
> > This patch fixes the `make` executed from the `kernel.m4` in
> > cross-platform-compilations environments:
> > https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> >
> > Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> > ---
> > Hello all.
> >
> > @Romain Naour, this patch will fix the buildroot gitlab CI.
>
> Indeed it fix the issue!
>
> Tested-by: Romain Naour <romain.naour@gmail.com>
>
> >
> > @Philippe Serbruyns, this patch will fix your issue with your rpi4.
> >
> > package/zfs/zfs.mk | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
> > index 3b1afb419a..24064cba82 100644
> > --- a/package/zfs/zfs.mk
> > +++ b/package/zfs/zfs.mk
> > @@ -13,6 +13,19 @@ ZFS_CPE_ID_PRODUCT = openzfs
> >
> > ZFS_AUTORECONF = YES
> >
> > +# cross compile environment for linux kernel module
> > +ZFS_MAKE_ENV = \
> > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > + ARCH=$(KERNEL_ARCH) \
> > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > + DEPMOD=$(HOST_DIR)/sbin/depmod
>
> You can replace all 4 lines with $(LINUX_MAKE_FLAGS) here instead.
>
Sorry, you can not. LINUX_MAKE_FLAGS includes INSTALL_MOD_PATH, and must be
empty for kernel modules. If we use LINUX_MAKE_FLAGS, the module output
will be TARGET_DIR/INSTALL_MOD_PATH, as you can see in pkg-generic.mk at
line 77. I already lost ~1-2h because of this :-(.
The alternative to using $(LINUX_MAKE_FLAGS) is empty the INSTALL_MOD_PATH
as follows:
ZFS_MAKE_ENV = \
$(LINUX_MAKE_FLAGS) \
INSTALL_MOD_PATH=
What do you prefer?
>
> > +# `./configure` will execute a `make modules` test case
> > +ZFS_CONF_ENV = \
> > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > + ARCH=$(KERNEL_ARCH) \
> > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > + DEPMOD=$(HOST_DIR)/sbin/depmod
>
> Same here.
>
>
>
> > +
> > ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
> >
> > # sysvinit installs only a commented-out modules-load.d/ config file
> >
>
>
[-- Attachment #1.2: Type: text/html, Size: 3753 bytes --]
[-- Attachment #2: Type: text/plain, Size: 145 bytes --]
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-22 20:38 ` José Luis Salvador Rufo
@ 2021-08-22 20:52 ` Romain Naour
2021-08-22 21:27 ` José Luis Salvador Rufo
0 siblings, 1 reply; 11+ messages in thread
From: Romain Naour @ 2021-08-22 20:52 UTC (permalink / raw)
To: José Luis Salvador Rufo
Cc: Thomas Petazzoni, Philippe Serbruyns, Yann E . MORIN, buildroot
Hello José Luis,
Le 22/08/2021 à 22:38, José Luis Salvador Rufo a écrit :
> Hello Romain,
>
> El dom, 22 ago 2021 a las 22:27, Romain Naour (<romain.naour@gmail.com
> <mailto:romain.naour@gmail.com>>) escribió:
>
> Hello José Luis,
>
> Le 22/08/2021 à 22:05, José Luis Salvador Rufo a écrit :
> > This patch fixes the `make` executed from the `kernel.m4` in
> > cross-platform-compilations environments:
> > https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> <https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588>
> >
> > Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com
> <mailto:salvador.joseluis@gmail.com>>
> > ---
> > Hello all.
> >
> > @Romain Naour, this patch will fix the buildroot gitlab CI.
>
> Indeed it fix the issue!
>
> Tested-by: Romain Naour <romain.naour@gmail.com <mailto:romain.naour@gmail.com>>
>
> >
> > @Philippe Serbruyns, this patch will fix your issue with your rpi4.
> >
> > package/zfs/zfs.mk <http://zfs.mk> | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/package/zfs/zfs.mk <http://zfs.mk> b/package/zfs/zfs.mk
> <http://zfs.mk>
> > index 3b1afb419a..24064cba82 100644
> > --- a/package/zfs/zfs.mk <http://zfs.mk>
> > +++ b/package/zfs/zfs.mk <http://zfs.mk>
> > @@ -13,6 +13,19 @@ ZFS_CPE_ID_PRODUCT = openzfs
> >
> > ZFS_AUTORECONF = YES
> >
> > +# cross compile environment for linux kernel module
> > +ZFS_MAKE_ENV = \
> > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > + ARCH=$(KERNEL_ARCH) \
> > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > + DEPMOD=$(HOST_DIR)/sbin/depmod
>
> You can replace all 4 lines with $(LINUX_MAKE_FLAGS) here instead.
>
> Sorry, you can not. LINUX_MAKE_FLAGS includes INSTALL_MOD_PATH, and must be
> empty for kernel modules. If we use LINUX_MAKE_FLAGS, the module output will be
> TARGET_DIR/INSTALL_MOD_PATH, as you can see in pkg-generic.mk
> <http://pkg-generic.mk> at line 77. I already lost ~1-2h because of this :-(.
This check allow to detect issues on a build system.
Other packages building an out of tree kernel module is able to use
LINUX_MAKE_FLAGS (except linux-fusion).
>
> The alternative to using $(LINUX_MAKE_FLAGS) is empty the INSTALL_MOD_PATH as
> follows:
> ZFS_MAKE_ENV = \
> $(LINUX_MAKE_FLAGS) \
> INSTALL_MOD_PATH=
>
> What do you prefer?
If possible, a zfs patch.
Otherwise I would suggest to add a comment about the reason why LINUX_MAKE_FLAGS
can't be used.
Best regards,
Romain
>
>
> > +# `./configure` will execute a `make modules` test case
> > +ZFS_CONF_ENV = \
> > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > + ARCH=$(KERNEL_ARCH) \
> > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > + DEPMOD=$(HOST_DIR)/sbin/depmod
>
> Same here.
>
>
>
> > +
> > ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
> >
> > # sysvinit installs only a commented-out modules-load.d/ config file
> >
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-22 20:52 ` Romain Naour
@ 2021-08-22 21:27 ` José Luis Salvador Rufo
2021-08-22 21:43 ` Romain Naour
0 siblings, 1 reply; 11+ messages in thread
From: José Luis Salvador Rufo @ 2021-08-22 21:27 UTC (permalink / raw)
To: Romain Naour
Cc: Thomas Petazzoni, Philippe Serbruyns, Yann E . MORIN, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 4321 bytes --]
Hello Romain Naour,
El dom, 22 ago 2021 a las 22:52, Romain Naour (<romain.naour@gmail.com>)
escribió:
> Hello José Luis,
>
> Le 22/08/2021 à 22:38, José Luis Salvador Rufo a écrit :
> > Hello Romain,
> >
> > El dom, 22 ago 2021 a las 22:27, Romain Naour (<romain.naour@gmail.com
> > <mailto:romain.naour@gmail.com>>) escribió:
> >
> > Hello José Luis,
> >
> > Le 22/08/2021 à 22:05, José Luis Salvador Rufo a écrit :
> > > This patch fixes the `make` executed from the `kernel.m4` in
> > > cross-platform-compilations environments:
> > >
> https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> > <https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> >
> > >
> > > Signed-off-by: José Luis Salvador Rufo <
> salvador.joseluis@gmail.com
> > <mailto:salvador.joseluis@gmail.com>>
> > > ---
> > > Hello all.
> > >
> > > @Romain Naour, this patch will fix the buildroot gitlab CI.
> >
> > Indeed it fix the issue!
> >
> > Tested-by: Romain Naour <romain.naour@gmail.com <mailto:
> romain.naour@gmail.com>>
> >
> > >
> > > @Philippe Serbruyns, this patch will fix your issue with your rpi4.
> > >
> > > package/zfs/zfs.mk <http://zfs.mk> | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/package/zfs/zfs.mk <http://zfs.mk> b/package/zfs/
> zfs.mk
> > <http://zfs.mk>
> > > index 3b1afb419a..24064cba82 100644
> > > --- a/package/zfs/zfs.mk <http://zfs.mk>
> > > +++ b/package/zfs/zfs.mk <http://zfs.mk>
> > > @@ -13,6 +13,19 @@ ZFS_CPE_ID_PRODUCT = openzfs
> > >
> > > ZFS_AUTORECONF = YES
> > >
> > > +# cross compile environment for linux kernel module
> > > +ZFS_MAKE_ENV = \
> > > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > > + ARCH=$(KERNEL_ARCH) \
> > > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > > + DEPMOD=$(HOST_DIR)/sbin/depmod
> >
> > You can replace all 4 lines with $(LINUX_MAKE_FLAGS) here instead.
> >
> > Sorry, you can not. LINUX_MAKE_FLAGS includes INSTALL_MOD_PATH, and must
> be
> > empty for kernel modules. If we use LINUX_MAKE_FLAGS, the module output
> will be
> > TARGET_DIR/INSTALL_MOD_PATH, as you can see in pkg-generic.mk
> > <http://pkg-generic.mk> at line 77. I already lost ~1-2h because of
> this :-(.
>
> This check allow to detect issues on a build system.
> Other packages building an out of tree kernel module is able to use
> LINUX_MAKE_FLAGS (except linux-fusion).
>
> >
> > The alternative to using $(LINUX_MAKE_FLAGS) is empty
> the INSTALL_MOD_PATH as
> > follows:
> > ZFS_MAKE_ENV = \
> > $(LINUX_MAKE_FLAGS) \
> > INSTALL_MOD_PATH=
> >
> > What do you prefer?
>
> If possible, a zfs patch.
>
Here is the "problem":
https://github.com/openzfs/zfs/blob/zfs-2.0.5/module/Makefile.in#L79
> INSTALL_MOD_PATH=$(DESTDIR)$(INSTALL_MOD_PATH)
and
https://git.buildroot.net/buildroot/tree/package/pkg-generic.mk?h=2021.08-rc2#n77
> $(if $(filter end,$(1)),$(call
step_check_build_dir_one,$(3),$(TARGET_DIR)/$(O))))
Buildroot already does that, so when `make modules_install` is executed,
the output modules directory will be TARGET_DIR/TARGET_DIR/INSTALL_MOD_PATH.
I have no idea who is the one that must change its behavior. :-(
Any suggestions on how to proceed?
Maybe I can unexport DESTDIR before `make modules_install`...
Attached alternative patch with LINUX_MAKE_FLAGS and empty INSTALL_MOD_PATH.
>
> Otherwise I would suggest to add a comment about the reason why
> LINUX_MAKE_FLAGS
> can't be used.
>
> Best regards,
> Romain
>
>
> >
> >
> > > +# `./configure` will execute a `make modules` test case
> > > +ZFS_CONF_ENV = \
> > > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > > + ARCH=$(KERNEL_ARCH) \
> > > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > > + DEPMOD=$(HOST_DIR)/sbin/depmod
> >
> > Same here.
> >
> >
> >
> > > +
> > > ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
> > >
> > > # sysvinit installs only a commented-out modules-load.d/ config
> file
> > >
> >
>
>
Greetings!
[-- Attachment #1.2: Type: text/html, Size: 7401 bytes --]
[-- Attachment #2: package-zfs-Fix-cross-platform-compilations.patch --]
[-- Type: text/x-patch, Size: 577 bytes --]
diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
index 3b1afb419a..b2444634b6 100644
--- a/package/zfs/zfs.mk
+++ b/package/zfs/zfs.mk
@@ -13,6 +13,15 @@ ZFS_CPE_ID_PRODUCT = openzfs
ZFS_AUTORECONF = YES
+# cross compile environment for linux kernel module
+ZFS_MAKE_ENV = \
+ $(LINUX_MAKE_FLAGS) \
+ INSTALL_MOD_PATH=
+# `./configure` will execute a `make modules` test case
+ZFS_CONF_ENV = \
+ $(LINUX_MAKE_FLAGS) \
+ INSTALL_MOD_PATH=
+
ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
# sysvinit installs only a commented-out modules-load.d/ config file
[-- Attachment #3: Type: text/plain, Size: 145 bytes --]
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-22 21:27 ` José Luis Salvador Rufo
@ 2021-08-22 21:43 ` Romain Naour
2021-08-22 22:54 ` José Luis Salvador Rufo
0 siblings, 1 reply; 11+ messages in thread
From: Romain Naour @ 2021-08-22 21:43 UTC (permalink / raw)
To: José Luis Salvador Rufo
Cc: Thomas Petazzoni, Philippe Serbruyns, Yann E . MORIN, buildroot
Le 22/08/2021 à 23:27, José Luis Salvador Rufo a écrit :
> Hello Romain Naour,
>
> El dom, 22 ago 2021 a las 22:52, Romain Naour (<romain.naour@gmail.com
> <mailto:romain.naour@gmail.com>>) escribió:
>
> Hello José Luis,
>
> Le 22/08/2021 à 22:38, José Luis Salvador Rufo a écrit :
> > Hello Romain,
> >
> > El dom, 22 ago 2021 a las 22:27, Romain Naour (<romain.naour@gmail.com
> <mailto:romain.naour@gmail.com>
> > <mailto:romain.naour@gmail.com <mailto:romain.naour@gmail.com>>>) escribió:
> >
> > Hello José Luis,
> >
> > Le 22/08/2021 à 22:05, José Luis Salvador Rufo a écrit :
> > > This patch fixes the `make` executed from the `kernel.m4` in
> > > cross-platform-compilations environments:
> > > https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> <https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588>
> > <https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> <https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588>>
> > >
> > > Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com
> <mailto:salvador.joseluis@gmail.com>
> > <mailto:salvador.joseluis@gmail.com <mailto:salvador.joseluis@gmail.com>>>
> > > ---
> > > Hello all.
> > >
> > > @Romain Naour, this patch will fix the buildroot gitlab CI.
> >
> > Indeed it fix the issue!
> >
> > Tested-by: Romain Naour <romain.naour@gmail.com
> <mailto:romain.naour@gmail.com> <mailto:romain.naour@gmail.com
> <mailto:romain.naour@gmail.com>>>
> >
> > >
> > > @Philippe Serbruyns, this patch will fix your issue with your rpi4.
> > >
> > > package/zfs/zfs.mk <http://zfs.mk> <http://zfs.mk <http://zfs.mk>>
> | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/package/zfs/zfs.mk <http://zfs.mk> <http://zfs.mk
> <http://zfs.mk>> b/package/zfs/zfs.mk <http://zfs.mk>
> > <http://zfs.mk <http://zfs.mk>>
> > > index 3b1afb419a..24064cba82 100644
> > > --- a/package/zfs/zfs.mk <http://zfs.mk> <http://zfs.mk <http://zfs.mk>>
> > > +++ b/package/zfs/zfs.mk <http://zfs.mk> <http://zfs.mk <http://zfs.mk>>
> > > @@ -13,6 +13,19 @@ ZFS_CPE_ID_PRODUCT = openzfs
> > >
> > > ZFS_AUTORECONF = YES
> > >
> > > +# cross compile environment for linux kernel module
> > > +ZFS_MAKE_ENV = \
> > > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > > + ARCH=$(KERNEL_ARCH) \
> > > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > > + DEPMOD=$(HOST_DIR)/sbin/depmod
> >
> > You can replace all 4 lines with $(LINUX_MAKE_FLAGS) here instead.
> >
> > Sorry, you can not. LINUX_MAKE_FLAGS includes INSTALL_MOD_PATH, and must be
> > empty for kernel modules. If we use LINUX_MAKE_FLAGS, the module output
> will be
> > TARGET_DIR/INSTALL_MOD_PATH, as you can see in pkg-generic.mk
> <http://pkg-generic.mk>
> > <http://pkg-generic.mk <http://pkg-generic.mk>> at line 77. I already lost
> ~1-2h because of this :-(.
>
> This check allow to detect issues on a build system.
> Other packages building an out of tree kernel module is able to use
> LINUX_MAKE_FLAGS (except linux-fusion).
>
> >
> > The alternative to using $(LINUX_MAKE_FLAGS) is empty the INSTALL_MOD_PATH as
> > follows:
> > ZFS_MAKE_ENV = \
> > $(LINUX_MAKE_FLAGS) \
> > INSTALL_MOD_PATH=
> >
> > What do you prefer?
>
> If possible, a zfs patch.
>
> Here is the "problem":
>
> https://github.com/openzfs/zfs/blob/zfs-2.0.5/module/Makefile.in#L79
> <https://github.com/openzfs/zfs/blob/zfs-2.0.5/module/Makefile.in#L79>
>> INSTALL_MOD_PATH=$(DESTDIR)$(INSTALL_MOD_PATH)
This is the problem. I guess you have to remove DESTDIR when used with
INSTALL_MOD_PATH.
>
> and
>
> https://git.buildroot.net/buildroot/tree/package/pkg-generic.mk?h=2021.08-rc2#n77 <https://git.buildroot.net/buildroot/tree/package/pkg-generic.mk?h=2021.08-rc2#n77>
>> $(if $(filter end,$(1)),$(call step_check_build_dir_one,$(3),$(TARGET_DIR)/$(O))))
>
> Buildroot already does that, so when `make modules_install` is executed, the
> output modules directory will be TARGET_DIR/TARGET_DIR/INSTALL_MOD_PATH.
>
> I have no idea who is the one that must change its behavior. :-(
> Any suggestions on how to proceed?
>
> Maybe I can unexport DESTDIR before `make modules_install`...
Yes, DESTDIR is sometime miss used (see buildroot gitlog for example).
It's a bug if DESTDIR and INSTALL_MOD_PATH are used together:
https://www.gnu.org/prep/standards/html_node/DESTDIR.html
https://www.kernel.org/doc/Documentation/kbuild/modules.txt (INSTALL_MOD_PATH)
Best regards,
Romain
>
> Attached alternative patch with LINUX_MAKE_FLAGS and empty INSTALL_MOD_PATH.
>
>
> Otherwise I would suggest to add a comment about the reason why LINUX_MAKE_FLAGS
> can't be used.
>
> Best regards,
> Romain
>
>
> >
> >
> > > +# `./configure` will execute a `make modules` test case
> > > +ZFS_CONF_ENV = \
> > > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > > + ARCH=$(KERNEL_ARCH) \
> > > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > > + DEPMOD=$(HOST_DIR)/sbin/depmod
> >
> > Same here.
> >
> >
> >
> > > +
> > > ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
> > >
> > > # sysvinit installs only a commented-out modules-load.d/ config file
> > >
> >
>
>
> Greetings!
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-22 21:43 ` Romain Naour
@ 2021-08-22 22:54 ` José Luis Salvador Rufo
0 siblings, 0 replies; 11+ messages in thread
From: José Luis Salvador Rufo @ 2021-08-22 22:54 UTC (permalink / raw)
To: Romain Naour
Cc: Thomas Petazzoni, Philippe Serbruyns, Yann E . MORIN, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 7682 bytes --]
Hello Romain Naour,
El dom, 22 ago 2021 a las 23:43, Romain Naour (<romain.naour@gmail.com>)
escribió:
> Le 22/08/2021 à 23:27, José Luis Salvador Rufo a écrit :
> > Hello Romain Naour,
> >
> > El dom, 22 ago 2021 a las 22:52, Romain Naour (<romain.naour@gmail.com
> > <mailto:romain.naour@gmail.com>>) escribió:
> >
> > Hello José Luis,
> >
> > Le 22/08/2021 à 22:38, José Luis Salvador Rufo a écrit :
> > > Hello Romain,
> > >
> > > El dom, 22 ago 2021 a las 22:27, Romain Naour (<
> romain.naour@gmail.com
> > <mailto:romain.naour@gmail.com>
> > > <mailto:romain.naour@gmail.com <mailto:romain.naour@gmail.com>>>)
> escribió:
> > >
> > > Hello José Luis,
> > >
> > > Le 22/08/2021 à 22:05, José Luis Salvador Rufo a écrit :
> > > > This patch fixes the `make` executed from the `kernel.m4` in
> > > > cross-platform-compilations environments:
> > > >
> https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> > <https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> >
> > > <
> https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> > <https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> >>
> > > >
> > > > Signed-off-by: José Luis Salvador Rufo <
> salvador.joseluis@gmail.com
> > <mailto:salvador.joseluis@gmail.com>
> > > <mailto:salvador.joseluis@gmail.com <mailto:
> salvador.joseluis@gmail.com>>>
> > > > ---
> > > > Hello all.
> > > >
> > > > @Romain Naour, this patch will fix the buildroot gitlab CI.
> > >
> > > Indeed it fix the issue!
> > >
> > > Tested-by: Romain Naour <romain.naour@gmail.com
> > <mailto:romain.naour@gmail.com> <mailto:romain.naour@gmail.com
> > <mailto:romain.naour@gmail.com>>>
> > >
> > > >
> > > > @Philippe Serbruyns, this patch will fix your issue with
> your rpi4.
> > > >
> > > > package/zfs/zfs.mk <http://zfs.mk> <http://zfs.mk <
> http://zfs.mk>>
> > | 13 +++++++++++++
> > > > 1 file changed, 13 insertions(+)
> > > >
> > > > diff --git a/package/zfs/zfs.mk <http://zfs.mk> <
> http://zfs.mk
> > <http://zfs.mk>> b/package/zfs/zfs.mk <http://zfs.mk>
> > > <http://zfs.mk <http://zfs.mk>>
> > > > index 3b1afb419a..24064cba82 100644
> > > > --- a/package/zfs/zfs.mk <http://zfs.mk> <http://zfs.mk <
> http://zfs.mk>>
> > > > +++ b/package/zfs/zfs.mk <http://zfs.mk> <http://zfs.mk <
> http://zfs.mk>>
> > > > @@ -13,6 +13,19 @@ ZFS_CPE_ID_PRODUCT = openzfs
> > > >
> > > > ZFS_AUTORECONF = YES
> > > >
> > > > +# cross compile environment for linux kernel module
> > > > +ZFS_MAKE_ENV = \
> > > > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > > > + ARCH=$(KERNEL_ARCH) \
> > > > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > > > + DEPMOD=$(HOST_DIR)/sbin/depmod
> > >
> > > You can replace all 4 lines with $(LINUX_MAKE_FLAGS) here
> instead.
> > >
> > > Sorry, you can not. LINUX_MAKE_FLAGS includes INSTALL_MOD_PATH,
> and must be
> > > empty for kernel modules. If we use LINUX_MAKE_FLAGS, the module
> output
> > will be
> > > TARGET_DIR/INSTALL_MOD_PATH, as you can see in pkg-generic.mk
> > <http://pkg-generic.mk>
> > > <http://pkg-generic.mk <http://pkg-generic.mk>> at line 77. I
> already lost
> > ~1-2h because of this :-(.
> >
> > This check allow to detect issues on a build system.
> > Other packages building an out of tree kernel module is able to use
> > LINUX_MAKE_FLAGS (except linux-fusion).
> >
> > >
> > > The alternative to using $(LINUX_MAKE_FLAGS) is empty
> the INSTALL_MOD_PATH as
> > > follows:
> > > ZFS_MAKE_ENV = \
> > > $(LINUX_MAKE_FLAGS) \
> > > INSTALL_MOD_PATH=
> > >
> > > What do you prefer?
> >
> > If possible, a zfs patch.
> >
> > Here is the "problem":
> >
> > https://github.com/openzfs/zfs/blob/zfs-2.0.5/module/Makefile.in#L79
> > <https://github.com/openzfs/zfs/blob/zfs-2.0.5/module/Makefile.in#L79>
> >> INSTALL_MOD_PATH=$(DESTDIR)$(INSTALL_MOD_PATH)
>
> This is the problem. I guess you have to remove DESTDIR when used with
> INSTALL_MOD_PATH.
>
> I found that DESTDIR is already empty. Sorry, my bad.
>
> > and
> >
> >
> https://git.buildroot.net/buildroot/tree/package/pkg-generic.mk?h=2021.08-rc2#n77
> <
> https://git.buildroot.net/buildroot/tree/package/pkg-generic.mk?h=2021.08-rc2#n77
> >
> >> $(if $(filter end,$(1)),$(call
> step_check_build_dir_one,$(3),$(TARGET_DIR)/$(O))))
>
So I made:
```
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 97ee204b80..c406b32acf 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -71,6 +71,7 @@ define step_check_build_dir_one
endef
define step_check_build_dir
+ echo -e "TARGET_DIR $(TARGET_DIR)\nO $(O)\n" > /tmp/output
$(if $(filter install-staging,$(2)),\
$(if $(filter end,$(1)),$(call
step_check_build_dir_one,$(3),$(STAGING_DIR)/$(O))))
$(if $(filter install-target,$(2)),\
```
And here is the output:
```
TARGET_DIR /home/jlsalvador/src/buildroot-rpi4-tmp/per-package/zfs/target
O /home/jlsalvador/src/buildroot-rpi4-tmp
```
So the installation path will be
`/home/jlsalvador/src/buildroot-rpi4-tmp/per-package/zfs/target//home/jlsalvador/src/buildroot-rpi4-tmp`
`/home/jlsalvador/src/buildroot-rpi4-tmp` is an out-of-tree buildroot
directory that was created with the following command:
```
mkdir ~/src/buildroot-rpi4-tmp
cd ~/src/buildroot-rpi4-tmp
make O=$(pwd) -C ../buildroot menuconfig
```
Maybe this is the problem? Is `$(TARGET_DIR)/$(O)` right?
> >
> > Buildroot already does that, so when `make modules_install` is executed,
> the
> > output modules directory will be TARGET_DIR/TARGET_DIR/INSTALL_MOD_PATH.
> >
> > I have no idea who is the one that must change its behavior. :-(
> > Any suggestions on how to proceed?
> >
> > Maybe I can unexport DESTDIR before `make modules_install`...
>
> Yes, DESTDIR is sometime miss used (see buildroot gitlog for example).
>
> It's a bug if DESTDIR and INSTALL_MOD_PATH are used together:
>
> https://www.gnu.org/prep/standards/html_node/DESTDIR.html
>
> https://www.kernel.org/doc/Documentation/kbuild/modules.txt
> (INSTALL_MOD_PATH)
>
> Best regards,
> Romain
>
>
> >
> > Attached alternative patch with LINUX_MAKE_FLAGS and empty
> INSTALL_MOD_PATH.
> >
> >
> > Otherwise I would suggest to add a comment about the reason why
> LINUX_MAKE_FLAGS
> > can't be used.
> >
> > Best regards,
> > Romain
> >
> >
> > >
> > >
> > > > +# `./configure` will execute a `make modules` test case
> > > > +ZFS_CONF_ENV = \
> > > > + HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \
> > > > + ARCH=$(KERNEL_ARCH) \
> > > > + CROSS_COMPILE="$(TARGET_CROSS)" \
> > > > + DEPMOD=$(HOST_DIR)/sbin/depmod
> > >
> > > Same here.
> > >
> > >
> > >
> > > > +
> > > > ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
> > > >
> > > > # sysvinit installs only a commented-out modules-load.d/
> config file
> > > >
> > >
> >
> >
> > Greetings!
>
>
[-- Attachment #1.2: Type: text/html, Size: 14039 bytes --]
[-- Attachment #2: Type: text/plain, Size: 145 bytes --]
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-22 20:05 [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations José Luis Salvador Rufo
2021-08-22 20:27 ` Romain Naour
@ 2021-08-24 21:53 ` Thomas Petazzoni
2021-09-21 7:58 ` José Luis Salvador Rufo
1 sibling, 1 reply; 11+ messages in thread
From: Thomas Petazzoni @ 2021-08-24 21:53 UTC (permalink / raw)
To: José Luis Salvador Rufo
Cc: Romain Naour, Philippe Serbruyns, Yann E . MORIN, buildroot
On Sun, 22 Aug 2021 22:05:19 +0200
José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
> This patch fixes the `make` executed from the `kernel.m4` in
> cross-platform-compilations environments:
> https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
>
> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> ---
> Hello all.
Thanks for your contribution. Based on the feedback from Romain, I have
marked this patch as "Changes Requested".
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations
2021-08-24 21:53 ` Thomas Petazzoni
@ 2021-09-21 7:58 ` José Luis Salvador Rufo
2021-10-25 12:31 ` [Buildroot] [PATCH] package/zfs: bump version to 2.0.6 José Luis Salvador Rufo
0 siblings, 1 reply; 11+ messages in thread
From: José Luis Salvador Rufo @ 2021-09-21 7:58 UTC (permalink / raw)
To: Romain Naour
Cc: Yann E . MORIN, Philippe Serbruyns, Thomas Petazzoni, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 880 bytes --]
Hello Romain, all
I sent today a Pull Request to OpenZFS:
https://github.com/openzfs/zfs/pull/12577
Greetings.
El mar, 24 ago 2021 a las 23:53, Thomas Petazzoni (<
thomas.petazzoni@bootlin.com>) escribió:
> On Sun, 22 Aug 2021 22:05:19 +0200
> José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
>
> > This patch fixes the `make` executed from the `kernel.m4` in
> > cross-platform-compilations environments:
> > https://github.com/openzfs/zfs/blob/zfs-2.0.5/config/kernel.m4#L588
> >
> > Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> > ---
> > Hello all.
>
> Thanks for your contribution. Based on the feedback from Romain, I have
> marked this patch as "Changes Requested".
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
[-- Attachment #1.2: Type: text/html, Size: 1691 bytes --]
[-- Attachment #2: Type: text/plain, Size: 156 bytes --]
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package/zfs: bump version to 2.0.6
2021-09-21 7:58 ` José Luis Salvador Rufo
@ 2021-10-25 12:31 ` José Luis Salvador Rufo
2021-11-14 15:23 ` Thomas Petazzoni
0 siblings, 1 reply; 11+ messages in thread
From: José Luis Salvador Rufo @ 2021-10-25 12:31 UTC (permalink / raw)
To: buildroot, Romain Naour, Philippe Serbruyns
Cc: José Luis Salvador Rufo, Yann E . MORIN, Thomas Petazzoni
Added patch from upstream that fixes the `make` executed from the
`kernel.m4` in cross-platform-compilations environments.
As this version brings support for kernel up to 5.14, we update the
test cases to use the 5.14 kernel.
Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
---
I didn't find another alternative yet to:
```
ZFS_MAKE_ENV = $(LINUX_MAKE_FLAGS)
ZFS_CONF_ENV = $(LINUX_MAKE_FLAGS)
```
Any suggestion?
package/zfs/zfs.hash | 5 ++--
package/zfs/zfs.mk | 8 ++++-
support/testing/tests/package/test_zfs.py | 36 ++++++++---------------
3 files changed, 22 insertions(+), 27 deletions(-)
diff --git a/package/zfs/zfs.hash b/package/zfs/zfs.hash
index 7f4f5a59f8..0662959f6b 100644
--- a/package/zfs/zfs.hash
+++ b/package/zfs/zfs.hash
@@ -1,5 +1,6 @@
-# From https://github.com/openzfs/zfs/releases/download/zfs-2.0.5/zfs-2.0.5.sha256.asc
-sha256 3a17498d704ebf4c5d7231660f6fb44ae07a1545519f567452a4270851a86ec9 zfs-2.0.5.tar.gz
+# From https://github.com/openzfs/zfs/releases/download/zfs-2.0.6/zfs-2.0.6.sha256.asc
+sha256 44b22166b103022e3ca67cb713abdc991e274ed141b6a30568a1bd5c80b2aa95 zfs-2.0.6.tar.gz
+sha256 6ebc1cb552f1428606b6e75d2c95574685bab71a9cd8e3679d416f486dc05b74 ed3a3bdb0d59772ae4b8719cb6ffa690627bf112.patch
# Hash for license files:
sha256 1ffb70c33c4f79f04e947facc5c7851f289609256aacb47fc115f700427d9520 LICENSE
diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
index 3b1afb419a..259af99f39 100644
--- a/package/zfs/zfs.mk
+++ b/package/zfs/zfs.mk
@@ -4,15 +4,21 @@
#
################################################################################
-ZFS_VERSION = 2.0.5
+ZFS_VERSION = 2.0.6
ZFS_SITE = https://github.com/openzfs/zfs/releases/download/zfs-$(ZFS_VERSION)
ZFS_LICENSE = CDDL
ZFS_LICENSE_FILES = LICENSE COPYRIGHT
ZFS_CPE_ID_VENDOR = openzfs
ZFS_CPE_ID_PRODUCT = openzfs
+ZFS_PATCH = https://github.com/openzfs/zfs/commit/ed3a3bdb0d59772ae4b8719cb6ffa690627bf112.patch
ZFS_AUTORECONF = YES
+# cross compile environment for linux kernel module
+ZFS_MAKE_ENV = $(LINUX_MAKE_FLAGS)
+# `./configure` will execute a `make modules` test case
+ZFS_CONF_ENV = $(LINUX_MAKE_FLAGS)
+
ZFS_DEPENDENCIES = libaio openssl udev util-linux zlib
# sysvinit installs only a commented-out modules-load.d/ config file
diff --git a/support/testing/tests/package/test_zfs.py b/support/testing/tests/package/test_zfs.py
index 772a66c1e4..03bcfb3c8c 100644
--- a/support/testing/tests/package/test_zfs.py
+++ b/support/testing/tests/package/test_zfs.py
@@ -3,17 +3,15 @@ import os
import infra.basetest
-class TestZfsGlibc(infra.basetest.BRTest):
- config = \
- """
+class TestZfsBase(infra.basetest.BRTest):
+ config = """
BR2_x86_64=y
BR2_x86_corei7=y
BR2_TOOLCHAIN_EXTERNAL=y
- BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_X86_64_CORE_I7_GLIBC_STABLE=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
- BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.12.13"
+ BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.14.14"
BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/x86_64/linux.config"
BR2_PACKAGE_ZFS=y
@@ -26,6 +24,13 @@ class TestZfsGlibc(infra.basetest.BRTest):
# BR2_TARGET_ROOTFS_TAR is not set
"""
+
+class TestZfsGlibc(TestZfsBase):
+ config = TestZfsBase.config + \
+ """
+ BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_X86_64_CORE_I7_GLIBC_STABLE=y
+ """
+
def test_run(self):
kernel = os.path.join(self.builddir, "images", "bzImage")
cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
@@ -60,27 +65,10 @@ class TestZfsGlibc(infra.basetest.BRTest):
self.assertRunOk(cmd)
-class TestZfsUclibc(infra.basetest.BRTest):
- config = \
+class TestZfsUclibc(TestZfsBase):
+ config = TestZfsBase.config + \
"""
- BR2_x86_64=y
- BR2_x86_corei7=y
- BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_X86_64_CORE_I7_UCLIBC_STABLE=y
- BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
- BR2_LINUX_KERNEL=y
- BR2_LINUX_KERNEL_CUSTOM_VERSION=y
- BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.12.13"
- BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
- BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/x86_64/linux.config"
- BR2_PACKAGE_ZFS=y
- BR2_PACKAGE_PYTHON3=y
- BR2_PACKAGE_PYTHON_CFFI=y
- BR2_PACKAGE_PYTHON_SETUPTOOLS=y
- BR2_PACKAGE_ZLIB_NG=y
- BR2_PACKAGE_LIBRESSL=y
- BR2_TARGET_ROOTFS_CPIO=y
- # BR2_TARGET_ROOTFS_TAR is not set
"""
def test_run(self):
--
2.33.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/zfs: bump version to 2.0.6
2021-10-25 12:31 ` [Buildroot] [PATCH] package/zfs: bump version to 2.0.6 José Luis Salvador Rufo
@ 2021-11-14 15:23 ` Thomas Petazzoni
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2021-11-14 15:23 UTC (permalink / raw)
To: José Luis Salvador Rufo
Cc: Romain Naour, Philippe Serbruyns, Yann E . MORIN, buildroot
Hello José,
On Mon, 25 Oct 2021 14:31:18 +0200
José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
> Added patch from upstream that fixes the `make` executed from the
> `kernel.m4` in cross-platform-compilations environments.
There is no patch added in this proposed patch. It seems like this
commit log was not properly updated now that you're bumping to a new
version of ZFS.
> As this version brings support for kernel up to 5.14, we update the
> test cases to use the 5.14 kernel.
>
> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
> ---
> I didn't find another alternative yet to:
> ```
> ZFS_MAKE_ENV = $(LINUX_MAKE_FLAGS)
> ZFS_CONF_ENV = $(LINUX_MAKE_FLAGS)
> ```
> Any suggestion?
Did you try the suggestion from Arnout, which he made on August 28? See
https://lore.kernel.org/buildroot/1433accf-3050-0f2e-9701-3da87c8c7c12@mind.be/
> -class TestZfsGlibc(infra.basetest.BRTest):
> - config = \
> - """
> +class TestZfsBase(infra.basetest.BRTest):
> + config = """
It seems like you are also refactoring the ZFS test cases to avoid
duplicating the configuration for the glibc and uclibc cases. This is a
good idea, but it should be done in a separate patch, before the ZFS
bump.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-11-14 15:23 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22 20:05 [Buildroot] [PATCH] package/zfs: Fix cross-platform-compilations José Luis Salvador Rufo
2021-08-22 20:27 ` Romain Naour
2021-08-22 20:38 ` José Luis Salvador Rufo
2021-08-22 20:52 ` Romain Naour
2021-08-22 21:27 ` José Luis Salvador Rufo
2021-08-22 21:43 ` Romain Naour
2021-08-22 22:54 ` José Luis Salvador Rufo
2021-08-24 21:53 ` Thomas Petazzoni
2021-09-21 7:58 ` José Luis Salvador Rufo
2021-10-25 12:31 ` [Buildroot] [PATCH] package/zfs: bump version to 2.0.6 José Luis Salvador Rufo
2021-11-14 15:23 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.