Hi Jim, Sorry I was on PTO last week so I didn't respond. Anil was also on PTO last week and will be for this week too. He will be taking over most of the work for pushing this patch. We are planning on updating the tests to support FC. We recognize the importance of these tests for verify continued FC transport operability when new patches are introduce. One issue, which I believe Anil discussed with Ben (and possibly you) at the Developer's Meetup last month was that FC tests will require an HBA installed on one of the test systems to be able to run them. Anil is actively working on this and will be in touch with you about setting it up. For now, the patch was pushed as an RFC so you (and others) can review the transport changes. I ask that you look at it and give us feedback. Also, we do have one unit test working and another one was working, but needs to be updated with the recent changes to the unit test environment before it will work again. Thanks, John On Mon, Nov 19, 2018 at 1:24 PM Harris, James R wrote: > Hi John, > > Thanks! > > One thing I'm not seeing yet is how NVMe FC will be tested within the > automated SPDK CI system. I would expect test systems in place which would > run FC functional tests on each SPDK patch and report results into > GerritHub. The tests that these systems are running should also be checked > into the main SPDK repository and plumbed into the autotest.sh framework. > > Does Broadcom have plans to add these tests and test systems? > > Regards, > > -Jim > > > On 11/16/18, 3:40 PM, "SPDK on behalf of John Barnard" < > spdk-bounces(a)lists.01.org on behalf of john.barnard(a)broadcom.com> wrote: > > Hi Ben, Jim, et. al. > > I have pushed a patch for review ( > https://review.gerrithub.io/c/spdk/spdk/+/433685) containing the > updates to > add support for Fibre Channel in the SPDK target NVME-OF transport. > Please review and comment. Once we agree on it, I will push a merge > patch. > > Thanks, > John > _______________________________________________ > SPDK mailing list > SPDK(a)lists.01.org > https://lists.01.org/mailman/listinfo/spdk > > > _______________________________________________ > SPDK mailing list > SPDK(a)lists.01.org > https://lists.01.org/mailman/listinfo/spdk >