From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D1CC3279D for ; Tue, 6 Oct 2020 21:43:20 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3980420897 for ; Tue, 6 Oct 2020 21:43:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RJ1GVXPP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3980420897 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4C5WDP6jrPzDqCw for ; Wed, 7 Oct 2020 08:43:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2a00:1450:4864:20::131; helo=mail-lf1-x131.google.com; envelope-from=rhanley@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=RJ1GVXPP; dkim-atps=neutral Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4C5WBt3Y76zDq8g for ; Wed, 7 Oct 2020 08:41:48 +1100 (AEDT) Received: by mail-lf1-x131.google.com with SMTP id a9so7336638lfc.7 for ; Tue, 06 Oct 2020 14:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lj9e8DNnMCFR7kMCuVGvATQ9jMUIpLF08UrN5zfHgnk=; b=RJ1GVXPPfn5a89s74h5wWlp4MnfXOX1YwMRwGZkiZiQsMFc3jrsaiFv3S1DVR5Jd/F shw89m7ZsO3tsHm+SkPryOrowlC34TZGmE+TNWzxFfniWAVuhAmVzfp8t/5i7EyTeiRy JQooSxTQB8WSJvGv4/ZNKSjI24QAeB1Rna2tIH4bdaAd7T5leGVJu9iL0bju27zBUSNb 5yVCXMI/zoqeYnCyJr+yVCqLlObupG+zO3UCbPI/tXHDvBa7b6wKMRGthWcYiUJaCgrI 5kVIBlkuZsmSvGMqGiR07NTYoThCg2wAsc/nInW7x2Yi2ZyHlhwV+WBQAyxnIo9p6AeM doPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lj9e8DNnMCFR7kMCuVGvATQ9jMUIpLF08UrN5zfHgnk=; b=kXvY2eyiekKKJif7Nx8Tm7lTvwWdD7wl1LuZ0oEuVTbjTEM2kHEFmoieA542rbaKt2 oiBCmNch52xbm6Zg1drmNxq6bTjrBOIyWKh0gKFPWJhkb4pEzXY14L5qK5E1FAY4hwp7 0ed2ZEp7JyCfPzGuOLlC4BYQ0AmWEet+lwqIoU9195gd917PJsWBXgNiPJiZHg29BoYH zQv3/V7Z8Fduv9uhq1Bys+32Nwq9MTpEqOxq+4zKdChQM3vHHvVLW60xcHopdo7y2XPv PKhjY87gLhxQPKKSR/boaYKQa7Hi6QcbUMiaNdIjlQAZMYKiONXbHpTT23tpwAfcXyGh GogQ== X-Gm-Message-State: AOAM532gwwDNKYquoMF7I97o4TAGh3MoNsyDkRinQNqaRJ41VFCKS1hj JnSHznMQnxVRgVCkbQ3RO/P+rg3cFksUO21AwrDeGg== X-Google-Smtp-Source: ABdhPJxiVh5m9RtT7N+K7EEnSrHu5vfOTLeqjNahLumoasGw8fXCbh/qtTh+z1nJacChpk++h4qVrv5GZILujIk9Bdo= X-Received: by 2002:ac2:4576:: with SMTP id k22mr1095804lfm.247.1602020500321; Tue, 06 Oct 2020 14:41:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Hanley Date: Tue, 6 Oct 2020 14:41:29 -0700 Message-ID: Subject: Re: adding sync method in phosphor-time-manager To: "Velumani T-ERS,HCLTech" Content-Type: multipart/alternative; boundary="000000000000d8b9bb05b1077633" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "openbmc@lists.ozlabs.org" , Patrick Williams Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --000000000000d8b9bb05b1077633 Content-Type: text/plain; charset="UTF-8" I think it makes a lot of sense to make this configurable. However, I wonder if we should consider making it a collection with a priority levels instead of a single enum. I can envision a need for someone to say, "Use NTP when it's available, but if the network is down then use the host." While we're on the subject, has anyone ever taken a look at using roughtime on a BMC? I imagine it could a really valuable extension to phosphor-time-manager some time in the future. https://blog.cloudflare.com/roughtime/ Regards, Richard On Tue, Oct 6, 2020 at 10:40 AM Velumani T-ERS,HCLTech wrote: > Classification: > > Hi Team, > > > > We wanted to add another time sync method in phosphor-time-manager to get > the time from the host and set it to BMC. To have this option configurable > I propose a dbus property in the time interface(given below). Please > provide your feedback/comments. > > > > > https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Time/Synchronization.interface.yaml > > enumerations: > > - name: Method > > description: > > > Possible methods of time synchronization. > > values: > > - name: NTP > > description: > > > Sync by using the Network Time Protocol. > > - name: Manual > > description: > > > Sync time manually. > > - name: HostSync > > description: > > > Sync the time from host. > > > > Regards, > > Velu > ::DISCLAIMER:: > ------------------------------ > The contents of this e-mail and any attachment(s) are confidential and > intended for the named recipient(s) only. E-mail transmission is not > guaranteed to be secure or error-free as information could be intercepted, > corrupted, lost, destroyed, arrive late or incomplete, or may contain > viruses in transmission. The e mail and its contents (with or without > referred errors) shall therefore not attach any liability on the originator > or HCL or its affiliates. Views or opinions, if any, presented in this > email are solely those of the author and may not necessarily reflect the > views or opinions of HCL or its affiliates. Any form of reproduction, > dissemination, copying, disclosure, modification, distribution and / or > publication of this message without the prior written consent of authorized > representative of HCL is strictly prohibited. If you have received this > email in error please delete it and notify the sender immediately. Before > opening any email and/or attachments, please check them for viruses and > other defects. > ------------------------------ > --000000000000d8b9bb05b1077633 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think it makes a lot of sense to make this configurable.= However, I wonder if we should consider making it a collection with a prio= rity levels instead of a single enum. I can envision a need for someone to = say, "Use NTP when it's available, but if the network is down then= use the host."=C2=A0

While we're on the subjec= t, has anyone ever taken a look at using roughtime on a BMC? I imagine it c= ould a really valuable extension to phosphor-time-manager some time in the = future.

Regards,<= /div>
Richard

On Tue, Oct 6, 2020 at 10:40 AM Velumani T-ERS,HCLTe= ch <velumanit@hcl.com> wrote= :

Classification:

Hi Team,

=C2=A0

We wanted to add another time sync method in phospho= r-time-manager to get the time from the host and set it to BMC. To have thi= s option configurable I propose a dbus property in the time interface(given= below). Please provide your feedback/comments.

=C2=A0

https://github.com/openbmc/phosphor-dbus-interfaces/= blob/master/xyz/openbmc_project/Time/Synchronization.interface.yaml<= /u>

enumerations:

=C2=A0=C2=A0=C2=A0 - name: Method

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 description: ><= /u>

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Possible = methods of time synchronization.

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 values:=

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - name: N= TP

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 description: >

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 Sync by using the Network Time Protocol.

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - name: M= anual

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 description: >

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 Sync time manually.

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - n= ame: HostSync

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 description: >

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 Sync the time from host.

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0

Regards,

Velu

::DISCLAIMER::
The contents of this e-mail and any attachment(s) are confidential and inte= nded for the named recipient(s) only. E-mail transmission is not guaranteed= to be secure or error-free as information could be intercepted, corrupted,= lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its con= tents (with or without referred errors) shall therefore not attach any liab= ility on the originator or HCL or its affiliates. Views or opinions, if any= , presented in this email are solely those of the author and may not necessarily reflect the views or opinions = of HCL or its affiliates. Any form of reproduction, dissemination, copying,= disclosure, modification, distribution and / or publication of this messag= e without the prior written consent of authorized representative of HCL is strictly prohibited. If you have re= ceived this email in error please delete it and notify the sender immediate= ly. Before opening any email and/or attachments, please check them for viru= ses and other defects.
--000000000000d8b9bb05b1077633--